You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/16 13:20:08 UTC
[GitHub] [arrow] js8544 opened a new pull request, #14657: ARROW-18343: [C++] AllocateBitmap() with out parameter is declared but not defined
js8544 opened a new pull request, #14657:
URL: https://github.com/apache/arrow/pull/14657
[This variant of AllocateBitmap](https://github.com/apache/arrow/blob/master/cpp/src/arrow/buffer.h#L483) is declared but not defined in buffer.cc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #14657: ARROW-18343: [C++] AllocateBitmap() with out parameter is declared but not defined
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14657:
URL: https://github.com/apache/arrow/pull/14657#issuecomment-1317073952
Can you find out since when that has been the case? If there have been at least two releases without, perhaps we can safely remove it :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14657: ARROW-18343: [C++] Remove AllocateBitmap() with out parameter
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14657:
URL: https://github.com/apache/arrow/pull/14657#issuecomment-1324562308
Benchmark runs are scheduled for baseline = b9dd41607cb7dd7afd50e3ceb99c68e79e7733a0 and contender = 3718d8a3f9a4586a5f46bb4bb36dd5f6f31d0a6c. 3718d8a3f9a4586a5f46bb4bb36dd5f6f31d0a6c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/25d543fc3aae4898a140c2bead0f0aac...ec3a3aebbb5044309ea88a712edaae5c/)
[Finished :arrow_down:0.13% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ca41d3e984ab468883caadb5c8a24036...641d9780eef04e359fdfc670159c96ed/)
[Finished :arrow_down:1.36% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b8d9d0826e544c73b803e9df028a8a6c...b3985f2f7cbe4ed585602746da1c35cc/)
[Finished :arrow_down:0.31% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/4854dda672394261a1349bcf674dcf31...845072ac3fda44a6b815be0bc477239e/)
Buildkite builds:
[Finished] [`3718d8a3` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1898)
[Finished] [`3718d8a3` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1920)
[Finished] [`3718d8a3` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1889)
[Finished] [`3718d8a3` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1912)
[Finished] [`b9dd4160` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1897)
[Finished] [`b9dd4160` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1919)
[Finished] [`b9dd4160` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1888)
[Finished] [`b9dd4160` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1911)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #14657: ARROW-18343: [C++] AllocateBitmap() with out parameter is declared but not defined
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14657:
URL: https://github.com/apache/arrow/pull/14657#issuecomment-1318637703
> Either way since it has been like this for over 2 years, perhaps it's best to remove this api now?
Yes, definitely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #14657: ARROW-18343: [C++] AllocateBitmap() with out parameter is declared but not defined
Posted by GitBox <gi...@apache.org>.
js8544 commented on PR #14657:
URL: https://github.com/apache/arrow/pull/14657#issuecomment-1317244454
> Can you find out since when that has been the case? If there have been at least two releases without, perhaps we can safely remove it :-)
The definition is removed in [this PR](https://github.com/apache/arrow/pull/7335/files#diff-590dc662378ffd51c79ee710b3058838e95a9eb16877435b131018f0becb9faaL307) but the api is kept. It appeared to be a mistake to remove the definition back then because this api is not marked deprecated in [this PR](https://github.com/apache/arrow/pull/6863/files#diff-2edce6fb9f08ce495de42b07497d9d43d57b12051ef5aa997ad6056eb207b70dR514) (or perhaps it should be marked deprecated but was overlooked). Either way since it has been like this for over 2 years, perhaps it's best to remove this api?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou merged pull request #14657: ARROW-18343: [C++] Remove AllocateBitmap() with out parameter
Posted by GitBox <gi...@apache.org>.
pitrou merged PR #14657:
URL: https://github.com/apache/arrow/pull/14657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #14657: ARROW-18343: [C++] AllocateBitmap() with out parameter is declared but not defined
Posted by GitBox <gi...@apache.org>.
js8544 commented on PR #14657:
URL: https://github.com/apache/arrow/pull/14657#issuecomment-1319485987
This api is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14657: ARROW-18343: [C++] AllocateBitmap() with out parameter is declared but not defined
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14657:
URL: https://github.com/apache/arrow/pull/14657#issuecomment-1317010939
https://issues.apache.org/jira/browse/ARROW-18343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org