You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/03/19 13:18:51 UTC
[GitHub] flink pull request #5720: [FLINK-8957][tests] Port JMXJobManagerMetricTest t...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5720
[FLINK-8957][tests] Port JMXJobManagerMetricTest to flip6
Based on #5690.
## What is the purpose of the change
Ports the `JMXJobManagerMetricTest` to use `MiniClusterResource`.
## Verifying this change
Run `JMXJobManagerMetricTest` with `flip6` profile enabled/disabled.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 8957
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5720.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5720
----
commit 42e97294d1919c7020c687f9c389f61871cc3c6a
Author: zentol <ch...@...>
Date: 2018-03-19T13:17:34Z
[FLINK-8957][tests] Port JMXJobManagerMetricTest to flip6
----
---
[GitHub] flink pull request #5720: [FLINK-8957][tests] Port JMXJobManagerMetricTest t...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5720#discussion_r176482195
--- Diff: flink-metrics/flink-metrics-jmx/src/test/java/org/apache/flink/runtime/jobmanager/JMXJobManagerMetricTest.java ---
@@ -92,28 +101,26 @@ public void testJobManagerJMXMetricAccess() throws Exception {
true),
null));
- flink.waitForActorsToBeAlive();
-
- flink.submitJobDetached(jobGraph);
+ ClusterClient<?> client = MINI_CLUSTER_RESOURCE.getClusterClient();
+ client.setDetached(true);
+ client.submitJob(jobGraph, JMXJobManagerMetricTest.class.getClassLoader());
- Future<Object> jobRunning = flink.getLeaderGateway(deadline.timeLeft())
- .ask(new TestingJobManagerMessages.WaitForAllVerticesToBeRunning(jobGraph.getJobID()), deadline.timeLeft());
- Await.ready(jobRunning, deadline.timeLeft());
+ FutureUtils.retrySuccesfulWithDelay(
+ () -> client.getJobStatus(jobGraph.getJobID()),
+ Time.milliseconds(10),
+ deadline,
+ status -> status == JobStatus.RUNNING,
--- End diff --
The check whether the job is running does not necessarily mean that all vertices are running. But I guess what we are waiting for is the initialization of the `CheckpointStatsTracker`.
---
[GitHub] flink issue #5720: [FLINK-8957][tests] Port JMXJobManagerMetricTest to flip6
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5720
merging.
---
[GitHub] flink pull request #5720: [FLINK-8957][tests] Port JMXJobManagerMetricTest t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5720
---