Re: [PR] [WIP]HIVE-29299: Upgrade Spring to 6.2.12 and spring-ldap-core to 3.3.4 to resolve CVE-2025-41249 [hive]

["deniskuzZ (via GitHub)" <gi...@apache.org>]

deniskuzZ commented on code in PR #6401:
URL: https://github.com/apache/hive/pull/6401#discussion_r3027581723


##########
standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/standalone/IcebergCatalogConfiguration.java:
##########
@@ -80,9 +78,8 @@ public static ServletRegistrationBean<HttpServlet> createRestCatalogServlet(Conf
     if (descriptor == null || descriptor.getServlet() == null) {
       throw new IllegalStateException("Failed to create Iceberg REST Catalog servlet");
     }
-
-    ServletRegistrationBean<HttpServlet> registration =
-        new ServletRegistrationBean<>(descriptor.getServlet(), "/" + servletPath + "/*");
+    ServletRegistrationBean<?> registration =

Review Comment:
   why not simply replace the import?
   ````
   - javax.servlet.http.HttpServlet
   + jakarta.servlet.http.HttpServlet
   ````
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org