You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Robert Lichtenberger (JIRA)" <ji...@apache.org> on 2011/01/20 11:10:44 UTC
[jira] Created: (COMPRESS-125) BZip2CompressorInputStream throws
IOException if underlying stream returns available() == 0
BZip2CompressorInputStream throws IOException if underlying stream returns available() == 0
-------------------------------------------------------------------------------------------
Key: COMPRESS-125
URL: https://issues.apache.org/jira/browse/COMPRESS-125
Project: Commons Compress
Issue Type: Bug
Components: Compressors
Affects Versions: 1.1
Reporter: Robert Lichtenberger
Priority: Minor
BzipCompressorInput,init() will throw an IOException, if the passed stream returns 0 for available():
{code:title=BzipCompressorInput,.java|borderStyle=solid}
private void init() throws IOException {
...
if (in.available() == 0) {
throw new IOException("Empty InputStream");
}
...
}
{code}
I think this is not correct, because the underlying stream may indeed be able to only return 0 bytes without blocking but may be able to block a little and then return some more bytes.
Note also the change in the API documentation from: "Returns the number of bytes that can be read " (1.4.2) to "Returns an estimate of the number of bytes that can be read".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Updated] (COMPRESS-125) BZip2CompressorInputStream throws
IOException if underlying stream returns available() == 0
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COMPRESS-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb updated COMPRESS-125:
--------------------------
Description:
BZip2CompressorInputStream,init() will throw an IOException, if the passed stream returns 0 for available():
{code:title=BZip2CompressorInputStream.java|borderStyle=solid}
private void init() throws IOException {
...
if (in.available() == 0) {
throw new IOException("Empty InputStream");
}
...
}
{code}
I think this is not correct, because the underlying stream may indeed be able to only return 0 bytes without blocking but may be able to block a little and then return some more bytes.
Note also the change in the API documentation from: "Returns the number of bytes that can be read " (1.4.2) to "Returns an estimate of the number of bytes that can be read".
was:
BzipCompressorInput,init() will throw an IOException, if the passed stream returns 0 for available():
{code:title=BzipCompressorInput,.java|borderStyle=solid}
private void init() throws IOException {
...
if (in.available() == 0) {
throw new IOException("Empty InputStream");
}
...
}
{code}
I think this is not correct, because the underlying stream may indeed be able to only return 0 bytes without blocking but may be able to block a little and then return some more bytes.
Note also the change in the API documentation from: "Returns the number of bytes that can be read " (1.4.2) to "Returns an estimate of the number of bytes that can be read".
Fix class name
> BZip2CompressorInputStream throws IOException if underlying stream returns available() == 0
> -------------------------------------------------------------------------------------------
>
> Key: COMPRESS-125
> URL: https://issues.apache.org/jira/browse/COMPRESS-125
> Project: Commons Compress
> Issue Type: Bug
> Components: Compressors
> Affects Versions: 1.1
> Reporter: Robert Lichtenberger
> Priority: Minor
>
> BZip2CompressorInputStream,init() will throw an IOException, if the passed stream returns 0 for available():
> {code:title=BZip2CompressorInputStream.java|borderStyle=solid}
> private void init() throws IOException {
> ...
> if (in.available() == 0) {
> throw new IOException("Empty InputStream");
> }
> ...
> }
> {code}
> I think this is not correct, because the underlying stream may indeed be able to only return 0 bytes without blocking but may be able to block a little and then return some more bytes.
> Note also the change in the API documentation from: "Returns the number of bytes that can be read " (1.4.2) to "Returns an estimate of the number of bytes that can be read".
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (COMPRESS-125) BZip2CompressorInputStream throws
IOException if underlying stream returns available() == 0
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COMPRESS-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb resolved COMPRESS-125.
---------------------------
Resolution: Fixed
Fix Version/s: 1.2
Agreed - the check serves no purpose and can cause unnecessary failures
> BZip2CompressorInputStream throws IOException if underlying stream returns available() == 0
> -------------------------------------------------------------------------------------------
>
> Key: COMPRESS-125
> URL: https://issues.apache.org/jira/browse/COMPRESS-125
> Project: Commons Compress
> Issue Type: Bug
> Components: Compressors
> Affects Versions: 1.1
> Reporter: Robert Lichtenberger
> Priority: Minor
> Fix For: 1.2
>
>
> BZip2CompressorInputStream,init() will throw an IOException, if the passed stream returns 0 for available():
> {code:title=BZip2CompressorInputStream.java|borderStyle=solid}
> private void init() throws IOException {
> ...
> if (in.available() == 0) {
> throw new IOException("Empty InputStream");
> }
> ...
> }
> {code}
> I think this is not correct, because the underlying stream may indeed be able to only return 0 bytes without blocking but may be able to block a little and then return some more bytes.
> Note also the change in the API documentation from: "Returns the number of bytes that can be read " (1.4.2) to "Returns an estimate of the number of bytes that can be read".
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira