You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "sureshanaparti (via GitHub)" <gi...@apache.org> on 2025/01/24 10:57:59 UTC

[PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

sureshanaparti opened a new pull request, #10265:
URL: https://github.com/apache/cloudstack/pull/10265

   ### Description
   
   This PR allows quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume, addresses #10106.
   
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ******************************************************************************* -->
   <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ******************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   - [ ] test (unit or integration test code)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   ### Screenshots (if appropriate):
   
   ### How Has This Been Tested?
   
   Checked the create snapshot UI from instance and volume.
   
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   
   #### How did you try to break this feature and the system with this change?
   
   <!-- see how your change affects other areas of the code, etc. -->
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#discussion_r2055651682


##########
engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/vmsnapshot/StorageVMSnapshotStrategy.java:
##########
@@ -449,14 +454,14 @@ protected SnapshotInfo createDiskSnapshot(VMSnapshot vmSnapshot, List<SnapshotIn
         return snapshotInfo;
     }
 
-    protected CreateSnapshotPayload setPayload(VolumeInfo vol, SnapshotVO snapshotCreate) {
+    protected CreateSnapshotPayload setPayload(VolumeInfo vol, SnapshotVO snapshotCreate, boolean quiescevm) {
         CreateSnapshotPayload payload = new CreateSnapshotPayload();
         payload.setSnapshotId(snapshotCreate.getId());
         payload.setSnapshotPolicyId(SnapshotVO.MANUAL_POLICY_ID);
         payload.setLocationType(snapshotCreate.getLocationType());
         payload.setAccount(accountService.getAccount(vol.getAccountId()));
         payload.setAsyncBackup(false);
-        payload.setQuiescevm(false);
+        payload.setQuiescevm(quiescevm);

Review Comment:
   It is passed with the payload (as send in the API cmd) in the snapshotInfo, the underlying storage (if supports) would make use of it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2844816064

   @sureshanaparti , is it realistic to have this finished/fixed before 4.19.3?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2817978404

   @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2818538376

   > Hmm an interesting development: When taking a snapshot from VM -> "Take Instance Snapshot" with "Quiesce Instance" enabled, it will make a snapshot and quiesce process works. When taking a snapshot from Volume -> "Take Snapshot" with "Quiesce Instance" enabled, it will not quiesce the instance and even logs `"quiesceVm":false`
   > 
   > VM -> "Take Instance Snapshot" logfile: https://pastebin.com/hYMHDxKF Volume -> "Take Snapshot" logfile: https://pastebin.com/EF33nP6z
   
   @Rubueno Fixed to set quiescevm in the snapshot payload (from the quiescevm parameter) while taking a snapshot from volume, please check.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2612376088

   @Rubueno , any chance you can test this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "Rubueno (via GitHub)" <gi...@apache.org>.
Rubueno commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2630746994

   Hmm an interesting development: When taking a snapshot from VM -> "Take Instance Snapshot" with "Quiesce Instance" enabled, it will make a snapshot and quiesce process works. When taking a snapshot from Volume -> "Take Snapshot" with "Quiesce Instance" enabled, it will not quiesce the instance and even logs `"quiesceVm":false`
   
   VM -> "Take Instance Snapshot" logfile: https://pastebin.com/hYMHDxKF  
   Volume -> "Take Snapshot" logfile: https://pastebin.com/EF33nP6z


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2630528514

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2704143506

   @sureshanaparti can you comment on @Rubueno 's results?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2818754463

   Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13122


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on code in PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#discussion_r2055469625


##########
engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/vmsnapshot/StorageVMSnapshotStrategy.java:
##########
@@ -449,14 +454,14 @@ protected SnapshotInfo createDiskSnapshot(VMSnapshot vmSnapshot, List<SnapshotIn
         return snapshotInfo;
     }
 
-    protected CreateSnapshotPayload setPayload(VolumeInfo vol, SnapshotVO snapshotCreate) {
+    protected CreateSnapshotPayload setPayload(VolumeInfo vol, SnapshotVO snapshotCreate, boolean quiescevm) {
         CreateSnapshotPayload payload = new CreateSnapshotPayload();
         payload.setSnapshotId(snapshotCreate.getId());
         payload.setSnapshotPolicyId(SnapshotVO.MANUAL_POLICY_ID);
         payload.setLocationType(snapshotCreate.getLocationType());
         payload.setAccount(accountService.getAccount(vol.getAccountId()));
         payload.setAsyncBackup(false);
-        payload.setQuiescevm(false);
+        payload.setQuiescevm(quiescevm);

Review Comment:
   @sureshanaparti this payload is being used to set in SnapshotObjecTO, but it is not used anywhere. or am I missing anything ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "Rubueno (via GitHub)" <gi...@apache.org>.
Rubueno commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2612421279

   > @Rubueno , any chance you can test this?
   
   Thanks for your efforts @DaanHoogland ! I'm abroad right now, but I'll try to find time next week.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2612278649

   UI build: :heavy_check_mark:
   Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10265 (QA-JID-531)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2818103090

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13120


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2821255866

   @sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2823106505

   <b>[SF] Trillian test result (tid-13086)</b>
   Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
   Total time taken: 56548 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10265-t13086-kvm-ol8.zip
   Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2820877916

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13131


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2817976748

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "Rubueno (via GitHub)" <gi...@apache.org>.
Rubueno commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2621233918

   > > > Thanks! I've just tested the change but it does not seem the quiesce option is present in the "Take Instance volume Snapshot" window. I've tested with local, RBD and NFS on KVM.
   > > 
   > > 
   > > You are right, I only see it on the take instance snapshot dialog. Can you comment @sureshanaparti ?
   > 
   > quiesce option will not available in both VM -> "Take Instance volume Snapshot" & Volume -> "Take Snapshot" dialogs, when the volume response returns quiescevm as false.
   
   But in this case it is present in Volume -> "Take Snapshot" and VM -> "Take Instance Snapshot" dialogs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2809089518

   seems like for the case "For a running VM - "Take Instance Snapshot"" it is supported only for VMware.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2612246602

   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2630527675

   > @sureshanaparti In our env I cannot proceed with testing this, and thus does not resolve issue #10106, as both dialog boxes give different output at the moment
   
   ok @Rubueno, does your env has the updated code / pkgs from this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2630707509

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12308


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2771012007

   <b>[SF] Trillian test result (tid-12873)</b>
   Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
   Total time taken: 47416 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10265-t12873-kvm-ol8.zip
   Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_12_start_vm_multiple_volumes_allocated | `Error` | 13.16 | test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2809078375

   I've done some review/testing and discussed with Suresh, following are the findings.
   
   There are 3 forms where we are using "quiescevm"
   
   1. For a stopped VM - "Take Instance volume Snapshot"
   2. For a volume - "Take Snapshot"
   3. For a running VM - "Take Instance Snapshot"
   
   For 1 and 2, as @sureshanaparti said it is controlled by "quiescevm" param in the volume response. I see that it has made it consistent with this PR. Though there is another bug like @Rubueno mentioned, the value of "quiescevm" is not honored in the API.
   
   For 3, "Take Instance Snapshot" "quiescevm" is there by default. May be we can check for which hypervisors it is supported and keep only for those.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2820680804

   @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2821257358

   > Noticed below issues in the Simulator CI tests, seems to be python (version) issue. cc @DaanHoogland
   > 
   > ```
   > 2025-04-22 12:23:28,676 - DEBUG - ::::::::::::STARTED : TC: Failure: :::::::::::
   > 
   > 2025-04-22 12:23:28,677 - CRITICAL - EXCEPTION: Failure:: ['Traceback (most recent call last):\n', '  File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/unittest/case.py", line 59, in testPartExecutor\n    yield\n', '  File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/unittest/case.py", line 591, in run\n    self._callTestMethod(testMethod)\n', '  File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/unittest/case.py", line 549, in _callTestMethod\n    method()\n', '  File "/home/runner/.local/lib/python3.10/site-packages/nose/failure.py", line 35, in runTest\n    raise self.exc_val.with_traceback(self.tb)\n', '  File "/home/runner/.local/lib/python3.10/site-packages/nose/loader.py", line 335, in loadTestsFromName\n    module = self.importer.importFromPath(\n', '  File "/home/runner/.local/lib/python3.10/site-packages/nose/importer.py", line 162, in importFromPath\n    return self.importFromDir(dir_path, fqname)\n', '  File "/home/runner/.local/lib/py
 thon3.10/site-packages/nose/importer.py", line 198, in importFromDir\n    mod = load_module(part_fqname, fh, filename, desc)\n', '  File "/home/runner/.local/lib/python3.10/site-packages/nose/importer.py", line 128, in load_module\n    spec.loader.exec_module(mod)\n', '  File "<frozen importlib._bootstrap_external>", line 883, in exec_module\n', '  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed\n', '  File "/home/runner/work/cloudstack/cloudstack/test/integration/smoke/test_certauthority_root.py", line 27, in <module>\n    from OpenSSL.crypto import FILETYPE_PEM, verify, X509\n', "ImportError: cannot import name 'verify' from 'OpenSSL.crypto' (unknown location)\n"]
   > 
   > 2025-04-22 12:23:28,678 - DEBUG - TestCaseName: Failure:; Time Taken: 0 Seconds; StartTime: Tue Apr 22 12:23:28 2025; EndTime: Tue Apr 22 12:23:28 2025; Result: EXCEPTION
   > ```
   > 
   > ```
   > Exception occurred during processing of request from ('127.0.0.1', 55687)
   > 
   > Traceback (most recent call last):
   > 
   >   File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/socketserver.py", line 683, in process_request_thread
   > 
   >     self.finish_request(request, client_address)
   > 
   >   File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/socketserver.py", line 360, in finish_request
   > 
   >     self.RequestHandlerClass(request, client_address, self)
   > 
   >   File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/socketserver.py", line 747, in __init__
   > 
   >     self.handle()
   > 
   >   File "/home/runner/.local/lib/python3.10/site-packages/ipmisim/ipmisim.py", line 443, in handle
   > 
   >     return IpmiServerContext().handle(data, address, socket)
   > 
   >   File "/home/runner/.local/lib/python3.10/site-packages/ipmisim/ipmisim.py", line 125, in handle
   > 
   >     self._got_request(data, address, self.session)
   > 
   >   File "/home/runner/.local/lib/python3.10/site-packages/ipmisim/ipmisim.py", line 222, in _got_request
   > 
   >     session._ipmi20(data)
   > 
   >   File "/home/runner/.local/lib/python3.10/site-packages/ipmisim/fakesession.py", line 127, in _ipmi20
   > 
   >     decrypter = AES.new(self.aeskey, AES.MODE_CBC, iv)
   > 
   >   File "/home/runner/.local/lib/python3.10/site-packages/Crypto/Cipher/AES.py", line 95, in new
   > 
   >     return AESCipher(key, *args, **kwargs)
   > 
   >   File "/home/runner/.local/lib/python3.10/site-packages/Crypto/Cipher/AES.py", line 59, in __init__
   > 
   >     blockalgo.BlockAlgo.__init__(self, _AES, key, *args, **kwargs)
   > 
   >   File "/home/runner/.local/lib/python3.10/site-packages/Crypto/Cipher/blockalgo.py", line 141, in __init__
   > 
   >     self._cipher = factory.new(key, *args, **kwargs)
   > 
   > SystemError: PY_SSIZE_T_CLEAN macro must be defined for '#' formats
   > ```
   
   @sureshanaparti 
   refer to #10762 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2821249679

   Noticed below issues in the Simulator CI tests, seems to be python (version) issue. cc @DaanHoogland 
   
   ```
   2025-04-22 12:23:28,676 - DEBUG - ::::::::::::STARTED : TC: Failure: :::::::::::
   
   2025-04-22 12:23:28,677 - CRITICAL - EXCEPTION: Failure:: ['Traceback (most recent call last):\n', '  File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/unittest/case.py", line 59, in testPartExecutor\n    yield\n', '  File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/unittest/case.py", line 591, in run\n    self._callTestMethod(testMethod)\n', '  File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/unittest/case.py", line 549, in _callTestMethod\n    method()\n', '  File "/home/runner/.local/lib/python3.10/site-packages/nose/failure.py", line 35, in runTest\n    raise self.exc_val.with_traceback(self.tb)\n', '  File "/home/runner/.local/lib/python3.10/site-packages/nose/loader.py", line 335, in loadTestsFromName\n    module = self.importer.importFromPath(\n', '  File "/home/runner/.local/lib/python3.10/site-packages/nose/importer.py", line 162, in importFromPath\n    return self.importFromDir(dir_path, fqname)\n', '  File "/home/runner/.local/lib/pyth
 on3.10/site-packages/nose/importer.py", line 198, in importFromDir\n    mod = load_module(part_fqname, fh, filename, desc)\n', '  File "/home/runner/.local/lib/python3.10/site-packages/nose/importer.py", line 128, in load_module\n    spec.loader.exec_module(mod)\n', '  File "<frozen importlib._bootstrap_external>", line 883, in exec_module\n', '  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed\n', '  File "/home/runner/work/cloudstack/cloudstack/test/integration/smoke/test_certauthority_root.py", line 27, in <module>\n    from OpenSSL.crypto import FILETYPE_PEM, verify, X509\n', "ImportError: cannot import name 'verify' from 'OpenSSL.crypto' (unknown location)\n"]
   
   2025-04-22 12:23:28,678 - DEBUG - TestCaseName: Failure:; Time Taken: 0 Seconds; StartTime: Tue Apr 22 12:23:28 2025; EndTime: Tue Apr 22 12:23:28 2025; Result: EXCEPTION
   ```
   
   
   ```
   Exception occurred during processing of request from ('127.0.0.1', 55687)
   
   Traceback (most recent call last):
   
     File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/socketserver.py", line 683, in process_request_thread
   
       self.finish_request(request, client_address)
   
     File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/socketserver.py", line 360, in finish_request
   
       self.RequestHandlerClass(request, client_address, self)
   
     File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/socketserver.py", line 747, in __init__
   
       self.handle()
   
     File "/home/runner/.local/lib/python3.10/site-packages/ipmisim/ipmisim.py", line 443, in handle
   
       return IpmiServerContext().handle(data, address, socket)
   
     File "/home/runner/.local/lib/python3.10/site-packages/ipmisim/ipmisim.py", line 125, in handle
   
       self._got_request(data, address, self.session)
   
     File "/home/runner/.local/lib/python3.10/site-packages/ipmisim/ipmisim.py", line 222, in _got_request
   
       session._ipmi20(data)
   
     File "/home/runner/.local/lib/python3.10/site-packages/ipmisim/fakesession.py", line 127, in _ipmi20
   
       decrypter = AES.new(self.aeskey, AES.MODE_CBC, iv)
   
     File "/home/runner/.local/lib/python3.10/site-packages/Crypto/Cipher/AES.py", line 95, in new
   
       return AESCipher(key, *args, **kwargs)
   
     File "/home/runner/.local/lib/python3.10/site-packages/Crypto/Cipher/AES.py", line 59, in __init__
   
       blockalgo.BlockAlgo.__init__(self, _AES, key, *args, **kwargs)
   
     File "/home/runner/.local/lib/python3.10/site-packages/Crypto/Cipher/blockalgo.py", line 141, in __init__
   
       self._cipher = factory.new(key, *args, **kwargs)
   
   SystemError: PY_SSIZE_T_CLEAN macro must be defined for '#' formats
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2615677201

   > Thanks! I've just tested the change but it does not seem the quiesce option is present in the "Take Instance volume Snapshot" window. I've tested with local, RBD and NFS on KVM.
   
   You are right, I only see it on the take instance snapshot dialog. Can you comment @sureshanaparti ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "Rubueno (via GitHub)" <gi...@apache.org>.
Rubueno commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2615559327

   > > > @Rubueno , any chance you can test this?
   > > 
   > > 
   > > Thanks for your efforts @DaanHoogland ! I'm abroad right now, but I'll try to find time next week.
   > 
   > have a good trip @Rubueno , I hope to start on a release by the end of next week, no pressure ;)
   
   Thanks! I've just tested the change but it does not seem the quiesce option is present in the "Take Instance volume Snapshot" window. I've tested with local, RBD and NFS.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2630529591

   @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2612258669

   ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10265?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 4.29%. Comparing base [(`2aa2e92`)](https://app.codecov.io/gh/apache/cloudstack/commit/2aa2e92dff4c4ad95200bd80b58745aa1d4b9b41?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`4b79dc3`)](https://app.codecov.io/gh/apache/cloudstack/commit/4b79dc3245369d95861d75769c815054d69b7771?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 2 commits behind head on 4.19.
   
   > :exclamation:  There is a different number of reports uploaded between BASE (2aa2e92) and HEAD (4b79dc3). Click for more details.
   > 
   > <details><summary>HEAD has 1 upload less than BASE</summary>
   >
   >| Flag | BASE (2aa2e92) | HEAD (4b79dc3) |
   >|------|------|------|
   >|unittests|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@              Coverage Diff              @@
   ##               4.19   #10265       +/-   ##
   =============================================
   - Coverage     15.14%    4.29%   -10.85%     
   =============================================
     Files          5408      366     -5042     
     Lines        473822    29589   -444233     
     Branches      57825     5186    -52639     
   =============================================
   - Hits          71762     1272    -70490     
   + Misses       394037    28172   -365865     
   + Partials       8023      145     -7878     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10265/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10265/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.29% <ø> (ø)` | |
   | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10265/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10265?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2846473639

   > @sureshanaparti , is it realistic to have this finished/fixed before 4.19.3?
   
   @DaanHoogland no further changes on this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2621185150

   > > Thanks! I've just tested the change but it does not seem the quiesce option is present in the "Take Instance volume Snapshot" window. I've tested with local, RBD and NFS on KVM.
   > 
   > You are right, I only see it on the take instance snapshot dialog. Can you comment @sureshanaparti ?
   
    quiesce option will not available in both VM -> "Take Instance volume Snapshot"  & Volume -> "Take Snapshot" dialogs, when the volume response returns quiescevm as false.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2769010664

   @rosi-shapeblue a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2818705528

   > I've done some review/testing and discussed with Suresh, following are the findings.
   > 
   > There are 3 forms where we are using "quiescevm"
   > 
   > 1. For a stopped VM - "Take Instance volume Snapshot"
   > 2. For a volume - "Take Snapshot"
   > 3. For a running VM - "Take Instance Snapshot"
   > 
   > For 1 and 2, as @sureshanaparti said it is controlled by "quiescevm" param in the volume response. I see that it has made it consistent with this PR. Though there is another bug like @Rubueno mentioned, the value of "quiescevm" is not honored in the API.
   > 
   > For 3, "Take Instance Snapshot" "quiescevm" is there by default. May be we can check for which hypervisors it is supported and keep only for those.
   
   @harikrishna-patnala thanks for testing, I've verified "quiescevm" for all the 3 forms, it is honored as set in the UI. Changes done for "quiescevm" in "Take Instance Snapshot" form to show for VMware, KVM hypervisors only - it is used for VMware, the support of it depends on the underlying storage for KVM, ignored/unused for XenServer.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2818707399

   @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2818706736

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "Rubueno (via GitHub)" <gi...@apache.org>.
Rubueno commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2818801664

   > > I've done some review/testing and discussed with Suresh, following are the findings.
   > > There are 3 forms where we are using "quiescevm"
   > > 
   > > 1. For a stopped VM - "Take Instance volume Snapshot"
   > > 2. For a volume - "Take Snapshot"
   > > 3. For a running VM - "Take Instance Snapshot"
   > > 
   > > For 1 and 2, as @sureshanaparti said it is controlled by "quiescevm" param in the volume response. I see that it has made it consistent with this PR. Though there is another bug like @Rubueno mentioned, the value of "quiescevm" is not honored in the API.
   > > For 3, "Take Instance Snapshot" "quiescevm" is there by default. May be we can check for which hypervisors it is supported and keep only for those.
   > 
   > @harikrishna-patnala thanks for testing, I've verified "quiescevm" for all the 3 forms, it is honored as set in the UI. Changes done for "quiescevm" in "Take Instance Snapshot" form to show for VMware, KVM hypervisors only - it is used for VMware, the support of it depends on the underlying storage for KVM, ignored/unused for XenServer.
   
   Thank you both for your efforts. I'm traveling right now and unable to test myself.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#discussion_r2055651682


##########
engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/vmsnapshot/StorageVMSnapshotStrategy.java:
##########
@@ -449,14 +454,14 @@ protected SnapshotInfo createDiskSnapshot(VMSnapshot vmSnapshot, List<SnapshotIn
         return snapshotInfo;
     }
 
-    protected CreateSnapshotPayload setPayload(VolumeInfo vol, SnapshotVO snapshotCreate) {
+    protected CreateSnapshotPayload setPayload(VolumeInfo vol, SnapshotVO snapshotCreate, boolean quiescevm) {
         CreateSnapshotPayload payload = new CreateSnapshotPayload();
         payload.setSnapshotId(snapshotCreate.getId());
         payload.setSnapshotPolicyId(SnapshotVO.MANUAL_POLICY_ID);
         payload.setLocationType(snapshotCreate.getLocationType());
         payload.setAccount(accountService.getAccount(vol.getAccountId()));
         payload.setAsyncBackup(false);
-        payload.setQuiescevm(false);
+        payload.setQuiescevm(quiescevm);

Review Comment:
   It is passed with the payload in the snapshotInfo, the underlying storage (if supports) would make use of it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2821250494

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2820674936

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "rosi-shapeblue (via GitHub)" <gi...@apache.org>.
rosi-shapeblue commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2769006185

   @blueorangutan test keepEnv


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2623764053

   > > > > Thanks! I've just tested the change but it does not seem the quiesce option is present in the "Take Instance volume Snapshot" window. I've tested with local, RBD and NFS on KVM.
   > > > 
   > > > 
   > > > You are right, I only see it on the take instance snapshot dialog. Can you comment @sureshanaparti ?
   > > 
   > > 
   > > quiesce option will not available in both VM -> "Take Instance volume Snapshot" & Volume -> "Take Snapshot" dialogs, when the volume response returns quiescevm as false.
   > 
   > But in this case it is present in Volume -> "Take Snapshot" and VM -> "Take Instance Snapshot" dialogs
   
   Both these dialogs are in sync with the quiescevm param in the volume response, shows it when quiescevm param is true.
   
   Even when it is set, it fails here: https://github.com/apache/cloudstack/blob/4.19/engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/DefaultSnapshotStrategy.java#L496-L498


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2630312369

   @Rubueno are you fine with these changes (both dialogs are in sync with respect to the volume response).
   
   ui/src/views/compute/CreateSnapshotWizard.vue (VM -> "Take Instance volume Snapshot" dialog)
   
   ```
           <a-form-item name="quiescevm" ref="quiescevm" v-if="isQuiesceVm">
             <template #label>
               <tooltip-label :title="$t('label.quiescevm')" :tooltip="apiParams.quiescevm.description"/>
             </template>
             <a-switch v-model:checked="form.quiescevm"/>
           </a-form-item>
           <a-form-item name="asyncbackup" ref="asyncbackup" v-if="!supportsStorageSnapshot">
             <template #label>
               <tooltip-label :title="$t('label.asyncbackup')" :tooltip="apiParams.asyncbackup.description"/>
             </template>
             <a-switch v-model:checked="form.asyncbackup"/>
           </a-form-item>
   ```
   
   ui/src/views/storage/TakeSnapshot.vue (Volume -> "Take Snapshot" dialog)
   
   ```
           <a-form-item :label="$t('label.asyncbackup')" name="asyncbackup" ref="asyncbackup" v-if="!supportsStorageSnapshot">
             <a-switch v-model:checked="form.asyncbackup" />
           </a-form-item>
           <a-form-item :label="$t('label.quiescevm')" name="quiescevm" ref="quiescevm" v-if="quiescevm">
             <a-switch v-model:checked="form.quiescevm" />
           </a-form-item>
   ```
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "Rubueno (via GitHub)" <gi...@apache.org>.
Rubueno commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2630317253

   @sureshanaparti In our env I cannot proceed with testing this, and thus does not resolve issue #10106, as both dialog boxes give different output at the moment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "Rubueno (via GitHub)" <gi...@apache.org>.
Rubueno commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2630531378

   Yes I had built new packages based on 4.19


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10265:
URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2612248222

   @sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org