You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by bachp <gi...@git.apache.org> on 2014/12/12 17:18:21 UTC
[GitHub] thrift pull request: Thrift 2850
GitHub user bachp opened a pull request:
https://github.com/apache/thrift/pull/318
Thrift 2850
These two commits add CMake support for C++, C and Java.
They also add a CMake job to travis
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/siemens/thrift THRIFT-2850
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/318.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #318
----
commit dd43397a11dbc5feaa31ed4fdc235061b02e4466
Author: Pascal Bach <pa...@siemens.com>
Date: 2014-12-12T13:10:24Z
Add CMake builds to travis
commit f13e0977e1925117948c16e83ccb1ed44948865e
Author: Pascal Bach <pa...@siemens.com>
Date: 2014-12-12T14:59:17Z
CMake: Add CMake support for Thrift libraries
Currently the following libraries are supported:
- C++
- C_Glib
- Java (using Ant wrapper)
The compilers CMake file is adjusted to work with the new global CMakeLists.txt file.
Signed-off-by: Roger Meier <r....@siemens.com>
Signed-off-by: Pascal Bach <pa...@siemens.com>
Also-by: Sergei Nikulov <se...@gmail.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Thrift 2850 CMake for Apache Thrift
Posted by hcorg <gi...@git.apache.org>.
Github user hcorg commented on the pull request:
https://github.com/apache/thrift/pull/318#issuecomment-66889612
Great!
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Thrift 2850 CMake for Apache Thrift
Posted by bachp <gi...@git.apache.org>.
Github user bachp commented on the pull request:
https://github.com/apache/thrift/pull/318#issuecomment-67304692
Hi Jake
I had a look at your cmake branch. It looks good and the python and ruby integrations are nice. I added some comments to your [commit](https://github.com/jfarrell/thrift/commit/d4b1cd78ef0f789a671124e0a9c4c30254806ced#diff-15)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Thrift 2850 CMake for Apache Thrift
Posted by bachp <gi...@git.apache.org>.
Github user bachp commented on the pull request:
https://github.com/apache/thrift/pull/318#issuecomment-67340902
@jfarrell Regarding the referencing of autoconf I think the only place we do that is to get the version number. This was just done to avoid having to change the number in yet another place.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Thrift 2850 CMake for Apache Thrift
Posted by henrique <gi...@git.apache.org>.
Github user henrique commented on the pull request:
https://github.com/apache/thrift/pull/318#issuecomment-66847789
looking great Pascal!
+1
ps.: so I guess JS would be pretty straightforward to convert too as it also uses ant
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Thrift 2850 CMake for Apache Thrift
Posted by hcorg <gi...@git.apache.org>.
Github user hcorg commented on the pull request:
https://github.com/apache/thrift/pull/318#issuecomment-66850037
check https://issues.apache.org/jira/browse/THRIFT-2850
maybe those two changes can be merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Thrift 2850 CMake for Apache Thrift
Posted by bachp <gi...@git.apache.org>.
Github user bachp closed the pull request at:
https://github.com/apache/thrift/pull/318
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Thrift 2850 CMake for Apache Thrift
Posted by bachp <gi...@git.apache.org>.
Github user bachp commented on the pull request:
https://github.com/apache/thrift/pull/318#issuecomment-143357590
I think theis is obsolete now. I will close it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Thrift 2850 CMake for Apache Thrift
Posted by jfarrell <gi...@git.apache.org>.
Github user jfarrell commented on the pull request:
https://github.com/apache/thrift/pull/318#issuecomment-67069087
I started similar work at [1] with a slightly different approach. I dont think that we should reference any autoconf from within cmake or try and work around it, but rather treat it as if it was not there and remove as we switch components over.
[1]: https://github.com/jfarrell/thrift/tree/cmake
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Thrift 2850 CMake for Apache Thrift
Posted by bufferoverflow <gi...@git.apache.org>.
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/318#issuecomment-66887590
@hcorg this is https://issues.apache.org/jira/browse/THRIFT-2850
Pascal Bach, Sergei Nikulov and I worked on this together.
I suggest to merge this and improve CMake support step by step.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Thrift 2850 CMake for Apache Thrift
Posted by henrique <gi...@git.apache.org>.
Github user henrique commented on the pull request:
https://github.com/apache/thrift/pull/318#issuecomment-67094076
Great Jake, it looks like it shouldn't be hard to integrate your rb and py cmakelists onto this.
I think theses guys are using very good common practices for cmake, from what I have seen in the projects I've worked in the last years.
ps.: Hopefully everyone agrees that cmake shouldn't touch the autoconf stuff. It's looking like we are not that far from getting rid of it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---