You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "DomGarguilo (via GitHub)" <gi...@apache.org> on 2023/03/23 17:36:49 UTC
[GitHub] [accumulo-examples] DomGarguilo opened a new pull request, #121: Add overloaded Common.createTableWithNamespace() with NTC
DomGarguilo opened a new pull request, #121:
URL: https://github.com/apache/accumulo-examples/pull/121
This PR adds an overloaded version of Common.createTableWithNamespace() that accept a `NewTableConfiguration` object as a parameter. I've also tried to make use of this new method where it seems useful to do so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-examples] DomGarguilo merged pull request #121: Add overloaded Common.createTableWithNamespace() with NTC
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo merged PR #121:
URL: https://github.com/apache/accumulo-examples/pull/121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-examples] DomGarguilo commented on pull request #121: Add overloaded Common.createTableWithNamespace() with NTC
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on PR #121:
URL: https://github.com/apache/accumulo-examples/pull/121#issuecomment-1482928594
> Looks good. The only thing I'd change is rename `ntc` to `newTableConfig`. The examples are supposed to be instructive, and that change may make it more clear what the variable is when it's used. However, it's fine as is, if that change would make the readability worse with line breaks/formatting.
Good idea. Updated in 5d915bb and I think readability has improved with this suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org