You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/12/01 02:00:40 UTC

[GitHub] [servicecomb-service-center] GuoYL123 commented on a change in pull request #770: static check and clear in the syncer folder

GuoYL123 commented on a change in pull request #770:
URL: https://github.com/apache/servicecomb-service-center/pull/770#discussion_r533023216



##########
File path: .github/workflows/golangci-lint.yml
##########
@@ -10,4 +10,4 @@ jobs:
         uses: golangci/golangci-lint-action@v2
         with:
           version: v1.29
-          args: --timeout=5m --skip-dirs='test,pkg/registry,.*/controller/(v3|v4)$,.*/bootstrap$,server/broker/brokerpb,examples,syncer,frontend,scctl,integration' --out-format=colored-line-number --enable golint,gocyclo,goimports --skip-files=.*_test.go$
\ No newline at end of file
+          args: --timeout=5m --skip-dirs='test,pkg/registry,.*/controller/(v3|v4)$,.*/bootstrap$,server/broker/brokerpb,examples,frontend,scctl,integration' --out-format=colored-line-number --enable golint,gocyclo,goimports --skip-files=.*_test.go$

Review comment:
       这个单独PR分开提交吧，估计会改大量的代码，不好追踪




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org