[GitHub] [activemq-artemis] Akvel edited a comment on pull request #3780: ARTEMIS-3488 add system property for setting key in DefaultSensitiveStringCodec

[GitBox <gi...@apache.org>]

Akvel edited a comment on pull request #3780:
URL: https://github.com/apache/activemq-artemis/pull/3780#issuecomment-931457986


   @jbe
   
   > @Akvel, the parameter is already in the `artemis` script which is called by `docker-run.sh`. I don't see how adding it to `docker-run.sh` would be helpful.
   > 
   > Are you suggesting that a place to set the _value_ of `ARTEMIS_DEFAULT_SENSITIVE_STRING_CODEC_KEY` should be added to `docker-run.sh`? If so, I would push back on that since one of the goals with adding this environment property in the first place is so that the value of the key _doesn't_ appear in any file (script or otherwise). Whoever calls `docker-run.sh` can set `ARTEMIS_DEFAULT_SENSITIVE_STRING_CODEC_KEY` in their environment.
   
   You are rigth. I missed that artemis alredy get this param from env. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org