You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/16 20:22:54 UTC

[GitHub] [arrow] BatmanAoD commented on a change in pull request #8206: ARROW-10002: [Rust] Remove `default fn` from `PrimitiveArrayOps`

BatmanAoD commented on a change in pull request #8206:
URL: https://github.com/apache/arrow/pull/8206#discussion_r489732058



##########
File path: rust/arrow/src/datatypes.rs
##########
@@ -208,12 +210,22 @@ pub trait ArrowPrimitiveType: 'static {
     fn get_data_type() -> DataType;
 
     /// Returns the bit width of this primitive type.
-    fn get_bit_width() -> usize;
+    fn get_bit_width() -> usize {
+        size_of::<Self::Native>()

Review comment:
       ```suggestion
           size_of::<Self::Native>() * 8
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org