You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "zuston (via GitHub)" <gi...@apache.org> on 2024/01/26 07:48:06 UTC

[PR] [#1407] feat(rust): support multiple spill policies and simplify hdfs config [incubator-uniffle]

zuston opened a new pull request, #1487:
URL: https://github.com/apache/incubator-uniffle/pull/1487

   ### What changes were proposed in this pull request?
   
   1. fix(rust): fast fail of writing to localfile when disk is unhealthy
   2. fix(rust): incorrect failed buffer required cnt metrics
   3. feat(rust): support fallback to hdfs when local store is invalid
   4. btw: support huge partition flushing to hdfs directly
   5. feat(rust): avoid setting hdfs config in server client
   
   ### Why are the changes needed?
   
   For #1407, hope bringing up this into production env.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Unit tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1407] feat(rust): support multiple spill policies and simplify hdfs config [incubator-uniffle]

Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston merged PR #1487:
URL: https://github.com/apache/incubator-uniffle/pull/1487


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1407] feat(rust): support multiple spill policies and simplify hdfs config [incubator-uniffle]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1487:
URL: https://github.com/apache/incubator-uniffle/pull/1487#issuecomment-1911630722

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1487?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Comparison is base [(`ba25785`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/ba25785324f3b19a5780eb1ff9d696717420e2b3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 54.24% compared to head [(`b2623a0`)](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1487?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 55.24%.
   
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1487      +/-   ##
   ============================================
   + Coverage     54.24%   55.24%   +0.99%     
   - Complexity     2804     2805       +1     
   ============================================
     Files           427      407      -20     
     Lines         24347    21986    -2361     
     Branches       2075     2075              
   ============================================
   - Hits          13207    12146    -1061     
   + Misses        10310     9082    -1228     
   + Partials        830      758      -72     
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1487?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org