You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jun Rao <ju...@gmail.com> on 2015/01/16 20:49:45 UTC
Review Request 29977: Patch for kafka-1870
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29977/
-----------------------------------------------------------
Review request for kafka.
Bugs: kafka-1870
https://issues.apache.org/jira/browse/kafka-1870
Repository: kafka
Description
-------
make javaapi.SimpleConsumer.offsetCommits() only commit to ZK
Diffs
-----
core/src/main/scala/kafka/consumer/SimpleConsumer.scala e53ee51638b930d8592ce9994ae2a617e7ef771c
core/src/main/scala/kafka/javaapi/OffsetCommitRequest.scala 27fc1eb9d578e31758bb8316a1e541c903b29361
core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff
Diff: https://reviews.apache.org/r/29977/diff/
Testing
-------
Thanks,
Jun Rao
Re: Review Request 29977: Patch for kafka-1870
Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29977/#review68466
-----------------------------------------------------------
Ship it!
Ship It!
- Joel Koshy
On Jan. 16, 2015, 8:08 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29977/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 8:08 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: kafka-1870
> https://issues.apache.org/jira/browse/kafka-1870
>
>
> Repository: kafka
>
>
> Description
> -------
>
> making the fetcOffset() api consistent
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/consumer/SimpleConsumer.scala e53ee51638b930d8592ce9994ae2a617e7ef771c
> core/src/main/scala/kafka/javaapi/OffsetCommitRequest.scala 27fc1eb9d578e31758bb8316a1e541c903b29361
> core/src/main/scala/kafka/javaapi/OffsetFetchRequest.scala 5b4f4bbcdd606da4521e5d2c9cd7bc2ba674a04a
> core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff
>
> Diff: https://reviews.apache.org/r/29977/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 29977: Patch for kafka-1870
Posted by Sriharsha Chintalapani <ha...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29977/#review68498
-----------------------------------------------------------
Ship it!
Ship It!
- Sriharsha Chintalapani
On Jan. 16, 2015, 8:08 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29977/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 8:08 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: kafka-1870
> https://issues.apache.org/jira/browse/kafka-1870
>
>
> Repository: kafka
>
>
> Description
> -------
>
> making the fetcOffset() api consistent
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/consumer/SimpleConsumer.scala e53ee51638b930d8592ce9994ae2a617e7ef771c
> core/src/main/scala/kafka/javaapi/OffsetCommitRequest.scala 27fc1eb9d578e31758bb8316a1e541c903b29361
> core/src/main/scala/kafka/javaapi/OffsetFetchRequest.scala 5b4f4bbcdd606da4521e5d2c9cd7bc2ba674a04a
> core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff
>
> Diff: https://reviews.apache.org/r/29977/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 29977: Patch for kafka-1870
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29977/
-----------------------------------------------------------
(Updated Jan. 16, 2015, 8:08 p.m.)
Review request for kafka.
Bugs: kafka-1870
https://issues.apache.org/jira/browse/kafka-1870
Repository: kafka
Description (updated)
-------
making the fetcOffset() api consistent
Diffs (updated)
-----
core/src/main/scala/kafka/consumer/SimpleConsumer.scala e53ee51638b930d8592ce9994ae2a617e7ef771c
core/src/main/scala/kafka/javaapi/OffsetCommitRequest.scala 27fc1eb9d578e31758bb8316a1e541c903b29361
core/src/main/scala/kafka/javaapi/OffsetFetchRequest.scala 5b4f4bbcdd606da4521e5d2c9cd7bc2ba674a04a
core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff
Diff: https://reviews.apache.org/r/29977/diff/
Testing
-------
Thanks,
Jun Rao
Re: Review Request 29977: Patch for kafka-1870
Posted by Jun Rao <ju...@gmail.com>.
> On Jan. 16, 2015, 7:53 p.m., Sriharsha Chintalapani wrote:
> > core/src/main/scala/kafka/javaapi/OffsetCommitRequest.scala, line 22
> > <https://reviews.apache.org/r/29977/diff/1/?file=823660#file823660line22>
> >
> > Shouldn't this provide another constructor that takes in versionId?
The problem is that in version 1, you can't just send the commit request to any broker as you can do in version 0.
- Jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29977/#review68459
-----------------------------------------------------------
On Jan. 16, 2015, 8:08 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29977/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 8:08 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: kafka-1870
> https://issues.apache.org/jira/browse/kafka-1870
>
>
> Repository: kafka
>
>
> Description
> -------
>
> making the fetcOffset() api consistent
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/consumer/SimpleConsumer.scala e53ee51638b930d8592ce9994ae2a617e7ef771c
> core/src/main/scala/kafka/javaapi/OffsetCommitRequest.scala 27fc1eb9d578e31758bb8316a1e541c903b29361
> core/src/main/scala/kafka/javaapi/OffsetFetchRequest.scala 5b4f4bbcdd606da4521e5d2c9cd7bc2ba674a04a
> core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff
>
> Diff: https://reviews.apache.org/r/29977/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 29977: Patch for kafka-1870
Posted by Sriharsha Chintalapani <ha...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29977/#review68459
-----------------------------------------------------------
core/src/main/scala/kafka/javaapi/OffsetCommitRequest.scala
<https://reviews.apache.org/r/29977/#comment112704>
Shouldn't this provide another constructor that takes in versionId?
- Sriharsha Chintalapani
On Jan. 16, 2015, 7:49 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29977/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 7:49 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: kafka-1870
> https://issues.apache.org/jira/browse/kafka-1870
>
>
> Repository: kafka
>
>
> Description
> -------
>
> make javaapi.SimpleConsumer.offsetCommits() only commit to ZK
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/consumer/SimpleConsumer.scala e53ee51638b930d8592ce9994ae2a617e7ef771c
> core/src/main/scala/kafka/javaapi/OffsetCommitRequest.scala 27fc1eb9d578e31758bb8316a1e541c903b29361
> core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff
>
> Diff: https://reviews.apache.org/r/29977/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>