You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by fr...@apache.org on 2024/09/26 12:14:04 UTC

(logging-parent) branch main-site-pro updated: #189 separate review instructions for log4net

This is an automated email from the ASF dual-hosted git repository.

freeandnil pushed a commit to branch main-site-pro
in repository https://gitbox.apache.org/repos/asf/logging-parent.git


The following commit(s) were added to refs/heads/main-site-pro by this push:
     new 3355d35  #189 separate review instructions for log4net
3355d35 is described below

commit 3355d3530f02abd41d3ccd1ff8a8fb68d12d1c68
Author: Jan Friedrich <fr...@apache.org>
AuthorDate: Thu Sep 26 13:57:09 2024 +0200

    #189 separate review instructions for log4net
---
 .gitignore                                         |  2 ++
 .../ROOT/pages/release-review-instructions.adoc    | 31 +---------------------
 2 files changed, 3 insertions(+), 30 deletions(-)

diff --git a/.gitignore b/.gitignore
index 001bf50..f602e1a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -29,3 +29,5 @@ target/
 node
 node_modules
 package-lock.json
+# Visual Studio
+/.vs/*
diff --git a/src/site/antora/modules/ROOT/pages/release-review-instructions.adoc b/src/site/antora/modules/ROOT/pages/release-review-instructions.adoc
index 2d43b58..996519a 100644
--- a/src/site/antora/modules/ROOT/pages/release-review-instructions.adoc
+++ b/src/site/antora/modules/ROOT/pages/release-review-instructions.adoc
@@ -77,7 +77,7 @@ unzip -q *-src.zip -d src
 cd src
 ----
 
-. Verify the build (Java):
+. Verify the build:
 +
 [tabs]
 ====
@@ -100,35 +100,6 @@ sh mvnw verify
 If the reviewed project happen to have Docker-based tests (e.g., Log4j), you can enable these tests by activating the `docker` Maven profile using the `-Pdocker` option.
 =====
 
-. Verify the build (.Net):
-+
-[tabs]
-====
-Docker::
-+
---
-* install docker (if you haven't already)
-** https://docs.docker.com/engine/install/
-* in logging/log4net run
-** `docker build -t log4net-builder .`
-** `docker run -it log4net-builder`
-*** this will
-**** install all dependencies in the container
-**** build src/log4net.sln
-** inside the container run
-*** `dotnet test /logging-log4net/src/log4net.sln`
---
-
-Windows::
-+
-[source,bash]
-----
-winget install -e --id Mono.Mono
-winget install Microsoft.DotNet.SDK.8
-in logging/log4net run `dotnet test ./src/log4net.sln`
-----
-====
-
 [#troubleshooting]
 == Troubleshooting