You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wookie.apache.org by rg...@apache.org on 2010/02/11 15:31:14 UTC
svn commit: r908995 - /incubator/wookie/trunk/widgets/build.xml
Author: rgardler
Date: Thu Feb 11 14:31:13 2010
New Revision: 908995
URL: http://svn.apache.org/viewvc?rev=908995&view=rev
Log:
Report an error if someone runs a target from the wrong directory.
Modified:
incubator/wookie/trunk/widgets/build.xml
Modified: incubator/wookie/trunk/widgets/build.xml
URL: http://svn.apache.org/viewvc/incubator/wookie/trunk/widgets/build.xml?rev=908995&r1=908994&r2=908995&view=diff
==============================================================================
--- incubator/wookie/trunk/widgets/build.xml (original)
+++ incubator/wookie/trunk/widgets/build.xml Thu Feb 11 14:31:13 2010
@@ -23,16 +23,17 @@
<target name="_get-widget-name" unless="widget.shortname">
<input message="What is the short name of the widget you wish to work with?"
addproperty="widget.shortname"/>
+ <fail unless="widget.shortname" message="Property widget.shortname has not been set"/>
</target>
- <target name="_validate" depends="_get-widget-name">
- <fail unless="widget.shortname" message="Property widget.shortname has not been set"/>
+ <target name="_validate">
+ <fail unless="widget.deploy.directory" message="Please run your ant targets from within the root directory of Wookie to ensure your environment is correctly set up."/>
</target>
<target name="_clean">
</target>
- <target name="_init" depends="_validate, _clean">
+ <target name="_init" depends="_validate, _get-widget-name, _clean">
<delete file="${widget.build.dir}/${widget_name}" failonerror="false"/>
<mkdir dir="${widget.build.dir}"/>
</target>
Re: svn commit: r908995 - /incubator/wookie/trunk/widgets/build.xml
Posted by Scott Wilson <sc...@gmail.com>.
Yes - the problem goes away if you comment out line 30 of /widgets/
build.xml
On 14 Feb 2010, at 22:05, Anton Zolotarjov wrote:
> This seems to be related to the problem.
> I get this output when I run "ant deploy-webapp" in the trunk
> directory:
>
> _validate:
>
> BUILD FAILED
> <..>/trunk/ant/ivy-webapp-common.xml:45: The following error occurred
> while executing this line:
> <..>/trunk/build.xml:45: The following error occurred while executing
> this line:
> <..>/trunk/widgets/build.xml:30: Please run your ant targets from
> within
> the root directory of Wookie to ensure your environment is correctly
> set
> up.
>
>
> On Sat, 2010-02-13 at 11:04 +0000, Scott Wilson wrote:
>> Ross,
>>
>> This also causes "ant run" to fail when running from within Eclipse's
>> ant console - the validate step fails.
>>
>> S
>>
>> On 11 Feb 2010, at 14:31, rgardler@apache.org wrote:
>>
>>> Author: rgardler
>>> Date: Thu Feb 11 14:31:13 2010
>>> New Revision: 908995
>>>
>>> URL: http://svn.apache.org/viewvc?rev=908995&view=rev
>>> Log:
>>> Report an error if someone runs a target from the wrong directory.
>>>
>>> Modified:
>>> incubator/wookie/trunk/widgets/build.xml
>>>
>>> Modified: incubator/wookie/trunk/widgets/build.xml
>>> URL: http://svn.apache.org/viewvc/incubator/wookie/trunk/widgets/build.xml?rev=908995&r1=908994&r2=908995&view=diff
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> ====================================================================
>>> --- incubator/wookie/trunk/widgets/build.xml (original)
>>> +++ incubator/wookie/trunk/widgets/build.xml Thu Feb 11 14:31:13
>>> 2010
>>> @@ -23,16 +23,17 @@
>>> <target name="_get-widget-name" unless="widget.shortname">
>>> <input message="What is the short name of the widget you wish to
>>> work with?"
>>> addproperty="widget.shortname"/>
>>> + <fail unless="widget.shortname" message="Property
>>> widget.shortname has not been set"/>
>>> </target>
>>>
>>> - <target name="_validate" depends="_get-widget-name">
>>> - <fail unless="widget.shortname" message="Property
>>> widget.shortname has not been set"/>
>>> + <target name="_validate">
>>> + <fail unless="widget.deploy.directory" message="Please run your
>>> ant targets from within the root directory of Wookie to ensure your
>>> environment is correctly set up."/>
>>> </target>
>>>
>>> <target name="_clean">
>>> </target>
>>>
>>> - <target name="_init" depends="_validate, _clean">
>>> + <target name="_init" depends="_validate, _get-widget-name,
>>> _clean">
>>> <delete file="${widget.build.dir}/${widget_name}"
>>> failonerror="false"/>
>>> <mkdir dir="${widget.build.dir}"/>
>>> </target>
>>>
>>>
>>
>
>
Re: svn commit: r908995 - /incubator/wookie/trunk/widgets/build.xml
Posted by Anton Zolotarjov <t0...@tlu.ee>.
This seems to be related to the problem.
I get this output when I run "ant deploy-webapp" in the trunk directory:
_validate:
BUILD FAILED
<..>/trunk/ant/ivy-webapp-common.xml:45: The following error occurred
while executing this line:
<..>/trunk/build.xml:45: The following error occurred while executing
this line:
<..>/trunk/widgets/build.xml:30: Please run your ant targets from within
the root directory of Wookie to ensure your environment is correctly set
up.
On Sat, 2010-02-13 at 11:04 +0000, Scott Wilson wrote:
> Ross,
>
> This also causes "ant run" to fail when running from within Eclipse's
> ant console - the validate step fails.
>
> S
>
> On 11 Feb 2010, at 14:31, rgardler@apache.org wrote:
>
> > Author: rgardler
> > Date: Thu Feb 11 14:31:13 2010
> > New Revision: 908995
> >
> > URL: http://svn.apache.org/viewvc?rev=908995&view=rev
> > Log:
> > Report an error if someone runs a target from the wrong directory.
> >
> > Modified:
> > incubator/wookie/trunk/widgets/build.xml
> >
> > Modified: incubator/wookie/trunk/widgets/build.xml
> > URL: http://svn.apache.org/viewvc/incubator/wookie/trunk/widgets/build.xml?rev=908995&r1=908994&r2=908995&view=diff
> > =
> > =
> > =
> > =
> > =
> > =
> > =
> > =
> > ======================================================================
> > --- incubator/wookie/trunk/widgets/build.xml (original)
> > +++ incubator/wookie/trunk/widgets/build.xml Thu Feb 11 14:31:13 2010
> > @@ -23,16 +23,17 @@
> > <target name="_get-widget-name" unless="widget.shortname">
> > <input message="What is the short name of the widget you wish to
> > work with?"
> > addproperty="widget.shortname"/>
> > + <fail unless="widget.shortname" message="Property
> > widget.shortname has not been set"/>
> > </target>
> >
> > - <target name="_validate" depends="_get-widget-name">
> > - <fail unless="widget.shortname" message="Property
> > widget.shortname has not been set"/>
> > + <target name="_validate">
> > + <fail unless="widget.deploy.directory" message="Please run your
> > ant targets from within the root directory of Wookie to ensure your
> > environment is correctly set up."/>
> > </target>
> >
> > <target name="_clean">
> > </target>
> >
> > - <target name="_init" depends="_validate, _clean">
> > + <target name="_init" depends="_validate, _get-widget-name,
> > _clean">
> > <delete file="${widget.build.dir}/${widget_name}"
> > failonerror="false"/>
> > <mkdir dir="${widget.build.dir}"/>
> > </target>
> >
> >
>
Re: svn commit: r908995 - /incubator/wookie/trunk/widgets/build.xml
Posted by Scott Wilson <sc...@gmail.com>.
Ross,
This also causes "ant run" to fail when running from within Eclipse's
ant console - the validate step fails.
S
On 11 Feb 2010, at 14:31, rgardler@apache.org wrote:
> Author: rgardler
> Date: Thu Feb 11 14:31:13 2010
> New Revision: 908995
>
> URL: http://svn.apache.org/viewvc?rev=908995&view=rev
> Log:
> Report an error if someone runs a target from the wrong directory.
>
> Modified:
> incubator/wookie/trunk/widgets/build.xml
>
> Modified: incubator/wookie/trunk/widgets/build.xml
> URL: http://svn.apache.org/viewvc/incubator/wookie/trunk/widgets/build.xml?rev=908995&r1=908994&r2=908995&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- incubator/wookie/trunk/widgets/build.xml (original)
> +++ incubator/wookie/trunk/widgets/build.xml Thu Feb 11 14:31:13 2010
> @@ -23,16 +23,17 @@
> <target name="_get-widget-name" unless="widget.shortname">
> <input message="What is the short name of the widget you wish to
> work with?"
> addproperty="widget.shortname"/>
> + <fail unless="widget.shortname" message="Property
> widget.shortname has not been set"/>
> </target>
>
> - <target name="_validate" depends="_get-widget-name">
> - <fail unless="widget.shortname" message="Property
> widget.shortname has not been set"/>
> + <target name="_validate">
> + <fail unless="widget.deploy.directory" message="Please run your
> ant targets from within the root directory of Wookie to ensure your
> environment is correctly set up."/>
> </target>
>
> <target name="_clean">
> </target>
>
> - <target name="_init" depends="_validate, _clean">
> + <target name="_init" depends="_validate, _get-widget-name,
> _clean">
> <delete file="${widget.build.dir}/${widget_name}"
> failonerror="false"/>
> <mkdir dir="${widget.build.dir}"/>
> </target>
>
>