Re: [openzipkin/brave] Add Api configuration demo for dubbo (#632)

[jun liu <ke...@gmail.com>]

Check concepts of Consumer and Provider in dubbo:

 http://dubbo.io/books/dubbo-user-book-en/references/xml/dubbo-consumer.html <http://dubbo.io/books/dubbo-user-book-en/references/xml/dubbo-consumer.html>
 http://dubbo.io/books/dubbo-user-book-en/references/xml/dubbo-provider.html <http://dubbo.io/books/dubbo-user-book-en/references/xml/dubbo-provider.html>

 XML looks like this:

<!-- default timeout and filter for all services -->
<dubbo:consumer timeout="5000" filter="tracing" />
And annotation or spring boot, use .properties instead, for example:

dubbo.consumer.filter="tracing"

Is this what you want? Adrian

Best regards,
Jun Liu


> On 6 Mar 2018, at 3:58 PM, Adrian Cole <no...@github.com> wrote:
> 
> @chickenlj <https://github.com/chickenlj> @mercyblitz <https://github.com/mercyblitz> so I still have one question, which is how to externally register a filter so that all providers and consumers use it (as opposed to setting it on an annotation). We will need this for sleuth as we don't want users to have to change their annotations to switch on tracing
> 
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub <https://github.com/openzipkin/brave/issues/632#issuecomment-370695232>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ARQliQy8Fx6W2c1t1vy_eerUof8K3-gMks5tbkG0gaJpZM4Sa2cy>.
> 

Re: [openzipkin/brave] Add Api configuration demo for dubbo (#632)

[Adrian Cole <ad...@gmail.com>]

following-up here https://github.com/alibaba/dubbo-spring-boot-starter/issues/53

Re: [openzipkin/brave] Add Api configuration demo for dubbo (#632)

[Adrian Cole <ad...@gmail.com>]

> And annotation or spring boot, use .properties instead, for example:
>
> dubbo.consumer.filter="tracing"
>
> Is this what you want? Adrian

Cool, except that in sleuth we would be doing this by default, so need
to do the same as dubbo.consumer.filter="tracing" in
auto-configuration code.
This is a good hint, so I can start with that.