You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/05/25 04:06:29 UTC

[GitHub] [iotdb] SzyWilliam commented on a diff in pull request #5991: [IOTDB-3253] Upgrade dependency: Ratis from 2.2.0 to 2.3.0

SzyWilliam commented on code in PR #5991:
URL: https://github.com/apache/iotdb/pull/5991#discussion_r881197665


##########
consensus/src/main/java/org/apache/iotdb/consensus/ratis/ApplicationStateMachineProxy.java:
##########
@@ -142,13 +144,22 @@ public long takeSnapshot() throws IOException {
     // require the application statemachine to take the latest snapshot
     String metadata = Utils.getMetadataFromTermIndex(lastApplied);
     File snapshotDir = snapshotStorage.getSnapshotDir(metadata);
+
+    // delete snapshotDir fully in case of last failed take snapshot

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org