You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/23 05:32:24 UTC

[GitHub] [kafka] guozhangwang commented on pull request #11089: MINOR: remove unnecessary judgment in AdminUtils::assignReplicasToBrokersRackAware

guozhangwang commented on pull request #11089:
URL: https://github.com/apache/kafka/pull/11089#issuecomment-885410437


   Overall looks good to me. Just one qq: do we always guarantee `replicationFactor <= numBrokers`? I know we check and forbid it when creating a new topic, but after a topic is created, if we shutdown brokers and reassign replicas, would we stop with less replicas and warn users?
   
   cc @ijuma for another look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org