You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/17 10:54:18 UTC

[GitHub] [pulsar-manager] sourabhaggrawal commented on a change in pull request #434: SAML Integration for Login

sourabhaggrawal commented on a change in pull request #434:
URL: https://github.com/apache/pulsar-manager/pull/434#discussion_r771301885



##########
File path: src/main/java/org/apache/pulsar/manager/interceptor/WebAppConfigurer.java
##########
@@ -51,6 +51,7 @@ public void addInterceptors(InterceptorRegistry registry) {
                 .excludePathPatterns("/doc.html")
                 // BKVM
                 .excludePathPatterns("/bkvm")
+                .excludePathPatterns("/pulsar-manager/saml/**")

Review comment:
       our endpoint is /saml/sso @shiv4289 
   here /saml is mapped at controller level and **  to exclude all method in that controller from authentication. 
   This makes me rethink to change the excludePathPatterns as /pulsar-manager/saml/sso to make only one method accessible without authentication. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org