You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/03/23 08:24:43 UTC
[GitHub] [ozone] sadanand48 opened a new pull request #2071: HDDS-5018.[FSO] Add robot tests for new Filesystem layout
sadanand48 opened a new pull request #2071:
URL: https://github.com/apache/ozone/pull/2071
## What changes were proposed in this pull request?
Add robot test for the new FS Layout
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5018
## How was this patch tested?
Acceptance tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2071: HDDS-5018.[FSO] Add robot tests for new Filesystem layout
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2071:
URL: https://github.com/apache/ozone/pull/2071#issuecomment-804780817
1. `.env` file is missing from the new compose directory, so acceptance test is failing:
```
The OZONE_RUNNER_VERSION variable is not set. Defaulting to a blank string.
no such image: apache/ozone-runner:: invalid reference format
```
2. Can we find a way to avoid duplicating the compose environment just for testing with slightly different config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2071: HDDS-5018.[FSO] Add robot tests for new Filesystem layout
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2071:
URL: https://github.com/apache/ozone/pull/2071#issuecomment-806086365
> By not duplicating the compose environment do you mean adding this test to an existing environment (inside ozone/test.sh) or not duplicate the docker-compose.yaml file?
I don't have a definitive answer for that (that's what I meant by "find a way"). Hopefully we can achieve it in the first way, ie. without any duplication.
One idea is to define relevant configs as environment variables directly in `test.sh`, instead of the static `docker-config` file. With that, we can execute the same test suite with different configs by including `start/stop_docker_env` in the loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] mukul1987 commented on pull request #2071: HDDS-5018.[FSO] Add robot tests for new Filesystem layout
Posted by GitBox <gi...@apache.org>.
mukul1987 commented on pull request #2071:
URL: https://github.com/apache/ozone/pull/2071#issuecomment-810792250
@sadanand48 can you please rebase the patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr commented on pull request #2071: HDDS-5018.[FSO] Add robot tests for new Filesystem layout
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on pull request #2071:
URL: https://github.com/apache/ozone/pull/2071#issuecomment-814106213
Thanks @sadanand48 for the contribution.
Thanks @mukul1987 for the reviews.
+1 LGTM, will merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2071: HDDS-5018.[FSO] Add robot tests for new Filesystem layout
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2071:
URL: https://github.com/apache/ozone/pull/2071#issuecomment-806561166
> One idea is to define relevant configs as environment variables directly in `test.sh`, instead of the static `docker-config` file. With that, we can execute the same test suite with different configs by including `start/stop_docker_env` in the loop.
Here's an implementation of this:
https://github.com/adoroszlai/hadoop-ozone/commit/dd2d58637da74f524b643b7b240bf53f306905d6
And the test run:
https://github.com/adoroszlai/hadoop-ozone/runs/2192093559?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr merged pull request #2071: HDDS-5018.[FSO] Add robot tests for new Filesystem layout
Posted by GitBox <gi...@apache.org>.
rakeshadr merged pull request #2071:
URL: https://github.com/apache/ozone/pull/2071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sadanand48 commented on pull request #2071: HDDS-5018.[FSO] Add robot tests for new Filesystem layout
Posted by GitBox <gi...@apache.org>.
sadanand48 commented on pull request #2071:
URL: https://github.com/apache/ozone/pull/2071#issuecomment-806571783
> Here's an implementation of this:
> [adoroszlai@dd2d586](https://github.com/adoroszlai/hadoop-ozone/commit/dd2d58637da74f524b643b7b240bf53f306905d6)
>
> And the test run:
> https://github.com/adoroszlai/hadoop-ozone/runs/2192093559?check_suite_focus=true
Thanks a lot @adoroszlai for demonstrating this. I have tried something similar . Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr edited a comment on pull request #2071: HDDS-5018.[FSO] Add robot tests for new Filesystem layout
Posted by GitBox <gi...@apache.org>.
rakeshadr edited a comment on pull request #2071:
URL: https://github.com/apache/ozone/pull/2071#issuecomment-814106213
Thanks @sadanand48 for the contribution.
Thanks @adoroszlai , @mukul1987 for the reviews.
+1 LGTM, will merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sadanand48 commented on pull request #2071: HDDS-5018.[FSO] Add robot tests for new Filesystem layout
Posted by GitBox <gi...@apache.org>.
sadanand48 commented on pull request #2071:
URL: https://github.com/apache/ozone/pull/2071#issuecomment-805929172
Thanks @adoroszlai for the comment.
By not duplicating the compose environment do you mean adding this test to an existing environment (inside ozone/test.sh) or not duplicate the docker-compose.yaml file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org