You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Suraj Khurana <su...@hotwax.co> on 2020/05/23 15:29:43 UTC
LineLength for checkstyle
Hello Devs,
Recently we are facing some checkstyle issues and one cause of it is
LineLength property.
Currently we have set it to 120, I think we should make it to 150 instead.
It is pretty visible in 13/14 font sizes as well.
Please share your thoughts on this.
--
Best Regards,
Suraj Khurana
Senior Technical Consultant
Re: LineLength for checkstyle
Posted by Suraj Khurana <su...@hotwax.co>.
Thanks Jacques.
Using this I think we would also be able to configure like, hey don't check
for services java files, they don't have default constructors ;)
--
Best Regards,
Suraj Khurana
SENIOR TECHNICAL CONSULTANT
mobile: +91 9669750002
email: suraj.khurana@hotwax.co
*www.hotwax.co <http://www.hotwax.co/>*
On Tue, May 26, 2020 at 10:57 PM Jacques Le Roux <
jacques.le.roux@les7arts.com> wrote:
> Hi All,
>
> I agree with Daniel and Suraj. Do we would set a rule to 2000 to not let
> the same default (2000).
>
> We should also decide for the exceptions, wrote (eg following[1] and [2])
> and note them in OFBIZ-11740.
>
> Pierre, see OFBIZ-11740
>
> [1]
> https://stackoverflow.com/questions/48000117/how-to-add-exceptions-in-a-checkstyle-config
> [2] https://checkstyle.sourceforge.io/config_filters.html
>
> Jacques
>
> Le 26/05/2020 à 08:11, Suraj Khurana a écrit :
> > +1 for setting rule. Also we can think of some configured values instead
> of
> > 2000 (default). may be we should set it to 3000 instead.
> >
> > And then as Daniel mentioned, work on refactoring those offending source
> > files where possible.
> >
> > --
> >
> > Best Regards,
> > Suraj Khurana
> > Senior Technical Consultant
> >
> >
> > On Mon, May 25, 2020 at 8:49 PM Carsten Schinzer <
> > carsten@dcs-verkaufssysteme.de> wrote:
> >
> >> +1 for setting the max lines rule
> >>
> >>> Am 25.05.2020 um 17:05 schrieb Daniel Watford <da...@foomoo.co.uk>:
> >>>
> >>> Hi Jacques,
> >>>
> >>> I would vote for setting an explicit rule to have the max line length
> set
> >>> at 2000 lines and then work on refactoring those offending source files
> >>> where possible.
> >>>
> >>> If we find some files cannot be split up then I think we can add
> >> exceptions
> >>> to prevent the max line length rule from being applied to them. But
> that
> >>> should be done on a file by file basis.
> >>>
> >>> I still have OFBIZ-11456 on my todo list to refactor MacroFormRenderer.
> >>> Work has been progressing slowly but development has slowed during the
> >>> pandemic. I hope to get back on top of this soon.
> >>>
> >>> Thanks,
> >>>
> >>> Dan.
> >>>
> >>> On Mon, 25 May 2020 at 15:43, Jacques Le Roux <
> >> jacques.le.roux@les7arts.com>
> >>> wrote:
> >>>
> >>>> Hi All,
> >>>>
> >>>> Suraj rightly mentioned that we have no FileLength checkstyle rule and
> >> the
> >>>> max default is 2000 lines:
> >>>> https://checkstyle.sourceforge.io/config_sizes.html#FileLength
> >>>>
> >>>> We have some very large Java files in trunk and few (19) are longer
> than
> >>>> 2000 lines.
> >>>> The question is should we increase FileLength checkstyle rule to hide
> >> the
> >>>> issue or try to split those files?
> >>>>
> >>>> I have created https://issues.apache.org/jira/browse/OFBIZ-11740 for
> >> that
> >>>> Jacques
> >>>>
> >>>> https://checkstyle.sourceforge.io/config_sizes.html#FileLength
> >>>>
> >>>> Le 25/05/2020 à 15:09, Suraj Khurana a écrit :
> >>>>> This is done in rev # d6ebef619349f809062641d1b558cacdec3da208
> >>>>>
> >>>>> --
> >>>>> Best Regards,
> >>>>> Suraj Khurana
> >>>>> Senior Technical Consultant
> >>>>>
> >>>>>
> >>>>> On Mon, May 25, 2020 at 2:16 PM Suraj Khurana <
> suraj.khurana@hotwax.co
> >>>>> wrote:
> >>>>>
> >>>>>> Thanks everyone,
> >>>>>>
> >>>>>> Here[1] is the ticket to track this improvement.
> >>>>>>
> >>>>>> [1]: https://issues.apache.org/jira/browse/OFBIZ-11737
> >>>>>>
> >>>>>> --
> >>>>>> Best Regards,
> >>>>>> Suraj Khurana
> >>>>>> Senior Technical Consultant
> >>>>>>
> >>>>>>
> >>>>>> On Sun, May 24, 2020 at 1:58 PM Olivier Heintz <
> >>>>>> holivier.lists@ofbizextra.org> wrote:
> >>>>>>
> >>>>>>> +1
> >>>>>>>
> >>>>>>> Le 23/05/2020 à 17:29, Suraj Khurana a écrit :
> >>>>>>>> Hello Devs,
> >>>>>>>>
> >>>>>>>> Recently we are facing some checkstyle issues and one cause of it
> is
> >>>>>>>> LineLength property.
> >>>>>>>> Currently we have set it to 120, I think we should make it to 150
> >>>>>>> instead.
> >>>>>>>> It is pretty visible in 13/14 font sizes as well.
> >>>>>>>>
> >>>>>>>> Please share your thoughts on this.
> >>>>>>>>
> >>>>>>>> --
> >>>>>>>> Best Regards,
> >>>>>>>> Suraj Khurana
> >>>>>>>> Senior Technical Consultant
> >>>>>>>>
> >>>
> >>> --
> >>> Daniel Watford
> >>
>
Re: LineLength for checkstyle
Posted by Jacques Le Roux <ja...@les7arts.com>.
Hi All,
I agree with Daniel and Suraj. Do we would set a rule to 2000 to not let the same default (2000).
We should also decide for the exceptions, wrote (eg following[1] and [2]) and note them in OFBIZ-11740.
Pierre, see OFBIZ-11740
[1] https://stackoverflow.com/questions/48000117/how-to-add-exceptions-in-a-checkstyle-config
[2] https://checkstyle.sourceforge.io/config_filters.html
Jacques
Le 26/05/2020 à 08:11, Suraj Khurana a écrit :
> +1 for setting rule. Also we can think of some configured values instead of
> 2000 (default). may be we should set it to 3000 instead.
>
> And then as Daniel mentioned, work on refactoring those offending source
> files where possible.
>
> --
>
> Best Regards,
> Suraj Khurana
> Senior Technical Consultant
>
>
> On Mon, May 25, 2020 at 8:49 PM Carsten Schinzer <
> carsten@dcs-verkaufssysteme.de> wrote:
>
>> +1 for setting the max lines rule
>>
>>> Am 25.05.2020 um 17:05 schrieb Daniel Watford <da...@foomoo.co.uk>:
>>>
>>> Hi Jacques,
>>>
>>> I would vote for setting an explicit rule to have the max line length set
>>> at 2000 lines and then work on refactoring those offending source files
>>> where possible.
>>>
>>> If we find some files cannot be split up then I think we can add
>> exceptions
>>> to prevent the max line length rule from being applied to them. But that
>>> should be done on a file by file basis.
>>>
>>> I still have OFBIZ-11456 on my todo list to refactor MacroFormRenderer.
>>> Work has been progressing slowly but development has slowed during the
>>> pandemic. I hope to get back on top of this soon.
>>>
>>> Thanks,
>>>
>>> Dan.
>>>
>>> On Mon, 25 May 2020 at 15:43, Jacques Le Roux <
>> jacques.le.roux@les7arts.com>
>>> wrote:
>>>
>>>> Hi All,
>>>>
>>>> Suraj rightly mentioned that we have no FileLength checkstyle rule and
>> the
>>>> max default is 2000 lines:
>>>> https://checkstyle.sourceforge.io/config_sizes.html#FileLength
>>>>
>>>> We have some very large Java files in trunk and few (19) are longer than
>>>> 2000 lines.
>>>> The question is should we increase FileLength checkstyle rule to hide
>> the
>>>> issue or try to split those files?
>>>>
>>>> I have created https://issues.apache.org/jira/browse/OFBIZ-11740 for
>> that
>>>> Jacques
>>>>
>>>> https://checkstyle.sourceforge.io/config_sizes.html#FileLength
>>>>
>>>> Le 25/05/2020 à 15:09, Suraj Khurana a écrit :
>>>>> This is done in rev # d6ebef619349f809062641d1b558cacdec3da208
>>>>>
>>>>> --
>>>>> Best Regards,
>>>>> Suraj Khurana
>>>>> Senior Technical Consultant
>>>>>
>>>>>
>>>>> On Mon, May 25, 2020 at 2:16 PM Suraj Khurana <suraj.khurana@hotwax.co
>>>>> wrote:
>>>>>
>>>>>> Thanks everyone,
>>>>>>
>>>>>> Here[1] is the ticket to track this improvement.
>>>>>>
>>>>>> [1]: https://issues.apache.org/jira/browse/OFBIZ-11737
>>>>>>
>>>>>> --
>>>>>> Best Regards,
>>>>>> Suraj Khurana
>>>>>> Senior Technical Consultant
>>>>>>
>>>>>>
>>>>>> On Sun, May 24, 2020 at 1:58 PM Olivier Heintz <
>>>>>> holivier.lists@ofbizextra.org> wrote:
>>>>>>
>>>>>>> +1
>>>>>>>
>>>>>>> Le 23/05/2020 à 17:29, Suraj Khurana a écrit :
>>>>>>>> Hello Devs,
>>>>>>>>
>>>>>>>> Recently we are facing some checkstyle issues and one cause of it is
>>>>>>>> LineLength property.
>>>>>>>> Currently we have set it to 120, I think we should make it to 150
>>>>>>> instead.
>>>>>>>> It is pretty visible in 13/14 font sizes as well.
>>>>>>>>
>>>>>>>> Please share your thoughts on this.
>>>>>>>>
>>>>>>>> --
>>>>>>>> Best Regards,
>>>>>>>> Suraj Khurana
>>>>>>>> Senior Technical Consultant
>>>>>>>>
>>>
>>> --
>>> Daniel Watford
>>
Re: LineLength for checkstyle
Posted by Pierre Smits <pi...@apache.org>.
How many files would violate that 2000-lines rule?
Met vriendelijke groet,
Pierre Smits
*Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
2008 (without privileges)
*Apache Trafodion <https://trafodion.apache.org>, Vice President*
*Apache Directory <https://directory.apache.org>, PMC Member*
Apache Incubator <https://incubator.apache.org>, committer
Apache Steve <https://steve.apache.org>, committer
On Tue, May 26, 2020 at 8:11 AM Suraj Khurana <su...@hotwax.co>
wrote:
> +1 for setting rule. Also we can think of some configured values instead of
> 2000 (default). may be we should set it to 3000 instead.
>
> And then as Daniel mentioned, work on refactoring those offending source
> files where possible.
>
> --
>
> Best Regards,
> Suraj Khurana
> Senior Technical Consultant
>
>
> On Mon, May 25, 2020 at 8:49 PM Carsten Schinzer <
> carsten@dcs-verkaufssysteme.de> wrote:
>
> > +1 for setting the max lines rule
> >
> > > Am 25.05.2020 um 17:05 schrieb Daniel Watford <da...@foomoo.co.uk>:
> > >
> > > Hi Jacques,
> > >
> > > I would vote for setting an explicit rule to have the max line length
> set
> > > at 2000 lines and then work on refactoring those offending source files
> > > where possible.
> > >
> > > If we find some files cannot be split up then I think we can add
> > exceptions
> > > to prevent the max line length rule from being applied to them. But
> that
> > > should be done on a file by file basis.
> > >
> > > I still have OFBIZ-11456 on my todo list to refactor MacroFormRenderer.
> > > Work has been progressing slowly but development has slowed during the
> > > pandemic. I hope to get back on top of this soon.
> > >
> > > Thanks,
> > >
> > > Dan.
> > >
> > > On Mon, 25 May 2020 at 15:43, Jacques Le Roux <
> > jacques.le.roux@les7arts.com>
> > > wrote:
> > >
> > >> Hi All,
> > >>
> > >> Suraj rightly mentioned that we have no FileLength checkstyle rule and
> > the
> > >> max default is 2000 lines:
> > >> https://checkstyle.sourceforge.io/config_sizes.html#FileLength
> > >>
> > >> We have some very large Java files in trunk and few (19) are longer
> than
> > >> 2000 lines.
> > >> The question is should we increase FileLength checkstyle rule to hide
> > the
> > >> issue or try to split those files?
> > >>
> > >> I have created https://issues.apache.org/jira/browse/OFBIZ-11740 for
> > that
> > >>
> > >> Jacques
> > >>
> > >> https://checkstyle.sourceforge.io/config_sizes.html#FileLength
> > >>
> > >> Le 25/05/2020 à 15:09, Suraj Khurana a écrit :
> > >>> This is done in rev # d6ebef619349f809062641d1b558cacdec3da208
> > >>>
> > >>> --
> > >>> Best Regards,
> > >>> Suraj Khurana
> > >>> Senior Technical Consultant
> > >>>
> > >>>
> > >>> On Mon, May 25, 2020 at 2:16 PM Suraj Khurana <
> suraj.khurana@hotwax.co
> > >
> > >>> wrote:
> > >>>
> > >>>> Thanks everyone,
> > >>>>
> > >>>> Here[1] is the ticket to track this improvement.
> > >>>>
> > >>>> [1]: https://issues.apache.org/jira/browse/OFBIZ-11737
> > >>>>
> > >>>> --
> > >>>> Best Regards,
> > >>>> Suraj Khurana
> > >>>> Senior Technical Consultant
> > >>>>
> > >>>>
> > >>>> On Sun, May 24, 2020 at 1:58 PM Olivier Heintz <
> > >>>> holivier.lists@ofbizextra.org> wrote:
> > >>>>
> > >>>>> +1
> > >>>>>
> > >>>>> Le 23/05/2020 à 17:29, Suraj Khurana a écrit :
> > >>>>>> Hello Devs,
> > >>>>>>
> > >>>>>> Recently we are facing some checkstyle issues and one cause of it
> is
> > >>>>>> LineLength property.
> > >>>>>> Currently we have set it to 120, I think we should make it to 150
> > >>>>> instead.
> > >>>>>> It is pretty visible in 13/14 font sizes as well.
> > >>>>>>
> > >>>>>> Please share your thoughts on this.
> > >>>>>>
> > >>>>>> --
> > >>>>>> Best Regards,
> > >>>>>> Suraj Khurana
> > >>>>>> Senior Technical Consultant
> > >>>>>>
> > >>
> > >
> > >
> > > --
> > > Daniel Watford
> >
> >
>
Re: LineLength for checkstyle
Posted by Suraj Khurana <su...@hotwax.co>.
+1 for setting rule. Also we can think of some configured values instead of
2000 (default). may be we should set it to 3000 instead.
And then as Daniel mentioned, work on refactoring those offending source
files where possible.
--
Best Regards,
Suraj Khurana
Senior Technical Consultant
On Mon, May 25, 2020 at 8:49 PM Carsten Schinzer <
carsten@dcs-verkaufssysteme.de> wrote:
> +1 for setting the max lines rule
>
> > Am 25.05.2020 um 17:05 schrieb Daniel Watford <da...@foomoo.co.uk>:
> >
> > Hi Jacques,
> >
> > I would vote for setting an explicit rule to have the max line length set
> > at 2000 lines and then work on refactoring those offending source files
> > where possible.
> >
> > If we find some files cannot be split up then I think we can add
> exceptions
> > to prevent the max line length rule from being applied to them. But that
> > should be done on a file by file basis.
> >
> > I still have OFBIZ-11456 on my todo list to refactor MacroFormRenderer.
> > Work has been progressing slowly but development has slowed during the
> > pandemic. I hope to get back on top of this soon.
> >
> > Thanks,
> >
> > Dan.
> >
> > On Mon, 25 May 2020 at 15:43, Jacques Le Roux <
> jacques.le.roux@les7arts.com>
> > wrote:
> >
> >> Hi All,
> >>
> >> Suraj rightly mentioned that we have no FileLength checkstyle rule and
> the
> >> max default is 2000 lines:
> >> https://checkstyle.sourceforge.io/config_sizes.html#FileLength
> >>
> >> We have some very large Java files in trunk and few (19) are longer than
> >> 2000 lines.
> >> The question is should we increase FileLength checkstyle rule to hide
> the
> >> issue or try to split those files?
> >>
> >> I have created https://issues.apache.org/jira/browse/OFBIZ-11740 for
> that
> >>
> >> Jacques
> >>
> >> https://checkstyle.sourceforge.io/config_sizes.html#FileLength
> >>
> >> Le 25/05/2020 à 15:09, Suraj Khurana a écrit :
> >>> This is done in rev # d6ebef619349f809062641d1b558cacdec3da208
> >>>
> >>> --
> >>> Best Regards,
> >>> Suraj Khurana
> >>> Senior Technical Consultant
> >>>
> >>>
> >>> On Mon, May 25, 2020 at 2:16 PM Suraj Khurana <suraj.khurana@hotwax.co
> >
> >>> wrote:
> >>>
> >>>> Thanks everyone,
> >>>>
> >>>> Here[1] is the ticket to track this improvement.
> >>>>
> >>>> [1]: https://issues.apache.org/jira/browse/OFBIZ-11737
> >>>>
> >>>> --
> >>>> Best Regards,
> >>>> Suraj Khurana
> >>>> Senior Technical Consultant
> >>>>
> >>>>
> >>>> On Sun, May 24, 2020 at 1:58 PM Olivier Heintz <
> >>>> holivier.lists@ofbizextra.org> wrote:
> >>>>
> >>>>> +1
> >>>>>
> >>>>> Le 23/05/2020 à 17:29, Suraj Khurana a écrit :
> >>>>>> Hello Devs,
> >>>>>>
> >>>>>> Recently we are facing some checkstyle issues and one cause of it is
> >>>>>> LineLength property.
> >>>>>> Currently we have set it to 120, I think we should make it to 150
> >>>>> instead.
> >>>>>> It is pretty visible in 13/14 font sizes as well.
> >>>>>>
> >>>>>> Please share your thoughts on this.
> >>>>>>
> >>>>>> --
> >>>>>> Best Regards,
> >>>>>> Suraj Khurana
> >>>>>> Senior Technical Consultant
> >>>>>>
> >>
> >
> >
> > --
> > Daniel Watford
>
>
Re: LineLength for checkstyle
Posted by Carsten Schinzer <ca...@dcs-verkaufssysteme.de>.
+1 for setting the max lines rule
> Am 25.05.2020 um 17:05 schrieb Daniel Watford <da...@foomoo.co.uk>:
>
> Hi Jacques,
>
> I would vote for setting an explicit rule to have the max line length set
> at 2000 lines and then work on refactoring those offending source files
> where possible.
>
> If we find some files cannot be split up then I think we can add exceptions
> to prevent the max line length rule from being applied to them. But that
> should be done on a file by file basis.
>
> I still have OFBIZ-11456 on my todo list to refactor MacroFormRenderer.
> Work has been progressing slowly but development has slowed during the
> pandemic. I hope to get back on top of this soon.
>
> Thanks,
>
> Dan.
>
> On Mon, 25 May 2020 at 15:43, Jacques Le Roux <ja...@les7arts.com>
> wrote:
>
>> Hi All,
>>
>> Suraj rightly mentioned that we have no FileLength checkstyle rule and the
>> max default is 2000 lines:
>> https://checkstyle.sourceforge.io/config_sizes.html#FileLength
>>
>> We have some very large Java files in trunk and few (19) are longer than
>> 2000 lines.
>> The question is should we increase FileLength checkstyle rule to hide the
>> issue or try to split those files?
>>
>> I have created https://issues.apache.org/jira/browse/OFBIZ-11740 for that
>>
>> Jacques
>>
>> https://checkstyle.sourceforge.io/config_sizes.html#FileLength
>>
>> Le 25/05/2020 à 15:09, Suraj Khurana a écrit :
>>> This is done in rev # d6ebef619349f809062641d1b558cacdec3da208
>>>
>>> --
>>> Best Regards,
>>> Suraj Khurana
>>> Senior Technical Consultant
>>>
>>>
>>> On Mon, May 25, 2020 at 2:16 PM Suraj Khurana <su...@hotwax.co>
>>> wrote:
>>>
>>>> Thanks everyone,
>>>>
>>>> Here[1] is the ticket to track this improvement.
>>>>
>>>> [1]: https://issues.apache.org/jira/browse/OFBIZ-11737
>>>>
>>>> --
>>>> Best Regards,
>>>> Suraj Khurana
>>>> Senior Technical Consultant
>>>>
>>>>
>>>> On Sun, May 24, 2020 at 1:58 PM Olivier Heintz <
>>>> holivier.lists@ofbizextra.org> wrote:
>>>>
>>>>> +1
>>>>>
>>>>> Le 23/05/2020 à 17:29, Suraj Khurana a écrit :
>>>>>> Hello Devs,
>>>>>>
>>>>>> Recently we are facing some checkstyle issues and one cause of it is
>>>>>> LineLength property.
>>>>>> Currently we have set it to 120, I think we should make it to 150
>>>>> instead.
>>>>>> It is pretty visible in 13/14 font sizes as well.
>>>>>>
>>>>>> Please share your thoughts on this.
>>>>>>
>>>>>> --
>>>>>> Best Regards,
>>>>>> Suraj Khurana
>>>>>> Senior Technical Consultant
>>>>>>
>>
>
>
> --
> Daniel Watford
Re: LineLength for checkstyle
Posted by Daniel Watford <da...@foomoo.co.uk>.
Hi Jacques,
I would vote for setting an explicit rule to have the max line length set
at 2000 lines and then work on refactoring those offending source files
where possible.
If we find some files cannot be split up then I think we can add exceptions
to prevent the max line length rule from being applied to them. But that
should be done on a file by file basis.
I still have OFBIZ-11456 on my todo list to refactor MacroFormRenderer.
Work has been progressing slowly but development has slowed during the
pandemic. I hope to get back on top of this soon.
Thanks,
Dan.
On Mon, 25 May 2020 at 15:43, Jacques Le Roux <ja...@les7arts.com>
wrote:
> Hi All,
>
> Suraj rightly mentioned that we have no FileLength checkstyle rule and the
> max default is 2000 lines:
> https://checkstyle.sourceforge.io/config_sizes.html#FileLength
>
> We have some very large Java files in trunk and few (19) are longer than
> 2000 lines.
> The question is should we increase FileLength checkstyle rule to hide the
> issue or try to split those files?
>
> I have created https://issues.apache.org/jira/browse/OFBIZ-11740 for that
>
> Jacques
>
> https://checkstyle.sourceforge.io/config_sizes.html#FileLength
>
> Le 25/05/2020 à 15:09, Suraj Khurana a écrit :
> > This is done in rev # d6ebef619349f809062641d1b558cacdec3da208
> >
> > --
> > Best Regards,
> > Suraj Khurana
> > Senior Technical Consultant
> >
> >
> > On Mon, May 25, 2020 at 2:16 PM Suraj Khurana <su...@hotwax.co>
> > wrote:
> >
> >> Thanks everyone,
> >>
> >> Here[1] is the ticket to track this improvement.
> >>
> >> [1]: https://issues.apache.org/jira/browse/OFBIZ-11737
> >>
> >> --
> >> Best Regards,
> >> Suraj Khurana
> >> Senior Technical Consultant
> >>
> >>
> >> On Sun, May 24, 2020 at 1:58 PM Olivier Heintz <
> >> holivier.lists@ofbizextra.org> wrote:
> >>
> >>> +1
> >>>
> >>> Le 23/05/2020 à 17:29, Suraj Khurana a écrit :
> >>>> Hello Devs,
> >>>>
> >>>> Recently we are facing some checkstyle issues and one cause of it is
> >>>> LineLength property.
> >>>> Currently we have set it to 120, I think we should make it to 150
> >>> instead.
> >>>> It is pretty visible in 13/14 font sizes as well.
> >>>>
> >>>> Please share your thoughts on this.
> >>>>
> >>>> --
> >>>> Best Regards,
> >>>> Suraj Khurana
> >>>> Senior Technical Consultant
> >>>>
>
--
Daniel Watford
Re: LineLength for checkstyle
Posted by Jacques Le Roux <ja...@les7arts.com>.
Hi All,
Suraj rightly mentioned that we have no FileLength checkstyle rule and the max default is 2000 lines:
https://checkstyle.sourceforge.io/config_sizes.html#FileLength
We have some very large Java files in trunk and few (19) are longer than 2000 lines.
The question is should we increase FileLength checkstyle rule to hide the issue or try to split those files?
I have created https://issues.apache.org/jira/browse/OFBIZ-11740 for that
Jacques
https://checkstyle.sourceforge.io/config_sizes.html#FileLength
Le 25/05/2020 à 15:09, Suraj Khurana a écrit :
> This is done in rev # d6ebef619349f809062641d1b558cacdec3da208
>
> --
> Best Regards,
> Suraj Khurana
> Senior Technical Consultant
>
>
> On Mon, May 25, 2020 at 2:16 PM Suraj Khurana <su...@hotwax.co>
> wrote:
>
>> Thanks everyone,
>>
>> Here[1] is the ticket to track this improvement.
>>
>> [1]: https://issues.apache.org/jira/browse/OFBIZ-11737
>>
>> --
>> Best Regards,
>> Suraj Khurana
>> Senior Technical Consultant
>>
>>
>> On Sun, May 24, 2020 at 1:58 PM Olivier Heintz <
>> holivier.lists@ofbizextra.org> wrote:
>>
>>> +1
>>>
>>> Le 23/05/2020 à 17:29, Suraj Khurana a écrit :
>>>> Hello Devs,
>>>>
>>>> Recently we are facing some checkstyle issues and one cause of it is
>>>> LineLength property.
>>>> Currently we have set it to 120, I think we should make it to 150
>>> instead.
>>>> It is pretty visible in 13/14 font sizes as well.
>>>>
>>>> Please share your thoughts on this.
>>>>
>>>> --
>>>> Best Regards,
>>>> Suraj Khurana
>>>> Senior Technical Consultant
>>>>
Re: LineLength for checkstyle
Posted by Suraj Khurana <su...@hotwax.co>.
This is done in rev # d6ebef619349f809062641d1b558cacdec3da208
--
Best Regards,
Suraj Khurana
Senior Technical Consultant
On Mon, May 25, 2020 at 2:16 PM Suraj Khurana <su...@hotwax.co>
wrote:
> Thanks everyone,
>
> Here[1] is the ticket to track this improvement.
>
> [1]: https://issues.apache.org/jira/browse/OFBIZ-11737
>
> --
> Best Regards,
> Suraj Khurana
> Senior Technical Consultant
>
>
> On Sun, May 24, 2020 at 1:58 PM Olivier Heintz <
> holivier.lists@ofbizextra.org> wrote:
>
>> +1
>>
>> Le 23/05/2020 à 17:29, Suraj Khurana a écrit :
>> > Hello Devs,
>> >
>> > Recently we are facing some checkstyle issues and one cause of it is
>> > LineLength property.
>> > Currently we have set it to 120, I think we should make it to 150
>> instead.
>> > It is pretty visible in 13/14 font sizes as well.
>> >
>> > Please share your thoughts on this.
>> >
>> > --
>> > Best Regards,
>> > Suraj Khurana
>> > Senior Technical Consultant
>> >
>>
>
Re: LineLength for checkstyle
Posted by Suraj Khurana <su...@hotwax.co>.
Thanks everyone,
Here[1] is the ticket to track this improvement.
[1]: https://issues.apache.org/jira/browse/OFBIZ-11737
--
Best Regards,
Suraj Khurana
Senior Technical Consultant
On Sun, May 24, 2020 at 1:58 PM Olivier Heintz <
holivier.lists@ofbizextra.org> wrote:
> +1
>
> Le 23/05/2020 à 17:29, Suraj Khurana a écrit :
> > Hello Devs,
> >
> > Recently we are facing some checkstyle issues and one cause of it is
> > LineLength property.
> > Currently we have set it to 120, I think we should make it to 150
> instead.
> > It is pretty visible in 13/14 font sizes as well.
> >
> > Please share your thoughts on this.
> >
> > --
> > Best Regards,
> > Suraj Khurana
> > Senior Technical Consultant
> >
>
Re: LineLength for checkstyle
Posted by Olivier Heintz <ho...@ofbizextra.org>.
+1
Le 23/05/2020 à 17:29, Suraj Khurana a écrit :
> Hello Devs,
>
> Recently we are facing some checkstyle issues and one cause of it is
> LineLength property.
> Currently we have set it to 120, I think we should make it to 150 instead.
> It is pretty visible in 13/14 font sizes as well.
>
> Please share your thoughts on this.
>
> --
> Best Regards,
> Suraj Khurana
> Senior Technical Consultant
>
Re: LineLength for checkstyle
Posted by Aditya Sharma <ad...@apache.org>.
+1
Thanks and Regards,
Aditya Sharma
On Sat, May 23, 2020 at 10:16 PM Pawan Verma <pa...@apache.org> wrote:
> +1
>
> Pawan
>
Re: LineLength for checkstyle
Posted by Pawan Verma <pa...@apache.org>.
+1
Pawan
Re: LineLength for checkstyle
Posted by Jacques Le Roux <ja...@les7arts.com>.
+1
Jacques
Le 23/05/2020 à 17:29, Suraj Khurana a écrit :
> Hello Devs,
>
> Recently we are facing some checkstyle issues and one cause of it is
> LineLength property.
> Currently we have set it to 120, I think we should make it to 150 instead.
> It is pretty visible in 13/14 font sizes as well.
>
> Please share your thoughts on this.
>
> --
> Best Regards,
> Suraj Khurana
> Senior Technical Consultant
Re: LineLength for checkstyle
Posted by Mridul Pathak <mr...@hotwaxsystems.com>.
+1
Thanks.
--
Mridul Pathak
> On 23-May-2020, at 8:59 PM, Suraj Khurana <su...@hotwax.co> wrote:
>
> Hello Devs,
>
> Recently we are facing some checkstyle issues and one cause of it is
> LineLength property.
> Currently we have set it to 120, I think we should make it to 150 instead.
> It is pretty visible in 13/14 font sizes as well.
>
> Please share your thoughts on this.
>
> --
> Best Regards,
> Suraj Khurana
> Senior Technical Consultant