[GitHub] [incubator-hudi] bhasudha commented on a change in pull request #1479: [HUDI-758] Modify Integration test to include incremental queries on MOR tables

[GitBox <gi...@apache.org>]

bhasudha commented on a change in pull request #1479: [HUDI-758] Modify Integration test to include incremental queries on MOR tables
URL: https://github.com/apache/incubator-hudi/pull/1479#discussion_r405870533
 
 

 ##########
 File path: hudi-integ-test/src/test/java/org/apache/hudi/integ/ITTestHoodieDemo.java
 ##########
 @@ -267,23 +270,37 @@ private void testSparkSQLAfterSecondBatch() throws Exception {
     assertStdOutContains(stdOutErrPair, "|GOOG  |2018-08-31 10:29:00|3391  |1230.1899|1230.085|");
   }
 
-  private void testIncrementalHiveQuery() throws Exception {
+  private void testIncrementalHiveQuery(String minCommitTimeScript, String incrementalCommandsFile,
+                                        String expectedOutput, int expectedTimes) throws Exception {
     String minCommitTime =
-        executeCommandStringInDocker(ADHOC_2_CONTAINER, MIN_COMMIT_TIME_SCRIPT, true).getStdout().toString();
+        executeCommandStringInDocker(ADHOC_2_CONTAINER, minCommitTimeScript, true).getStdout().toString();
     Pair<String, String> stdOutErrPair =
-        executeHiveCommandFile(HIVE_INCREMENTAL_COMMANDS, "min.commit.time=" + minCommitTime + "`");
-    assertStdOutContains(stdOutErrPair, "| GOOG    | 2018-08-31 10:59:00  | 9021    | 1227.1993  | 1227.215  |");
+        executeHiveCommandFile(incrementalCommandsFile, "min.commit.time=" + minCommitTime + "`");
+    assertStdOutContains(stdOutErrPair, expectedOutput, expectedTimes);
+  }
+
+  private void testIncrementalHiveQueryBeforeCompaction() throws Exception {
+    String expectedOutputCOW = "| GOOG    | 2018-08-31 10:59:00  | 9021    | 1227.1993  | 1227.215  |";
 
 Review comment:
   minor nit: please consider renaming the variable to `expectedOutput` instead since its used across all types of tables. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services