You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by Claus Ibsen <cl...@gmail.com> on 2022/02/28 09:16:05 UTC
Disable PMD in PRs
Hi
When reviewing PRs then they are now very very long due to PMD checks
reporting a ton of stuff that is not relevant - such as in the source
code generated classes and much more.
Either we should disable it, or find a way to make it "not shown" and
that you can click a button or something to see the PMD if you want
to.
--
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2
Re: Disable PMD in PRs
Posted by Otavio Rodolfo Piske <an...@gmail.com>.
I noticed that the annotations are still there. I will remove those today.
On Mon, Feb 28, 2022 at 2:19 PM Otavio Rodolfo Piske <an...@gmail.com>
wrote:
> BTW,
>
> re-analyzing did not seem to have any effect. Therefore, if you notice
> that annotations remain there, please let me know and I'll take a look.
>
> On Mon, Feb 28, 2022 at 1:17 PM Otavio Rodolfo Piske <an...@gmail.com>
> wrote:
>
>> Hi,
>>
>> I removed the annotations on the PRs. It will remain on the existing ones
>> unless they are re-analyzed AFAIK, but future PRs should not have it.
>>
>> Kind regards
>>
>> On Mon, Feb 28, 2022 at 1:10 PM Otavio Rodolfo Piske <
>> angusyoung@gmail.com> wrote:
>>
>>> Hi, yeah, this is too verbose. I'll take a pause on the resume work to
>>> take a look at this.
>>>
>>> Kind regards
>>>
>>> On Mon, Feb 28, 2022 at 10:49 AM Zheng Feng <zf...@redhat.com> wrote:
>>>
>>>> +1 to disable PMD checks or is it possible to exclude the generated
>>>> classes
>>>> ?
>>>>
>>>> On Mon, Feb 28, 2022 at 5:24 PM Claus Ibsen <cl...@gmail.com>
>>>> wrote:
>>>>
>>>> > Hi
>>>> >
>>>> > When reviewing PRs then they are now very very long due to PMD checks
>>>> > reporting a ton of stuff that is not relevant - such as in the source
>>>> > code generated classes and much more.
>>>> >
>>>> > Either we should disable it, or find a way to make it "not shown" and
>>>> > that you can click a button or something to see the PMD if you want
>>>> > to.
>>>> >
>>>> >
>>>> >
>>>> > --
>>>> > Claus Ibsen
>>>> > -----------------
>>>> > http://davsclaus.com @davsclaus
>>>> > Camel in Action 2: https://www.manning.com/ibsen2
>>>> >
>>>> >
>>>>
>>>
>>>
>>> --
>>> Otavio R. Piske
>>> http://orpiske.net
>>>
>>
>>
>> --
>> Otavio R. Piske
>> http://orpiske.net
>>
>
>
> --
> Otavio R. Piske
> http://orpiske.net
>
--
Otavio R. Piske
http://orpiske.net
Re: Disable PMD in PRs
Posted by Otavio Rodolfo Piske <an...@gmail.com>.
BTW,
re-analyzing did not seem to have any effect. Therefore, if you notice that
annotations remain there, please let me know and I'll take a look.
On Mon, Feb 28, 2022 at 1:17 PM Otavio Rodolfo Piske <an...@gmail.com>
wrote:
> Hi,
>
> I removed the annotations on the PRs. It will remain on the existing ones
> unless they are re-analyzed AFAIK, but future PRs should not have it.
>
> Kind regards
>
> On Mon, Feb 28, 2022 at 1:10 PM Otavio Rodolfo Piske <an...@gmail.com>
> wrote:
>
>> Hi, yeah, this is too verbose. I'll take a pause on the resume work to
>> take a look at this.
>>
>> Kind regards
>>
>> On Mon, Feb 28, 2022 at 10:49 AM Zheng Feng <zf...@redhat.com> wrote:
>>
>>> +1 to disable PMD checks or is it possible to exclude the generated
>>> classes
>>> ?
>>>
>>> On Mon, Feb 28, 2022 at 5:24 PM Claus Ibsen <cl...@gmail.com>
>>> wrote:
>>>
>>> > Hi
>>> >
>>> > When reviewing PRs then they are now very very long due to PMD checks
>>> > reporting a ton of stuff that is not relevant - such as in the source
>>> > code generated classes and much more.
>>> >
>>> > Either we should disable it, or find a way to make it "not shown" and
>>> > that you can click a button or something to see the PMD if you want
>>> > to.
>>> >
>>> >
>>> >
>>> > --
>>> > Claus Ibsen
>>> > -----------------
>>> > http://davsclaus.com @davsclaus
>>> > Camel in Action 2: https://www.manning.com/ibsen2
>>> >
>>> >
>>>
>>
>>
>> --
>> Otavio R. Piske
>> http://orpiske.net
>>
>
>
> --
> Otavio R. Piske
> http://orpiske.net
>
--
Otavio R. Piske
http://orpiske.net
Re: Disable PMD in PRs
Posted by Otavio Rodolfo Piske <an...@gmail.com>.
Hi,
I removed the annotations on the PRs. It will remain on the existing ones
unless they are re-analyzed AFAIK, but future PRs should not have it.
Kind regards
On Mon, Feb 28, 2022 at 1:10 PM Otavio Rodolfo Piske <an...@gmail.com>
wrote:
> Hi, yeah, this is too verbose. I'll take a pause on the resume work to
> take a look at this.
>
> Kind regards
>
> On Mon, Feb 28, 2022 at 10:49 AM Zheng Feng <zf...@redhat.com> wrote:
>
>> +1 to disable PMD checks or is it possible to exclude the generated
>> classes
>> ?
>>
>> On Mon, Feb 28, 2022 at 5:24 PM Claus Ibsen <cl...@gmail.com>
>> wrote:
>>
>> > Hi
>> >
>> > When reviewing PRs then they are now very very long due to PMD checks
>> > reporting a ton of stuff that is not relevant - such as in the source
>> > code generated classes and much more.
>> >
>> > Either we should disable it, or find a way to make it "not shown" and
>> > that you can click a button or something to see the PMD if you want
>> > to.
>> >
>> >
>> >
>> > --
>> > Claus Ibsen
>> > -----------------
>> > http://davsclaus.com @davsclaus
>> > Camel in Action 2: https://www.manning.com/ibsen2
>> >
>> >
>>
>
>
> --
> Otavio R. Piske
> http://orpiske.net
>
--
Otavio R. Piske
http://orpiske.net
Re: Disable PMD in PRs
Posted by Otavio Rodolfo Piske <an...@gmail.com>.
Hi, yeah, this is too verbose. I'll take a pause on the resume work to take
a look at this.
Kind regards
On Mon, Feb 28, 2022 at 10:49 AM Zheng Feng <zf...@redhat.com> wrote:
> +1 to disable PMD checks or is it possible to exclude the generated classes
> ?
>
> On Mon, Feb 28, 2022 at 5:24 PM Claus Ibsen <cl...@gmail.com> wrote:
>
> > Hi
> >
> > When reviewing PRs then they are now very very long due to PMD checks
> > reporting a ton of stuff that is not relevant - such as in the source
> > code generated classes and much more.
> >
> > Either we should disable it, or find a way to make it "not shown" and
> > that you can click a button or something to see the PMD if you want
> > to.
> >
> >
> >
> > --
> > Claus Ibsen
> > -----------------
> > http://davsclaus.com @davsclaus
> > Camel in Action 2: https://www.manning.com/ibsen2
> >
> >
>
--
Otavio R. Piske
http://orpiske.net
Re: Disable PMD in PRs
Posted by Zheng Feng <zf...@redhat.com>.
+1 to disable PMD checks or is it possible to exclude the generated classes
?
On Mon, Feb 28, 2022 at 5:24 PM Claus Ibsen <cl...@gmail.com> wrote:
> Hi
>
> When reviewing PRs then they are now very very long due to PMD checks
> reporting a ton of stuff that is not relevant - such as in the source
> code generated classes and much more.
>
> Either we should disable it, or find a way to make it "not shown" and
> that you can click a button or something to see the PMD if you want
> to.
>
>
>
> --
> Claus Ibsen
> -----------------
> http://davsclaus.com @davsclaus
> Camel in Action 2: https://www.manning.com/ibsen2
>
>
Re: Disable PMD in PRs
Posted by Andrea Cosentino <an...@gmail.com>.
Yeah,
+1 from my side.
For big PRs, it become expensive to go through the code.
Il giorno lun 28 feb 2022 alle ore 10:16 Claus Ibsen <cl...@gmail.com>
ha scritto:
> Hi
>
> When reviewing PRs then they are now very very long due to PMD checks
> reporting a ton of stuff that is not relevant - such as in the source
> code generated classes and much more.
>
> Either we should disable it, or find a way to make it "not shown" and
> that you can click a button or something to see the PMD if you want
> to.
>
>
>
> --
> Claus Ibsen
> -----------------
> http://davsclaus.com @davsclaus
> Camel in Action 2: https://www.manning.com/ibsen2
>