You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Jesus Camacho Rodriguez (JIRA)" <ji...@apache.org> on 2017/06/20 11:01:05 UTC

[jira] [Resolved] (CALCITE-1848) Rename MySource to FileSource

     [ https://issues.apache.org/jira/browse/CALCITE-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesus Camacho Rodriguez resolved CALCITE-1848.
----------------------------------------------
       Resolution: Fixed
    Fix Version/s: 1.13.0

Fixed in https://github.com/apache/calcite/pull/d5c713c .

Thanks for your contribution [~darion]!

> Rename MySource to FileSource
> -----------------------------
>
>                 Key: CALCITE-1848
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1848
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: darion yaphet
>            Assignee: darion yaphet
>            Priority: Minor
>             Fix For: 1.13.0
>
>
> In *FileSchema* loading directory from Sources.of() and create a *MySource* instance . Although *MySource* is a private inner class but I think MySource is really not a good name , FileSource is better .



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)