[GitHub] [iceberg] hililiwei commented on a diff in pull request #7236: Flink: support table comment

["hililiwei (via GitHub)" <gi...@apache.org>]

hililiwei commented on code in PR #7236:
URL: https://github.com/apache/iceberg/pull/7236#discussion_r1152954980


##########
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##########
@@ -418,7 +419,10 @@ void createIcebergTable(ObjectPath tablePath, CatalogBaseTable table, boolean ig
         properties.put(entry.getKey(), entry.getValue());
       }
     }
-
+    // add table comment
+    if (!StringUtils.isNullOrWhitespaceOnly(table.getComment())) {
+      properties.put(COMMENT, table.getComment());
+    }

Review Comment:
   nit: empty line.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org