You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/08 21:02:40 UTC
[GitHub] [airflow] subkanthi opened a new pull request #19482: [19458] Added column duration to DAG runs view
subkanthi opened a new pull request #19482:
URL: https://github.com/apache/airflow/pull/19482
Added column duration(derived) to DAG runs view
closes: #19458
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb edited a comment on pull request #19482: [19458] Added column duration to DAG runs view
Posted by GitBox <gi...@apache.org>.
ashb edited a comment on pull request #19482:
URL: https://github.com/apache/airflow/pull/19482#issuecomment-964974903
Or we could use the existing `convertSecsToHumanReadable` function in JS the front end to make it nicer, or an equivalent behaviour on the backend for display?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #19482: [19458] Added column duration to DAG runs view
Posted by GitBox <gi...@apache.org>.
uranusjr merged pull request #19482:
URL: https://github.com/apache/airflow/pull/19482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] alexInhert commented on pull request #19482: [19458] Added column duration to DAG runs view
Posted by GitBox <gi...@apache.org>.
alexInhert commented on pull request #19482:
URL: https://github.com/apache/airflow/pull/19482#issuecomment-964557364
Should it have tooltip that explains that the metric is in seconds?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #19482: [19458] Added column duration to DAG runs view
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on pull request #19482:
URL: https://github.com/apache/airflow/pull/19482#issuecomment-963574100
Could you add the screenshot you posted in the issue here in the PR?
We should also make sure the duration formats in /dagrun and /taskinstance are consistent (/taskinstance below):
<img width="115" alt="Screen Shot 2021-11-08 at 3 06 28 PM" src="https://user-images.githubusercontent.com/4600967/140818170-cabf6189-efa7-4e6a-9f3b-0840819bb252.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] subkanthi commented on pull request #19482: [19458] Added column duration to DAG runs view
Posted by GitBox <gi...@apache.org>.
subkanthi commented on pull request #19482:
URL: https://github.com/apache/airflow/pull/19482#issuecomment-964185411
> Could you add the screenshot you posted in the issue here in the PR? We should also make sure the duration formats in /dagrun and /taskinstance are consistent (/taskinstance below):
>
> <img alt="Screen Shot 2021-11-08 at 3 06 28 PM" width="115" src="https://user-images.githubusercontent.com/4600967/140818170-cabf6189-efa7-4e6a-9f3b-0840819bb252.png">
Sure here it i
s
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #19482: [19458] Added column duration to DAG runs view
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #19482:
URL: https://github.com/apache/airflow/pull/19482#issuecomment-966120485
LGTM, I just wonder if it’s worthwhile to display the time this precisely. A couple of decimal points is more than enough IMO. (Same applies to the task instance table.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] subkanthi commented on pull request #19482: [19458] Added column duration to DAG runs view
Posted by GitBox <gi...@apache.org>.
subkanthi commented on pull request #19482:
URL: https://github.com/apache/airflow/pull/19482#issuecomment-981694494
> LGTM, I just wonder if it’s worthwhile to display the time this precisely. A couple of decimal points is more than enough IMO. (Same applies to the task instance table.)
Hi @uranusjr , should I be starting a separate discussion for this, can this PR be merged in the meantime?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] subkanthi commented on pull request #19482: [19458] Added column duration to DAG runs view
Posted by GitBox <gi...@apache.org>.
subkanthi commented on pull request #19482:
URL: https://github.com/apache/airflow/pull/19482#issuecomment-965631861
> Or we could use the existing `convertSecsToHumanReadable` function in JS the front end to make it nicer, or an equivalent behaviour on the backend for display?
Please see attached, changed the default to 0.0 and the same format as the duration in taskInstance(d:m:s)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19482: [19458] Added column duration to DAG runs view
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19482:
URL: https://github.com/apache/airflow/pull/19482#issuecomment-964225160
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #19482: [19458] Added column duration to DAG runs view
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #19482:
URL: https://github.com/apache/airflow/pull/19482#issuecomment-964974903
Or we could use the existing `convertSecsToHumanReadable` function in JS the front end to make it nicer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org