You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/13 13:06:23 UTC
[GitHub] [tvm] Icemist opened a new pull request, #10996: Add FlattenAtrousConv transformation
Icemist opened a new pull request, #10996:
URL: https://github.com/apache/tvm/pull/10996
This transformation flattens atrous convolution, i.e. finds a sequence of space_to_batch_nd->conv2d->batch_to_space_nd operations and convert them into subgraphs with a convolution with the modified "dilation" and recalculated "padding" parameters.
```
x w x w
| | | |
s2b | \ /
\ / \ /
conv2d -> conv2d
| |
b2s |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Icemist commented on pull request #10996: Add FlattenAtrousConv transformation
Posted by GitBox <gi...@apache.org>.
Icemist commented on PR #10996:
URL: https://github.com/apache/tvm/pull/10996#issuecomment-1103906708
> Interesting, I think we can safely enable this pass in the default pipeline as @elvin-n suggested, @Icemist do you want to do that?
>
> You can put the new pass in
>
> https://github.com/apache/tvm/blob/4c608be12a80594cefc4c81a0dc62d7069be1971/src/relay/backend/utils.cc#L206
Yes, I posted it as a separate commit https://github.com/apache/tvm/pull/11077. I apologize for the long response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Icemist commented on pull request #10996: Add FlattenAtrousConv transformation
Posted by GitBox <gi...@apache.org>.
Icemist commented on PR #10996:
URL: https://github.com/apache/tvm/pull/10996#issuecomment-1100086093
@masahi @jwfromm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] elvin-n commented on pull request #10996: Add FlattenAtrousConv transformation
Posted by GitBox <gi...@apache.org>.
elvin-n commented on PR #10996:
URL: https://github.com/apache/tvm/pull/10996#issuecomment-1102680117
It's pity not to include this pass into standard optimization flows. @Icemist please create another PR with adding it to regular optimization passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] elvin-n commented on pull request #10996: Add FlattenAtrousConv transformation
Posted by GitBox <gi...@apache.org>.
elvin-n commented on PR #10996:
URL: https://github.com/apache/tvm/pull/10996#issuecomment-1099175375
I propose to add invocation of this pass into standard optimize function `OptimizeImpl` [here](https://github.com/apache/tvm/blob/main/src/relay/backend/build_module.cc#L334). This will allow to avoid situation when users are not familiar with this pass and will not know when and how to call it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] TejashShah commented on pull request #10996: Add FlattenAtrousConv transformation
Posted by GitBox <gi...@apache.org>.
TejashShah commented on PR #10996:
URL: https://github.com/apache/tvm/pull/10996#issuecomment-1105407233
@Icemist Excellent piece of contribution, regardless of target! Appreciate your efforts in mainlining it
cc @elvin-n
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #10996: Add FlattenAtrousConv transformation
Posted by GitBox <gi...@apache.org>.
masahi commented on PR #10996:
URL: https://github.com/apache/tvm/pull/10996#issuecomment-1100435901
Interesting, I think we can safely enable this pass in the default pipeline as @elvin-n suggested, @Icemist do you want to do that?
You can put the new pass in https://github.com/apache/tvm/blob/4c608be12a80594cefc4c81a0dc62d7069be1971/src/relay/backend/utils.cc#L206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #10996: Add FlattenAtrousConv transformation
Posted by GitBox <gi...@apache.org>.
masahi merged PR #10996:
URL: https://github.com/apache/tvm/pull/10996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org