You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/04/27 03:07:28 UTC
[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #5679: Set correct InternalEndpoint and DataBlockEndpoint when planning
xingtanzjr commented on code in PR #5679:
URL: https://github.com/apache/iotdb/pull/5679#discussion_r859334943
##########
server/src/main/java/org/apache/iotdb/db/mpp/execution/QueryExecution.java:
##########
@@ -300,9 +300,7 @@ private void initResultHandle() {
.createSourceHandle(
context.getResultNodeContext().getVirtualFragmentInstanceId().toThrift(),
context.getResultNodeContext().getVirtualResultNodeId().getId(),
- new TEndPoint(
- context.getResultNodeContext().getUpStreamEndpoint().getIp(),
- IoTDBDescriptor.getInstance().getConfig().getDataBlockManagerPort()),
+ context.getLocalDataBlockEndpoint(),
Review Comment:
Fixed
##########
server/src/main/java/org/apache/iotdb/db/mpp/execution/Coordinator.java:
##########
@@ -53,7 +53,12 @@ public class Coordinator {
private static final String COORDINATOR_SCHEDULED_EXECUTOR_NAME = "MPPCoordinatorScheduled";
private static final int COORDINATOR_SCHEDULED_EXECUTOR_SIZE = 1;
- private static final TEndPoint LOCAL_HOST =
+ private static final TEndPoint LOCAL_HOST_DATA_BLOCK_ENDPOINT =
+ new TEndPoint(
+ IoTDBDescriptor.getInstance().getConfig().getRpcAddress(),
Review Comment:
FIxed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org