You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/29 12:46:01 UTC
[GitHub] [apisix] imjoey opened a new pull request #4708: chore: add sudo privilege for make install command at installing luarocks
imjoey opened a new pull request #4708:
URL: https://github.com/apache/apisix/pull/4708
Signed-off-by: imjoey <ma...@apache.org>
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
For now, the package `luarocks` will be installed at `/usr/local` via `make install` command. If simply running the `curl https://raw.githubusercontent.com/apache/apisix/master/utils/linux-install-luarocks.sh -sL | bash -`, we will encounter an error due to privilege errors. For details, please refer to #4703.
As discussed with @spacewander, we decide to add the `sudo` back via this PR. This would let users install APISIX without any interruptions.
With this patch merged in my environment, I could successfully install luarocks in CentOS 7 as both **non-root** and **root** users.
<!--- If it fixes an open issue, please link to the issue here. -->
#4703
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4708: chore: add sudo privilege for make install command at installing luarocks
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4708:
URL: https://github.com/apache/apisix/pull/4708#discussion_r679140580
##########
File path: utils/linux-install-luarocks.sh
##########
@@ -40,7 +40,7 @@ fi
make build > build.log 2>&1 || (cat build.log && exit 1)
msg="rerun this script with 'sudo' if you failed to make install because of privilege problem."
Review comment:
We can remove this prompt and other sudo in the ci script or docs now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers merged pull request #4708: chore: add sudo privilege for make install command at installing luarocks
Posted by GitBox <gi...@apache.org>.
tokers merged pull request #4708:
URL: https://github.com/apache/apisix/pull/4708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] imjoey commented on a change in pull request #4708: chore: add sudo privilege for make install command at installing luarocks
Posted by GitBox <gi...@apache.org>.
imjoey commented on a change in pull request #4708:
URL: https://github.com/apache/apisix/pull/4708#discussion_r679143704
##########
File path: utils/linux-install-luarocks.sh
##########
@@ -40,7 +40,7 @@ fi
make build > build.log 2>&1 || (cat build.log && exit 1)
msg="rerun this script with 'sudo' if you failed to make install because of privilege problem."
Review comment:
I think yes if everything is as expected. We could safely remove this prompt if it's only for `make install`. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4708: chore: add sudo privilege for make install command at installing luarocks
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4708:
URL: https://github.com/apache/apisix/pull/4708#discussion_r679190228
##########
File path: utils/linux-install-luarocks.sh
##########
@@ -40,7 +40,7 @@ fi
make build > build.log 2>&1 || (cat build.log && exit 1)
msg="rerun this script with 'sudo' if you failed to make install because of privilege problem."
Review comment:
Yes. We think about the same thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org