You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2009/07/30 20:52:51 UTC
DO NOT REPLY [Bug 47609] New: Failsafe EOL conversion
https://issues.apache.org/bugzilla/show_bug.cgi?id=47609
Summary: Failsafe EOL conversion
Product: Tomcat 5
Version: 5.5.27
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: normal
Priority: P2
Component: Native:Packaging
AssignedTo: dev@tomcat.apache.org
ReportedBy: sebb@apache.org
Created an attachment (id=24066)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=24066)
List of extensions used in 5.5.28
The builds/build.xml file has the following code:
<target name="package-src-tgz">
<fixcrlf srcdir="${tomcat.dist}/src"
excludes="**/*.bin,**/*.bmp,**/*.dia,**/*.exe,**/*.gif,**/*.ico,**/*.jar,**/*.jpg,**/*.pdf,**/*.rtf,**/*.war"
eol="lf"
encoding="ISO-8859-1" fixlast="false" />
The intention is to fix all the source files so that they are readable on Unix
(LF) systems.
However, the command is inherently unsafe - if a new binary file is added with
an extension that is not listed, then the file will be damaged. In general it
is impossible to reverse LF-conversion on a binary file.
It would be much safer to use includes instead. If a new source file type is
added, then the worst that can happen is that the file is awkard to read on
Unix. Unlike the case with binary files, the file can still be converted
successfully.
The current list of extensions that are present in the 5.5.28 source archive
are included in the file "extensions.txt".
At least two binary extensions (.db, .keystore) are currently missing from the
excludes list.
There are quite a few files with no extension. These appear to be all text
files, and are listed in the file "no-extension.txt" (duplicate names have been
removed).
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 47609] Failsafe EOL conversion
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47609
--- Comment #2 from Filip Hanik <fh...@apache.org> 2009-07-31 16:04:23 PST ---
So the only safe way to do it, would be to specify an includes list instead of
using an excludes.
Patches welcome
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 47609] Failsafe EOL conversion
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47609
--- Comment #4 from Sebb <se...@apache.org> 2009-08-02 08:24:37 PST ---
Created an attachment (id=24080)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=24080)
fixcrlf use include rather than exclude
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 47609] Failsafe EOL conversion
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47609
--- Comment #6 from Mark Thomas <ma...@apache.org> 2009-11-22 11:31:59 GMT ---
Modified patch applied to trunk and proposed for 6.0.x and 5.5.x
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 47609] Failsafe EOL conversion
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47609
Sebb <se...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24080|0 |1
is obsolete| |
--- Comment #5 from Sebb <se...@apache.org> 2009-08-02 08:29:53 PST ---
Created an attachment (id=24081)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=24081)
Improved patch - detab
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 47609] Failsafe EOL conversion
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47609
Konstantin Kolinko <kn...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #7 from Konstantin Kolinko <kn...@gmail.com> 2010-03-04 20:30:20 UTC ---
Fixed in 6.0.22, 5.5.29.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 47609] Failsafe EOL conversion
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47609
--- Comment #1 from Sebb <se...@apache.org> 2009-07-30 11:53:24 PST ---
Created an attachment (id=24067)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=24067)
List of files with no extension
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 47609] Failsafe EOL conversion
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47609
--- Comment #3 from Sebb <se...@apache.org> 2009-08-02 07:26:27 PST ---
OK, I will create a patch shortly
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org