You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/23 20:53:21 UTC
[GitHub] [superset] yardz opened a new pull request #13753: test: FilterBoxItemControl
yardz opened a new pull request #13753:
URL: https://github.com/apache/superset/pull/13753
### SUMMARY
Tests for FilterBoxItemControl
- Moved to own folder
- Creating tests for the component
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13753: test: FilterBoxItemControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13753:
URL: https://github.com/apache/superset/pull/13753#issuecomment-805299806
# [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=h1) Report
> Merging [#13753](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=desc) (5ed0adc) into [master](https://codecov.io/gh/apache/superset/commit/5b79f84e1ba2feab10bc9b96fd786d82418b7b4a?el=desc) (5b79f84) will **decrease** coverage by `0.29%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13753 +/- ##
==========================================
- Coverage 77.45% 77.15% -0.30%
==========================================
Files 933 935 +2
Lines 47144 47442 +298
Branches 5848 5936 +88
==========================================
+ Hits 36516 36606 +90
- Misses 10485 10688 +203
- Partials 143 148 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.24% <0.00%> (-0.11%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...components/controls/FilterBoxItemControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC9pbmRleC5qc3g=) | `13.20% <0.00%> (ø)` | |
| [superset-frontend/src/middleware/asyncEvent.ts](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvYXN5bmNFdmVudC50cw==) | `53.54% <0.00%> (-33.80%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `37.50% <0.00%> (-26.14%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `40.00% <0.00%> (-23.64%)` | :arrow_down: |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `48.59% <0.00%> (-15.79%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `68.75% <0.00%> (-9.25%)` | :arrow_down: |
| [...tasourcePanel/DatasourcePanelDragWrapper/index.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvRGF0YXNvdXJjZVBhbmVsRHJhZ1dyYXBwZXIvaW5kZXgudHN4) | `16.66% <0.00%> (ø)` | |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `92.42% <0.00%> (+1.51%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=footer). Last update [5b79f84...5ed0adc](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yardz commented on a change in pull request #13753: test: FilterBoxItemControl
Posted by GitBox <gi...@apache.org>.
yardz commented on a change in pull request #13753:
URL: https://github.com/apache/superset/pull/13753#discussion_r600862661
##########
File path: superset-frontend/src/explore/components/controls/FilterBoxItemControl/FilterBoxItemControl.test.tsx
##########
@@ -0,0 +1,78 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React from 'react';
+import { render, screen } from 'spec/helpers/testing-library';
+import userEvent from '@testing-library/user-event';
+import FilterBoxItemControl from '.';
+
+const datasource = {
+ columns: [],
+ metrics: [],
+};
+
+let props = {
Review comment:
> * For the tests where we have plain object props the spread operator `{...props}` is already guaranteeing immutability. In this case, we can define the default props as a `const` and override them in each test.
This is very specific. It would only work for simpler objects (which is not the case most of the time)
> * For more complex structures we could use Lodash `cloneDeep` and follow the same pattern.
It is a good option when we do not have many functions. But I would like to avoid using more things than necessary in the tests ...
> * If we want to use `beforeEach`, and assert that the default props have the correct type, we can do something like:
Use factories! I loved this option, we didn't add external dependencies and we always have a new object. We can even remove the beforeEach in some cases. In the future we can add tests to check the immutability of the parameters. great idea!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13753: test: FilterBoxItemControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13753:
URL: https://github.com/apache/superset/pull/13753#issuecomment-805299806
# [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=h1) Report
> Merging [#13753](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=desc) (df9bf5e) into [master](https://codecov.io/gh/apache/superset/commit/5b79f84e1ba2feab10bc9b96fd786d82418b7b4a?el=desc) (5b79f84) will **decrease** coverage by `0.98%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13753 +/- ##
==========================================
- Coverage 77.45% 76.46% -0.99%
==========================================
Files 933 942 +9
Lines 47144 48074 +930
Branches 5848 6125 +277
==========================================
+ Hits 36516 36762 +246
- Misses 10485 11164 +679
- Partials 143 148 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.04% <ø> (-0.31%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...components/controls/FilterBoxItemControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC9pbmRleC5qc3g=) | `13.20% <ø> (ø)` | |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `63.49% <0.00%> (-33.88%)` | :arrow_down: |
| [superset-frontend/src/middleware/asyncEvent.ts](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvYXN5bmNFdmVudC50cw==) | `53.54% <0.00%> (-33.80%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `47.24% <0.00%> (-33.58%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `37.50% <0.00%> (-26.14%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/welcome/ChartTable.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9DaGFydFRhYmxlLnRzeA==) | `51.38% <0.00%> (-25.70%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `40.00% <0.00%> (-23.64%)` | :arrow_down: |
| [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `41.17% <0.00%> (-22.46%)` | :arrow_down: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `40.47% <0.00%> (-21.55%)` | :arrow_down: |
| ... and [20 more](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=footer). Last update [5b79f84...df9bf5e](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13753: test: FilterBoxItemControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13753:
URL: https://github.com/apache/superset/pull/13753#issuecomment-805299806
# [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=h1) Report
> Merging [#13753](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=desc) (5ed0adc) into [master](https://codecov.io/gh/apache/superset/commit/5b79f84e1ba2feab10bc9b96fd786d82418b7b4a?el=desc) (5b79f84) will **decrease** coverage by `1.52%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13753 +/- ##
==========================================
- Coverage 77.45% 75.92% -1.53%
==========================================
Files 933 935 +2
Lines 47144 47441 +297
Branches 5848 5936 +88
==========================================
- Hits 36516 36021 -495
- Misses 10485 11258 +773
- Partials 143 162 +19
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `48.68% <0.00%> (-7.67%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...components/controls/FilterBoxItemControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC9pbmRleC5qc3g=) | `13.20% <0.00%> (ø)` | |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| [superset-frontend/src/filters/components/common.ts](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9jb21tb24udHM=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [superset-frontend/src/dataMask/reducer.ts](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFNYXNrL3JlZHVjZXIudHM=) | `44.00% <0.00%> (-56.00%)` | :arrow_down: |
| ... and [76 more](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=footer). Last update [5b79f84...5ed0adc](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13753: test: FilterBoxItemControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13753:
URL: https://github.com/apache/superset/pull/13753#issuecomment-805299806
# [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=h1) Report
> Merging [#13753](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=desc) (a50f096) into [master](https://codecov.io/gh/apache/superset/commit/5b79f84e1ba2feab10bc9b96fd786d82418b7b4a?el=desc) (5b79f84) will **decrease** coverage by `0.58%`.
> The diff coverage is `82.53%`.
> :exclamation: Current head a50f096 differs from pull request most recent head 1134fda. Consider uploading reports for the commit 1134fda to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13753 +/- ##
==========================================
- Coverage 77.45% 76.87% -0.59%
==========================================
Files 933 935 +2
Lines 47144 47303 +159
Branches 5848 5889 +41
==========================================
- Hits 36516 36362 -154
- Misses 10485 10779 +294
- Partials 143 162 +19
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.53% <26.94%> (-2.82%)` | :arrow_down: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `49.29% <ø> (-15.09%)` | :arrow_down: |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `96.42% <ø> (ø)` | |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `100.00% <ø> (+36.36%)` | :arrow_up: |
| [...tasourcePanel/DatasourcePanelDragWrapper/index.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvRGF0YXNvdXJjZVBhbmVsRHJhZ1dyYXBwZXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...components/controls/FilterBoxItemControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC9pbmRleC5qc3g=) | `13.20% <0.00%> (ø)` | |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `100.00% <ø> (+36.36%)` | :arrow_up: |
| ... and [64 more](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=footer). Last update [5b79f84...1134fda](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13753: test: FilterBoxItemControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13753:
URL: https://github.com/apache/superset/pull/13753#issuecomment-805299806
# [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=h1) Report
> Merging [#13753](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=desc) (0298b8c) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 0298b8c differs from pull request most recent head e9ba6e0. Consider uploading reports for the commit e9ba6e0 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13753 +/- ##
=======================================
Coverage 77.55% 77.56%
=======================================
Files 935 935
Lines 47301 47301
Branches 5907 5907
=======================================
+ Hits 36685 36687 +2
+ Misses 10472 10470 -2
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <ø> (-0.01%)` | :arrow_down: |
| javascript | `63.74% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...components/controls/FilterBoxItemControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC9pbmRleC5qc3g=) | `73.58% <ø> (ø)` | |
| [...rc/explore/components/controls/CheckboxControl.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9DaGVja2JveENvbnRyb2wuanN4) | `92.85% <0.00%> (+7.14%)` | :arrow_up: |
| [superset-frontend/src/components/FormRow/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRm9ybVJvdy9pbmRleC5qc3g=) | `100.00% <0.00%> (+7.69%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=footer). Last update [d54cc6d...e9ba6e0](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #13753: test: FilterBoxItemControl
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #13753:
URL: https://github.com/apache/superset/pull/13753#discussion_r600825539
##########
File path: superset-frontend/src/explore/components/controls/FilterBoxItemControl/FilterBoxItemControl.test.tsx
##########
@@ -0,0 +1,78 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React from 'react';
+import { render, screen } from 'spec/helpers/testing-library';
+import userEvent from '@testing-library/user-event';
+import FilterBoxItemControl from '.';
+
+const datasource = {
+ columns: [],
+ metrics: [],
+};
+
+let props = {
Review comment:
I think we have some options to improve the readability, especially when the default props are big trees of values:
- For the tests where we have plain object props the spread operator `{...props}` is already guaranteeing immutability. In this case, we can define the default props as a `const` and override them in each test.
- For more complex structures we could use Lodash `cloneDeep` and follow the same pattern.
- If we want to use `beforeEach`, and assert that the default props have the correct type, we can do something like:
```
const newDefaultProps = () => ({
name: 'John',
lastname: 'Doe',
age: 10,
});
let defaultProps: ReturnType<typeof newDefaultProps>;
beforeEach(() => {
defaultProps = newDefaultProps();
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13753: test: FilterBoxItemControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13753:
URL: https://github.com/apache/superset/pull/13753#issuecomment-805299806
# [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=h1) Report
> Merging [#13753](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=desc) (5ed0adc) into [master](https://codecov.io/gh/apache/superset/commit/5b79f84e1ba2feab10bc9b96fd786d82418b7b4a?el=desc) (5b79f84) will **decrease** coverage by `0.29%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13753 +/- ##
==========================================
- Coverage 77.45% 77.15% -0.30%
==========================================
Files 933 935 +2
Lines 47144 47442 +298
Branches 5848 5936 +88
==========================================
+ Hits 36516 36606 +90
- Misses 10485 10688 +203
- Partials 143 148 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.24% <0.00%> (-0.11%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...components/controls/FilterBoxItemControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC9pbmRleC5qc3g=) | `13.20% <0.00%> (ø)` | |
| [superset-frontend/src/middleware/asyncEvent.ts](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvYXN5bmNFdmVudC50cw==) | `53.54% <0.00%> (-33.80%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `37.50% <0.00%> (-26.14%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `40.00% <0.00%> (-23.64%)` | :arrow_down: |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `48.59% <0.00%> (-15.79%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `68.75% <0.00%> (-9.25%)` | :arrow_down: |
| [...tasourcePanel/DatasourcePanelDragWrapper/index.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvRGF0YXNvdXJjZVBhbmVsRHJhZ1dyYXBwZXIvaW5kZXgudHN4) | `16.66% <0.00%> (ø)` | |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `92.42% <0.00%> (+1.51%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=footer). Last update [5b79f84...5ed0adc](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13753: test: FilterBoxItemControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13753:
URL: https://github.com/apache/superset/pull/13753#issuecomment-805299806
# [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=h1) Report
> Merging [#13753](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=desc) (82455f2) into [master](https://codecov.io/gh/apache/superset/commit/5b79f84e1ba2feab10bc9b96fd786d82418b7b4a?el=desc) (5b79f84) will **decrease** coverage by `0.82%`.
> The diff coverage is `51.41%`.
> :exclamation: Current head 82455f2 differs from pull request most recent head 5ed0adc. Consider uploading reports for the commit 5ed0adc to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13753 +/- ##
==========================================
- Coverage 77.45% 76.62% -0.83%
==========================================
Files 933 938 +5
Lines 47144 47859 +715
Branches 5848 6067 +219
==========================================
+ Hits 36516 36674 +158
- Misses 10485 11037 +552
- Partials 143 148 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.97% <26.94%> (-0.37%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `48.59% <ø> (-15.79%)` | :arrow_down: |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `16.66% <ø> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `96.42% <ø> (ø)` | |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `40.00% <ø> (-23.64%)` | :arrow_down: |
| [...tasourcePanel/DatasourcePanelDragWrapper/index.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvRGF0YXNvdXJjZVBhbmVsRHJhZ1dyYXBwZXIvaW5kZXgudHN4) | `16.66% <ø> (ø)` | |
| [...components/controls/FilterBoxItemControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC9pbmRleC5qc3g=) | `13.20% <0.00%> (ø)` | |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `37.50% <ø> (-26.14%)` | :arrow_down: |
| ... and [34 more](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=footer). Last update [5b79f84...5ed0adc](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13753: test: FilterBoxItemControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13753:
URL: https://github.com/apache/superset/pull/13753#issuecomment-805299806
# [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=h1) Report
> Merging [#13753](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=desc) (0298b8c) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 0298b8c differs from pull request most recent head e9ba6e0. Consider uploading reports for the commit e9ba6e0 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13753 +/- ##
=======================================
Coverage 77.55% 77.56%
=======================================
Files 935 935
Lines 47301 47301
Branches 5907 5907
=======================================
+ Hits 36685 36688 +3
+ Misses 10472 10469 -3
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <ø> (ø)` | |
| javascript | `63.74% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...components/controls/FilterBoxItemControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC9pbmRleC5qc3g=) | `73.58% <ø> (ø)` | |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `92.42% <0.00%> (+1.51%)` | :arrow_up: |
| [...rc/explore/components/controls/CheckboxControl.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9DaGVja2JveENvbnRyb2wuanN4) | `92.85% <0.00%> (+7.14%)` | :arrow_up: |
| [superset-frontend/src/components/FormRow/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRm9ybVJvdy9pbmRleC5qc3g=) | `100.00% <0.00%> (+7.69%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=footer). Last update [d54cc6d...e9ba6e0](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13753: test: FilterBoxItemControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13753:
URL: https://github.com/apache/superset/pull/13753#issuecomment-805299806
# [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=h1) Report
> Merging [#13753](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=desc) (a50f096) into [master](https://codecov.io/gh/apache/superset/commit/5b79f84e1ba2feab10bc9b96fd786d82418b7b4a?el=desc) (5b79f84) will **decrease** coverage by `0.10%`.
> The diff coverage is `82.53%`.
> :exclamation: Current head a50f096 differs from pull request most recent head df9bf5e. Consider uploading reports for the commit df9bf5e to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13753 +/- ##
==========================================
- Coverage 77.45% 77.35% -0.11%
==========================================
Files 933 935 +2
Lines 47144 47303 +159
Branches 5848 5889 +41
==========================================
+ Hits 36516 36591 +75
- Misses 10485 10568 +83
- Partials 143 144 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <26.94%> (-0.33%)` | :arrow_down: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `66.19% <ø> (+1.81%)` | :arrow_up: |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `96.42% <ø> (ø)` | |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `100.00% <ø> (+36.36%)` | :arrow_up: |
| [...tasourcePanel/DatasourcePanelDragWrapper/index.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvRGF0YXNvdXJjZVBhbmVsRHJhZ1dyYXBwZXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...components/controls/FilterBoxItemControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC9pbmRleC5qc3g=) | `13.20% <0.00%> (ø)` | |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `100.00% <ø> (+36.36%)` | :arrow_up: |
| ... and [26 more](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=footer). Last update [5b79f84...df9bf5e](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yardz closed pull request #13753: test: FilterBoxItemControl
Posted by GitBox <gi...@apache.org>.
yardz closed pull request #13753:
URL: https://github.com/apache/superset/pull/13753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13753: test: FilterBoxItemControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13753:
URL: https://github.com/apache/superset/pull/13753#issuecomment-805299806
# [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=h1) Report
> Merging [#13753](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=desc) (a21a1a5) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `1.08%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a21a1a5 differs from pull request most recent head e9ba6e0. Consider uploading reports for the commit e9ba6e0 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13753 +/- ##
==========================================
- Coverage 77.55% 76.46% -1.09%
==========================================
Files 935 935
Lines 47301 47302 +1
Branches 5907 5899 -8
==========================================
- Hits 36685 36171 -514
- Misses 10472 10968 +496
- Partials 144 163 +19
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `63.75% <ø> (+0.02%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...components/controls/FilterBoxItemControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC9pbmRleC5qc3g=) | `73.58% <ø> (ø)` | |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | `0.00% <0.00%> (-96.16%)` | :arrow_down: |
| [...ontend/src/dashboard/components/dnd/handleHover.js](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVIb3Zlci5qcw==) | `11.11% <0.00%> (-88.89%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [...rc/dashboard/components/dnd/dragDroppableConfig.js](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9kcmFnRHJvcHBhYmxlQ29uZmlnLmpz) | `35.00% <0.00%> (-65.00%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | `13.20% <0.00%> (-60.38%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (-58.07%)` | :arrow_down: |
| ... and [78 more](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=footer). Last update [d54cc6d...e9ba6e0](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13753: test: FilterBoxItemControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13753:
URL: https://github.com/apache/superset/pull/13753#issuecomment-805299806
# [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=h1) Report
> Merging [#13753](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=desc) (a50f096) into [master](https://codecov.io/gh/apache/superset/commit/5b79f84e1ba2feab10bc9b96fd786d82418b7b4a?el=desc) (5b79f84) will **decrease** coverage by `0.10%`.
> The diff coverage is `82.53%`.
> :exclamation: Current head a50f096 differs from pull request most recent head 1134fda. Consider uploading reports for the commit 1134fda to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13753 +/- ##
==========================================
- Coverage 77.45% 77.35% -0.11%
==========================================
Files 933 935 +2
Lines 47144 47303 +159
Branches 5848 5889 +41
==========================================
+ Hits 36516 36591 +75
- Misses 10485 10568 +83
- Partials 143 144 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <26.94%> (-0.33%)` | :arrow_down: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `66.19% <ø> (+1.81%)` | :arrow_up: |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `96.42% <ø> (ø)` | |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `100.00% <ø> (+36.36%)` | :arrow_up: |
| [...tasourcePanel/DatasourcePanelDragWrapper/index.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvRGF0YXNvdXJjZVBhbmVsRHJhZ1dyYXBwZXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...components/controls/FilterBoxItemControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC9pbmRleC5qc3g=) | `13.20% <0.00%> (ø)` | |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `100.00% <ø> (+36.36%)` | :arrow_up: |
| ... and [26 more](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=footer). Last update [5b79f84...1134fda](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #13753: test: FilterBoxItemControl
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13753:
URL: https://github.com/apache/superset/pull/13753#issuecomment-813603385
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13753: test: FilterBoxItemControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13753:
URL: https://github.com/apache/superset/pull/13753#issuecomment-805299806
# [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=h1) Report
> Merging [#13753](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=desc) (df9bf5e) into [master](https://codecov.io/gh/apache/superset/commit/5b79f84e1ba2feab10bc9b96fd786d82418b7b4a?el=desc) (5b79f84) will **decrease** coverage by `1.17%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13753 +/- ##
==========================================
- Coverage 77.45% 76.28% -1.18%
==========================================
Files 933 937 +4
Lines 47144 47770 +626
Branches 5848 6028 +180
==========================================
- Hits 36516 36440 -76
- Misses 10485 11175 +690
- Partials 143 155 +12
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.32% <ø> (+1.97%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...components/controls/FilterBoxItemControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC9pbmRleC5qc3g=) | `13.20% <ø> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC50c3g=) | `47.16% <0.00%> (-33.97%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `63.49% <0.00%> (-33.88%)` | :arrow_down: |
| [superset-frontend/src/middleware/asyncEvent.ts](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvYXN5bmNFdmVudC50cw==) | `53.54% <0.00%> (-33.80%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `47.24% <0.00%> (-33.58%)` | :arrow_down: |
| [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | `71.87% <0.00%> (-28.13%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `37.50% <0.00%> (-26.14%)` | :arrow_down: |
| ... and [46 more](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=footer). Last update [5b79f84...df9bf5e](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #13753: test: FilterBoxItemControl
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13753:
URL: https://github.com/apache/superset/pull/13753#issuecomment-810882594
@junlincc Ephemeral environment spinning up at http://52.35.224.124:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13753: test: FilterBoxItemControl
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13753:
URL: https://github.com/apache/superset/pull/13753#issuecomment-810573647
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13753: test: FilterBoxItemControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13753:
URL: https://github.com/apache/superset/pull/13753#issuecomment-805299806
# [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=h1) Report
> Merging [#13753](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=desc) (82455f2) into [master](https://codecov.io/gh/apache/superset/commit/5b79f84e1ba2feab10bc9b96fd786d82418b7b4a?el=desc) (5b79f84) will **decrease** coverage by `0.82%`.
> The diff coverage is `51.41%`.
> :exclamation: Current head 82455f2 differs from pull request most recent head 1134fda. Consider uploading reports for the commit 1134fda to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13753 +/- ##
==========================================
- Coverage 77.45% 76.62% -0.83%
==========================================
Files 933 938 +5
Lines 47144 47859 +715
Branches 5848 6067 +219
==========================================
+ Hits 36516 36674 +158
- Misses 10485 11037 +552
- Partials 143 148 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.97% <26.94%> (-0.37%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `48.59% <ø> (-15.79%)` | :arrow_down: |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `16.66% <ø> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `96.42% <ø> (ø)` | |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `40.00% <ø> (-23.64%)` | :arrow_down: |
| [...tasourcePanel/DatasourcePanelDragWrapper/index.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvRGF0YXNvdXJjZVBhbmVsRHJhZ1dyYXBwZXIvaW5kZXgudHN4) | `16.66% <ø> (ø)` | |
| [...components/controls/FilterBoxItemControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC9pbmRleC5qc3g=) | `13.20% <0.00%> (ø)` | |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `37.50% <ø> (-26.14%)` | :arrow_down: |
| ... and [34 more](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=footer). Last update [5b79f84...1134fda](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13753: test: FilterBoxItemControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13753:
URL: https://github.com/apache/superset/pull/13753#issuecomment-805299806
# [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=h1) Report
> Merging [#13753](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=desc) (a21a1a5) into [master](https://codecov.io/gh/apache/superset/commit/5b79f84e1ba2feab10bc9b96fd786d82418b7b4a?el=desc) (5b79f84) will **decrease** coverage by `0.98%`.
> The diff coverage is `73.25%`.
> :exclamation: Current head a21a1a5 differs from pull request most recent head df9bf5e. Consider uploading reports for the commit df9bf5e to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13753 +/- ##
==========================================
- Coverage 77.45% 76.46% -0.99%
==========================================
Files 933 935 +2
Lines 47144 47302 +158
Branches 5848 5899 +51
==========================================
- Hits 36516 36171 -345
- Misses 10485 10968 +483
- Partials 143 163 +20
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `63.75% <70.56%> (+0.28%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `63.38% <ø> (-1.01%)` | :arrow_down: |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/components/FormLabel/index.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRm9ybUxhYmVsL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `84.92% <ø> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `96.42% <ø> (ø)` | |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `100.00% <ø> (+2.63%)` | :arrow_up: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `100.00% <ø> (+36.36%)` | :arrow_up: |
| ... and [92 more](https://codecov.io/gh/apache/superset/pull/13753/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=footer). Last update [5b79f84...df9bf5e](https://codecov.io/gh/apache/superset/pull/13753?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #13753: test: FilterBoxItemControl
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #13753:
URL: https://github.com/apache/superset/pull/13753#discussion_r600445209
##########
File path: superset-frontend/src/explore/components/controls/FilterBoxItemControl/FilterBoxItemControl.test.tsx
##########
@@ -0,0 +1,78 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React from 'react';
+import { render, screen } from 'spec/helpers/testing-library';
+import userEvent from '@testing-library/user-event';
+import FilterBoxItemControl from '.';
+
+const datasource = {
+ columns: [],
+ metrics: [],
+};
+
+let props = {
Review comment:
Do you really need `beforeEach` for this case? It seems that the properties are not being modified by test cases so we could use a constant like `datasource`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #13753: test: FilterBoxItemControl
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #13753:
URL: https://github.com/apache/superset/pull/13753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yardz commented on a change in pull request #13753: test: FilterBoxItemControl
Posted by GitBox <gi...@apache.org>.
yardz commented on a change in pull request #13753:
URL: https://github.com/apache/superset/pull/13753#discussion_r600729737
##########
File path: superset-frontend/src/explore/components/controls/FilterBoxItemControl/FilterBoxItemControl.test.tsx
##########
@@ -0,0 +1,78 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React from 'react';
+import { render, screen } from 'spec/helpers/testing-library';
+import userEvent from '@testing-library/user-event';
+import FilterBoxItemControl from '.';
+
+const datasource = {
+ columns: [],
+ metrics: [],
+};
+
+let props = {
Review comment:
Since many of these functions have no tests and we have nothing guaranteeing immutability, I prefer to redefine the props for all executions. It is the only way to ensure that it is in fact the prop that is being used.
As we do not have many backers, I prefer to follow a more conservative path and ensure that I am in fact testing what I think I am testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org