You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Stanislav Lukyanov <st...@gmail.com> on 2018/07/18 13:32:07 UTC
Pushing IGNITE-6826 forward
Hi Igniters,
There is a small but annoying issue with examples using MulticastIpFinder by default.
The JIRA is IGNITE-6826.
AntonK and DmitriiR have suggested PRs to fix this, but PavelT had some concerns and the fix stuck as the result.
Pavel, could you please suggest necessary changes to the PRs so that guys can move forward with integration?
Thanks,
Stan
Re: Pushing forward IGNITE-6826: Change default DiscoverySpi ipFinder
type for examples
Posted by Dmitriy Pavlov <dp...@gmail.com>.
Hi Stan,
any news on this?
Sincerely
пт, 20 июл. 2018 г., 4:12 Dmitriy Setrakyan <ds...@apache.org>:
> Why not use a combination of Multicast and VM finders? This way we do not
> have to make any sacrifices.
>
> D.
>
> On Wed, Jul 18, 2018 at 9:38 PM, Vladimir Ozerov <vo...@gridgain.com>
> wrote:
>
> > TcpDiscoveryVmIpFinder can be configured with 127.0.0.1. Example with
> > remote nodes will work fine on a single machine. Users rarely run
> examples
> > on multiple machines.
> >
> > чт, 19 июля 2018 г. в 5:30, Dmitriy Setrakyan <ds...@apache.org>:
> >
> > > I am confused, the TcpDiscoveryVmIpFinder will only discover nodes with
> > > specified list of IPs. Don't we have examples that require remote nodes
> > to
> > > join?
> > >
> > > D.
> > >
> > > On Wed, Jul 18, 2018 at 7:52 AM, Stanislav Lukyanov <
> > > stanlukyanov@gmail.com>
> > > wrote:
> > >
> > > > > It can seem not important, but saves a minute for everyone.
> > > > No, it actually does seem important when you think about it :) Thanks
> > for
> > > > the suggestion.
> > > > Let me correct this then.
> > > >
> > > > The issue is
> > > > IGNITE-6826: Change default DiscoverySpi ipFinder type for examples
> > > > https://issues.apache.org/jira/browse/IGNITE-6826
> > > > It is about changing the ipFinders used in the Ignite examples from
> > > > TcpDiscoveryMulticastIpFinder to TcpDiscoveryVmIpFinder.
> > > >
> > > > Thanks,
> > > > Stan
> > > >
> > > > From: Dmitry Pavlov
> > > > Sent: 18 июля 2018 г. 17:30
> > > > To: dev@ignite.apache.org
> > > > Cc: antkr.dev@gmail.com; SomeFireOne@gmail.com; ptupitsyn@apache.org
> > > > Subject: Re: Pushing IGNITE-6826 forward
> > > >
> > > > Hi Stanislav,
> > > >
> > > > I wish this push will have effect.
> > > >
> > > > Just two proposals that will help Igniters to easily jump into such
> > > emails:
> > > > 1. Include ticket short description into subject, not only number.
> > > > 2. Include link to JIRA issue into body so it could be easily clicked
> > to
> > > > find out details.
> > > > It can seem not important, but saves a minute for everyone.
> > > >
> > > > Sincerely,
> > > > Dmitriy Pavlov
> > > >
> > > > ср, 18 июл. 2018 г. в 16:32, Stanislav Lukyanov <
> > stanlukyanov@gmail.com
> > > >:
> > > >
> > > > > Hi Igniters,
> > > > >
> > > > > There is a small but annoying issue with examples using
> > > MulticastIpFinder
> > > > > by default.
> > > > > The JIRA is IGNITE-6826.
> > > > >
> > > > > AntonK and DmitriiR have suggested PRs to fix this, but PavelT had
> > some
> > > > > concerns and the fix stuck as the result.
> > > > >
> > > > > Pavel, could you please suggest necessary changes to the PRs so
> that
> > > guys
> > > > > can move forward with integration?
> > > > >
> > > > > Thanks,
> > > > > Stan
> > > > >
> > > >
> > > >
> > >
> >
>
Re: Pushing forward IGNITE-6826: Change default DiscoverySpi ipFinder
type for examples
Posted by Dmitriy Setrakyan <ds...@apache.org>.
Why not use a combination of Multicast and VM finders? This way we do not
have to make any sacrifices.
D.
On Wed, Jul 18, 2018 at 9:38 PM, Vladimir Ozerov <vo...@gridgain.com>
wrote:
> TcpDiscoveryVmIpFinder can be configured with 127.0.0.1. Example with
> remote nodes will work fine on a single machine. Users rarely run examples
> on multiple machines.
>
> чт, 19 июля 2018 г. в 5:30, Dmitriy Setrakyan <ds...@apache.org>:
>
> > I am confused, the TcpDiscoveryVmIpFinder will only discover nodes with
> > specified list of IPs. Don't we have examples that require remote nodes
> to
> > join?
> >
> > D.
> >
> > On Wed, Jul 18, 2018 at 7:52 AM, Stanislav Lukyanov <
> > stanlukyanov@gmail.com>
> > wrote:
> >
> > > > It can seem not important, but saves a minute for everyone.
> > > No, it actually does seem important when you think about it :) Thanks
> for
> > > the suggestion.
> > > Let me correct this then.
> > >
> > > The issue is
> > > IGNITE-6826: Change default DiscoverySpi ipFinder type for examples
> > > https://issues.apache.org/jira/browse/IGNITE-6826
> > > It is about changing the ipFinders used in the Ignite examples from
> > > TcpDiscoveryMulticastIpFinder to TcpDiscoveryVmIpFinder.
> > >
> > > Thanks,
> > > Stan
> > >
> > > From: Dmitry Pavlov
> > > Sent: 18 июля 2018 г. 17:30
> > > To: dev@ignite.apache.org
> > > Cc: antkr.dev@gmail.com; SomeFireOne@gmail.com; ptupitsyn@apache.org
> > > Subject: Re: Pushing IGNITE-6826 forward
> > >
> > > Hi Stanislav,
> > >
> > > I wish this push will have effect.
> > >
> > > Just two proposals that will help Igniters to easily jump into such
> > emails:
> > > 1. Include ticket short description into subject, not only number.
> > > 2. Include link to JIRA issue into body so it could be easily clicked
> to
> > > find out details.
> > > It can seem not important, but saves a minute for everyone.
> > >
> > > Sincerely,
> > > Dmitriy Pavlov
> > >
> > > ср, 18 июл. 2018 г. в 16:32, Stanislav Lukyanov <
> stanlukyanov@gmail.com
> > >:
> > >
> > > > Hi Igniters,
> > > >
> > > > There is a small but annoying issue with examples using
> > MulticastIpFinder
> > > > by default.
> > > > The JIRA is IGNITE-6826.
> > > >
> > > > AntonK and DmitriiR have suggested PRs to fix this, but PavelT had
> some
> > > > concerns and the fix stuck as the result.
> > > >
> > > > Pavel, could you please suggest necessary changes to the PRs so that
> > guys
> > > > can move forward with integration?
> > > >
> > > > Thanks,
> > > > Stan
> > > >
> > >
> > >
> >
>
Re: Pushing forward IGNITE-6826: Change default DiscoverySpi ipFinder
type for examples
Posted by Vladimir Ozerov <vo...@gridgain.com>.
TcpDiscoveryVmIpFinder can be configured with 127.0.0.1. Example with
remote nodes will work fine on a single machine. Users rarely run examples
on multiple machines.
чт, 19 июля 2018 г. в 5:30, Dmitriy Setrakyan <ds...@apache.org>:
> I am confused, the TcpDiscoveryVmIpFinder will only discover nodes with
> specified list of IPs. Don't we have examples that require remote nodes to
> join?
>
> D.
>
> On Wed, Jul 18, 2018 at 7:52 AM, Stanislav Lukyanov <
> stanlukyanov@gmail.com>
> wrote:
>
> > > It can seem not important, but saves a minute for everyone.
> > No, it actually does seem important when you think about it :) Thanks for
> > the suggestion.
> > Let me correct this then.
> >
> > The issue is
> > IGNITE-6826: Change default DiscoverySpi ipFinder type for examples
> > https://issues.apache.org/jira/browse/IGNITE-6826
> > It is about changing the ipFinders used in the Ignite examples from
> > TcpDiscoveryMulticastIpFinder to TcpDiscoveryVmIpFinder.
> >
> > Thanks,
> > Stan
> >
> > From: Dmitry Pavlov
> > Sent: 18 июля 2018 г. 17:30
> > To: dev@ignite.apache.org
> > Cc: antkr.dev@gmail.com; SomeFireOne@gmail.com; ptupitsyn@apache.org
> > Subject: Re: Pushing IGNITE-6826 forward
> >
> > Hi Stanislav,
> >
> > I wish this push will have effect.
> >
> > Just two proposals that will help Igniters to easily jump into such
> emails:
> > 1. Include ticket short description into subject, not only number.
> > 2. Include link to JIRA issue into body so it could be easily clicked to
> > find out details.
> > It can seem not important, but saves a minute for everyone.
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > ср, 18 июл. 2018 г. в 16:32, Stanislav Lukyanov <stanlukyanov@gmail.com
> >:
> >
> > > Hi Igniters,
> > >
> > > There is a small but annoying issue with examples using
> MulticastIpFinder
> > > by default.
> > > The JIRA is IGNITE-6826.
> > >
> > > AntonK and DmitriiR have suggested PRs to fix this, but PavelT had some
> > > concerns and the fix stuck as the result.
> > >
> > > Pavel, could you please suggest necessary changes to the PRs so that
> guys
> > > can move forward with integration?
> > >
> > > Thanks,
> > > Stan
> > >
> >
> >
>
Re: Pushing forward IGNITE-6826: Change default DiscoverySpi ipFinder
type for examples
Posted by Dmitriy Setrakyan <ds...@apache.org>.
I am confused, the TcpDiscoveryVmIpFinder will only discover nodes with
specified list of IPs. Don't we have examples that require remote nodes to
join?
D.
On Wed, Jul 18, 2018 at 7:52 AM, Stanislav Lukyanov <st...@gmail.com>
wrote:
> > It can seem not important, but saves a minute for everyone.
> No, it actually does seem important when you think about it :) Thanks for
> the suggestion.
> Let me correct this then.
>
> The issue is
> IGNITE-6826: Change default DiscoverySpi ipFinder type for examples
> https://issues.apache.org/jira/browse/IGNITE-6826
> It is about changing the ipFinders used in the Ignite examples from
> TcpDiscoveryMulticastIpFinder to TcpDiscoveryVmIpFinder.
>
> Thanks,
> Stan
>
> From: Dmitry Pavlov
> Sent: 18 июля 2018 г. 17:30
> To: dev@ignite.apache.org
> Cc: antkr.dev@gmail.com; SomeFireOne@gmail.com; ptupitsyn@apache.org
> Subject: Re: Pushing IGNITE-6826 forward
>
> Hi Stanislav,
>
> I wish this push will have effect.
>
> Just two proposals that will help Igniters to easily jump into such emails:
> 1. Include ticket short description into subject, not only number.
> 2. Include link to JIRA issue into body so it could be easily clicked to
> find out details.
> It can seem not important, but saves a minute for everyone.
>
> Sincerely,
> Dmitriy Pavlov
>
> ср, 18 июл. 2018 г. в 16:32, Stanislav Lukyanov <st...@gmail.com>:
>
> > Hi Igniters,
> >
> > There is a small but annoying issue with examples using MulticastIpFinder
> > by default.
> > The JIRA is IGNITE-6826.
> >
> > AntonK and DmitriiR have suggested PRs to fix this, but PavelT had some
> > concerns and the fix stuck as the result.
> >
> > Pavel, could you please suggest necessary changes to the PRs so that guys
> > can move forward with integration?
> >
> > Thanks,
> > Stan
> >
>
>
RE: Pushing forward IGNITE-6826: Change default DiscoverySpi
ipFinder type for examples
Posted by Stanislav Lukyanov <st...@gmail.com>.
> It can seem not important, but saves a minute for everyone.
No, it actually does seem important when you think about it :) Thanks for the suggestion.
Let me correct this then.
The issue is
IGNITE-6826: Change default DiscoverySpi ipFinder type for examples
https://issues.apache.org/jira/browse/IGNITE-6826
It is about changing the ipFinders used in the Ignite examples from TcpDiscoveryMulticastIpFinder to TcpDiscoveryVmIpFinder.
Thanks,
Stan
From: Dmitry Pavlov
Sent: 18 июля 2018 г. 17:30
To: dev@ignite.apache.org
Cc: antkr.dev@gmail.com; SomeFireOne@gmail.com; ptupitsyn@apache.org
Subject: Re: Pushing IGNITE-6826 forward
Hi Stanislav,
I wish this push will have effect.
Just two proposals that will help Igniters to easily jump into such emails:
1. Include ticket short description into subject, not only number.
2. Include link to JIRA issue into body so it could be easily clicked to
find out details.
It can seem not important, but saves a minute for everyone.
Sincerely,
Dmitriy Pavlov
ср, 18 июл. 2018 г. в 16:32, Stanislav Lukyanov <st...@gmail.com>:
> Hi Igniters,
>
> There is a small but annoying issue with examples using MulticastIpFinder
> by default.
> The JIRA is IGNITE-6826.
>
> AntonK and DmitriiR have suggested PRs to fix this, but PavelT had some
> concerns and the fix stuck as the result.
>
> Pavel, could you please suggest necessary changes to the PRs so that guys
> can move forward with integration?
>
> Thanks,
> Stan
>
Re: Pushing IGNITE-6826 forward
Posted by Dmitriy Setrakyan <ds...@apache.org>.
Why can't we use a combination of both, VM and Multicast IP finders?
D.
On Thu, Jul 19, 2018 at 8:28 AM, Stanislav Lukyanov <st...@gmail.com>
wrote:
> Yakov,
>
> First, it doesn’t seem likely that many people would run examples on
> several machines. Even if someone would, they’d probably start doing so
> after some experimentation with a single host – at the moment when they’re
> already adjusted enough to check and edit some configs.
>
> Second, I don’t think that this use case outweighs the troubles new (and
> even experienced) users get because of the multicast.
> Even if it helps some users to get started in their first 30 minutes with
> Ignite, it will just as well confuse them later and leave a feeling of
> unstable product.
>
> Showing a warning with default settings is confusing – a user didn’t do
> anything wrong, and still we smack their hand with a warning.
> I believe we should use warnings for erroneous conditions only.
>
> Thanks,
> Stan
>
> From: Yakov Zhdanov
> Sent: 19 июля 2018 г. 16:54
> To: dev@ignite.apache.org
> Cc: antkr.dev@gmail.com; SomeFireOne@gmail.com; ptupitsyn@apache.org
> Subject: Re: Pushing IGNITE-6826 forward
>
> Guys, multicast IP finder gives new user an opportunity to run tests on
> several machines with zero config changes. And you want to change this
> which is not good in my view.
>
> Probably, we need to output warning pointing that user can change multicast
> group to avoid undesired discovery and isolate several clusters in the same
> network.
>
> --Yakov
>
> 2018-07-18 17:30 GMT+03:00 Dmitry Pavlov <dp...@gmail.com>:
>
> > Hi Stanislav,
> >
> > I wish this push will have effect.
> >
> > Just two proposals that will help Igniters to easily jump into such
> emails:
> > 1. Include ticket short description into subject, not only number.
> > 2. Include link to JIRA issue into body so it could be easily clicked to
> > find out details.
> > It can seem not important, but saves a minute for everyone.
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > ср, 18 июл. 2018 г. в 16:32, Stanislav Lukyanov <stanlukyanov@gmail.com
> >:
> >
> > > Hi Igniters,
> > >
> > > There is a small but annoying issue with examples using
> MulticastIpFinder
> > > by default.
> > > The JIRA is IGNITE-6826.
> > >
> > > AntonK and DmitriiR have suggested PRs to fix this, but PavelT had some
> > > concerns and the fix stuck as the result.
> > >
> > > Pavel, could you please suggest necessary changes to the PRs so that
> guys
> > > can move forward with integration?
> > >
> > > Thanks,
> > > Stan
> > >
> >
>
>
RE: Pushing IGNITE-6826 forward
Posted by Stanislav Lukyanov <st...@gmail.com>.
Yakov,
First, it doesn’t seem likely that many people would run examples on several machines. Even if someone would, they’d probably start doing so after some experimentation with a single host – at the moment when they’re already adjusted enough to check and edit some configs.
Second, I don’t think that this use case outweighs the troubles new (and even experienced) users get because of the multicast.
Even if it helps some users to get started in their first 30 minutes with Ignite, it will just as well confuse them later and leave a feeling of unstable product.
Showing a warning with default settings is confusing – a user didn’t do anything wrong, and still we smack their hand with a warning.
I believe we should use warnings for erroneous conditions only.
Thanks,
Stan
From: Yakov Zhdanov
Sent: 19 июля 2018 г. 16:54
To: dev@ignite.apache.org
Cc: antkr.dev@gmail.com; SomeFireOne@gmail.com; ptupitsyn@apache.org
Subject: Re: Pushing IGNITE-6826 forward
Guys, multicast IP finder gives new user an opportunity to run tests on
several machines with zero config changes. And you want to change this
which is not good in my view.
Probably, we need to output warning pointing that user can change multicast
group to avoid undesired discovery and isolate several clusters in the same
network.
--Yakov
2018-07-18 17:30 GMT+03:00 Dmitry Pavlov <dp...@gmail.com>:
> Hi Stanislav,
>
> I wish this push will have effect.
>
> Just two proposals that will help Igniters to easily jump into such emails:
> 1. Include ticket short description into subject, not only number.
> 2. Include link to JIRA issue into body so it could be easily clicked to
> find out details.
> It can seem not important, but saves a minute for everyone.
>
> Sincerely,
> Dmitriy Pavlov
>
> ср, 18 июл. 2018 г. в 16:32, Stanislav Lukyanov <st...@gmail.com>:
>
> > Hi Igniters,
> >
> > There is a small but annoying issue with examples using MulticastIpFinder
> > by default.
> > The JIRA is IGNITE-6826.
> >
> > AntonK and DmitriiR have suggested PRs to fix this, but PavelT had some
> > concerns and the fix stuck as the result.
> >
> > Pavel, could you please suggest necessary changes to the PRs so that guys
> > can move forward with integration?
> >
> > Thanks,
> > Stan
> >
>
Re: Pushing IGNITE-6826 forward
Posted by Yakov Zhdanov <yz...@apache.org>.
Guys, multicast IP finder gives new user an opportunity to run tests on
several machines with zero config changes. And you want to change this
which is not good in my view.
Probably, we need to output warning pointing that user can change multicast
group to avoid undesired discovery and isolate several clusters in the same
network.
--Yakov
2018-07-18 17:30 GMT+03:00 Dmitry Pavlov <dp...@gmail.com>:
> Hi Stanislav,
>
> I wish this push will have effect.
>
> Just two proposals that will help Igniters to easily jump into such emails:
> 1. Include ticket short description into subject, not only number.
> 2. Include link to JIRA issue into body so it could be easily clicked to
> find out details.
> It can seem not important, but saves a minute for everyone.
>
> Sincerely,
> Dmitriy Pavlov
>
> ср, 18 июл. 2018 г. в 16:32, Stanislav Lukyanov <st...@gmail.com>:
>
> > Hi Igniters,
> >
> > There is a small but annoying issue with examples using MulticastIpFinder
> > by default.
> > The JIRA is IGNITE-6826.
> >
> > AntonK and DmitriiR have suggested PRs to fix this, but PavelT had some
> > concerns and the fix stuck as the result.
> >
> > Pavel, could you please suggest necessary changes to the PRs so that guys
> > can move forward with integration?
> >
> > Thanks,
> > Stan
> >
>
Re: Pushing IGNITE-6826 forward
Posted by Dmitry Pavlov <dp...@gmail.com>.
Hi Stanislav,
I wish this push will have effect.
Just two proposals that will help Igniters to easily jump into such emails:
1. Include ticket short description into subject, not only number.
2. Include link to JIRA issue into body so it could be easily clicked to
find out details.
It can seem not important, but saves a minute for everyone.
Sincerely,
Dmitriy Pavlov
ср, 18 июл. 2018 г. в 16:32, Stanislav Lukyanov <st...@gmail.com>:
> Hi Igniters,
>
> There is a small but annoying issue with examples using MulticastIpFinder
> by default.
> The JIRA is IGNITE-6826.
>
> AntonK and DmitriiR have suggested PRs to fix this, but PavelT had some
> concerns and the fix stuck as the result.
>
> Pavel, could you please suggest necessary changes to the PRs so that guys
> can move forward with integration?
>
> Thanks,
> Stan
>