You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by dawidwys <gi...@git.apache.org> on 2015/10/06 20:28:59 UTC
[GitHub] flink pull request: [FLINK-2156] Scala modules cannot create loggi...
GitHub user dawidwys opened a pull request:
https://github.com/apache/flink/pull/1234
[FLINK-2156] Scala modules cannot create logging file
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dawidwys/flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1234.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1234
----
commit aabb9a9d47450b0fa3ed01e88fd4e3645d2462da
Author: dawid <da...@gmail.com>
Date: 2015-10-06T17:08:06Z
[FLINK-2156] Scala modules cannot create logging file
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2156] Scala modules cannot create loggi...
Posted by chiwanpark <gi...@git.apache.org>.
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1234#issuecomment-146465380
If we need to parallelize tests run by scalatest, the test cases should extend [ParallelTestExecution](http://doc.scalatest.org/2.2.4/index.html#org.scalatest.ParallelTestExecution).
But I think that we don't need to parallelize test yet.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2156] Scala modules cannot create loggi...
Posted by chiwanpark <gi...@git.apache.org>.
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1234#issuecomment-146578397
@StephanEwen I think so.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2156] Scala modules cannot create loggi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1234
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2156] Scala modules cannot create loggi...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1234#issuecomment-146449913
FlinkML uses scalatest to run its tests. Scalatest didn't use the fork
number and simply executed all tests sequentially. This shouldn't be a big
problem, because there are only few tests to run.
On Oct 7, 2015 9:13 PM, "Stephan Ewen" <no...@github.com> wrote:
> We do execute multiple tests concurrently (multiple forks). Does this lead
> to problems when all forks see the fork number "1" ? I am wondering,
> because at some places, we use the fork number to prevent port conflicts.
>
> Then again, how could these parts have worked before when the fork number
> was missing in the first place?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/flink/pull/1234#issuecomment-146299251>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2156] Scala modules cannot create loggi...
Posted by chiwanpark <gi...@git.apache.org>.
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1234#issuecomment-146275842
Hi @dawidwys, Thanks for opening pull request.
Your pull request looks good to merge. This PR will be merged in few days if there is no objection.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2156] Scala modules cannot create loggi...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1234#issuecomment-146578211
Ah, I see. Then the change looks good, correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2156] Scala modules cannot create loggi...
Posted by chiwanpark <gi...@git.apache.org>.
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1234#issuecomment-146891720
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2156] Scala modules cannot create loggi...
Posted by chiwanpark <gi...@git.apache.org>.
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1234#issuecomment-146277055
BTW, because your PR is based on your master branch, not topic branch, you should [overwrite master branch in your repository](http://stackoverflow.com/questions/1125968/force-git-to-overwrite-local-files-on-pull) after this PR is merged.
Creating a topic branch and sending pull request based on the branch are commonly recommended. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2156] Scala modules cannot create loggi...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1234#issuecomment-146299251
We do execute multiple tests concurrently (multiple forks). Does this lead to problems when all forks see the fork number "1" ? I am wondering, because at some places, we use the fork number to prevent port conflicts.
Then again, how could these parts have worked before when the fork number was missing in the first place?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---