You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/02/06 23:51:42 UTC

[kudu-CR](branch-1.9.x) [fs manager-test] fix tests for macOS 

Hello Kudu Jenkins, Andrew Wong,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/12390

to review the following change.


Change subject: [fs_manager-test] fix tests for macOS
......................................................................

[fs_manager-test] fix tests for macOS

As it turned out, it's been a while since the fs_manager-test started
failing.  In changelist b2f690d5 some changes were introduced
so one test started failing, and later on, with changelist 006937d3
the total number of failing tests on macOS grew up to three in total.

The reason behind the failures is simple: on macOS the only
block manager is FileBlockManager and it doesn't support many of
the operations exercised in the tests scenarios that started
failing.  This patch short-circuits those scenarios so they now
pass on macOS.

Change-Id: I19a8c6f48435bf5424500c86283490c9fed408f4
Reviewed-on: http://gerrit.cloudera.org:8080/12383
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit a8367e862d5a71d920cbc94ea58d3bf5135418c6)
---
M src/kudu/fs/fs_manager-test.cc
1 file changed, 40 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/12390/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I19a8c6f48435bf5424500c86283490c9fed408f4
Gerrit-Change-Number: 12390
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.9.x) [fs manager-test] fix tests for macOS

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12390 )

Change subject: [fs_manager-test] fix tests for macOS
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I19a8c6f48435bf5424500c86283490c9fed408f4
Gerrit-Change-Number: 12390
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 06 Feb 2019 23:53:43 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.9.x) [fs manager-test] fix tests for macOS

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12390 )

Change subject: [fs_manager-test] fix tests for macOS
......................................................................

[fs_manager-test] fix tests for macOS

As it turned out, it's been a while since the fs_manager-test started
failing.  In changelist b2f690d5 some changes were introduced
so one test started failing, and later on, with changelist 006937d3
the total number of failing tests on macOS grew up to three in total.

The reason behind the failures is simple: on macOS the only
block manager is FileBlockManager and it doesn't support many of
the operations exercised in the tests scenarios that started
failing.  This patch short-circuits those scenarios so they now
pass on macOS.

Change-Id: I19a8c6f48435bf5424500c86283490c9fed408f4
Reviewed-on: http://gerrit.cloudera.org:8080/12383
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit a8367e862d5a71d920cbc94ea58d3bf5135418c6)
Reviewed-on: http://gerrit.cloudera.org:8080/12390
---
M src/kudu/fs/fs_manager-test.cc
1 file changed, 40 insertions(+), 6 deletions(-)

Approvals:
  Andrew Wong: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/12390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I19a8c6f48435bf5424500c86283490c9fed408f4
Gerrit-Change-Number: 12390
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)