You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by codecov on 2023/01/31 16:54:37 UTC
[GitHub] [cloudstack] codecov[bot] commented on pull request #7151: UI: fix missing networkid and zoneid when add instance from vpc network
codecov[bot] commented on PR #7151:
URL: https://github.com/apache/cloudstack/pull/7151#issuecomment-1410736275
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7151?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7151](https://codecov.io/gh/apache/cloudstack/pull/7151?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a470274) into [4.17](https://codecov.io/gh/apache/cloudstack/commit/ca7e1ac1abbe78513bfdd57b990d58e018f8d65d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ca7e1ac) will **decrease** coverage by `0.95%`.
> The diff coverage is `23.23%`.
```diff
@@ Coverage Diff @@
## 4.17 #7151 +/- ##
============================================
- Coverage 11.31% 10.37% -0.95%
+ Complexity 7334 6647 -687
============================================
Files 2494 2453 -41
Lines 246787 242437 -4350
Branches 38533 37938 -595
============================================
- Hits 27933 25151 -2782
+ Misses 215255 214177 -1078
+ Partials 3599 3109 -490
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7151?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../src/main/java/com/cloud/host/dao/HostDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7151?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9ob3N0L2Rhby9Ib3N0RGFvSW1wbC5qYXZh) | `28.43% <0.00%> (-0.47%)` | :arrow_down: |
| [...main/java/com/cloud/service/ServiceOfferingVO.java](https://codecov.io/gh/apache/cloudstack/pull/7151?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9zZXJ2aWNlL1NlcnZpY2VPZmZlcmluZ1ZPLmphdmE=) | `38.84% <0.00%> (+2.15%)` | :arrow_up: |
| [.../actionworkers/KubernetesClusterDestroyWorker.java](https://codecov.io/gh/apache/cloudstack/pull/7151?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9pbnRlZ3JhdGlvbnMva3ViZXJuZXRlcy1zZXJ2aWNlL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2t1YmVybmV0ZXMvY2x1c3Rlci9hY3Rpb253b3JrZXJzL0t1YmVybmV0ZXNDbHVzdGVyRGVzdHJveVdvcmtlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../apache/cloudstack/metrics/MetricsServiceImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7151?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL21ldHJpY3MvTWV0cmljc1NlcnZpY2VJbXBsLmphdmE=) | `14.94% <0.00%> (ø)` | |
| [.../apache/cloudstack/response/DbMetricsResponse.java](https://codecov.io/gh/apache/cloudstack/pull/7151?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3Jlc3BvbnNlL0RiTWV0cmljc1Jlc3BvbnNlLmphdmE=) | `0.00% <ø> (ø)` | |
| [...pache/cloudstack/ldap/OpenLdapUserManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7151?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy91c2VyLWF1dGhlbnRpY2F0b3JzL2xkYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbGRhcC9PcGVuTGRhcFVzZXJNYW5hZ2VySW1wbC5qYXZh) | `3.26% <0.00%> (ø)` | |
| [...src/main/java/com/cloud/api/ApiResponseHelper.java](https://codecov.io/gh/apache/cloudstack/pull/7151?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2FwaS9BcGlSZXNwb25zZUhlbHBlci5qYXZh) | `2.46% <0.00%> (-1.42%)` | :arrow_down: |
| [.../cloud/configuration/ConfigurationManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7151?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2NvbmZpZ3VyYXRpb24vQ29uZmlndXJhdGlvbk1hbmFnZXJJbXBsLmphdmE=) | `10.84% <0.00%> (-1.65%)` | :arrow_down: |
| [...rvisor/kvm/discoverer/LibvirtServerDiscoverer.java](https://codecov.io/gh/apache/cloudstack/pull/7151?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2h5cGVydmlzb3Iva3ZtL2Rpc2NvdmVyZXIvTGlidmlydFNlcnZlckRpc2NvdmVyZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../main/java/com/cloud/network/NetworkModelImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7151?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL25ldHdvcmsvTmV0d29ya01vZGVsSW1wbC5qYXZh) | `9.92% <0.00%> (-1.31%)` | :arrow_down: |
| ... and [355 more](https://codecov.io/gh/apache/cloudstack/pull/7151?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org