[GitHub] [airflow] dstandish commented on a change in pull request #6376: [AIRFLOW-5705] Add creds backend and support for AWS SSM

[GitBox <gi...@apache.org>]

dstandish commented on a change in pull request #6376: [AIRFLOW-5705] Add creds backend and support for AWS SSM
URL: https://github.com/apache/airflow/pull/6376#discussion_r389202690
 
 

 ##########
 File path: airflow/config_templates/config.yml
 ##########
 @@ -463,6 +463,15 @@
       type: string
       example: ~
       default: "task"
+    - name: creds_backend
+      description: |
+        Classes to use for creds backend
+      version_added: ~
+      type: string
+      example: ~
+      default: >-
+        airflow.creds.environment_variables.EnvironmentVariablesCredsBackend,
+        airflow.creds.metastore.MetastoreCredsBackend
 
 Review comment:
   so... i struggled with this a bit myself.
   
   i can call it `BaseConnectionBackend` if that's the general consensus -- not firmly attached to _creds_.
   
   as to why though, i wrestled with it a bit myself.  but i guess i thought creds was a more apt description of what this does.  this is not really fetching connections per se but connection _meta_ or connection _info_ or plainly _creds_.  it is a backend for getting creds from arbitrary creds store, and it provides a way to yield connections from those creds.
   
   and why creds instead of _credentials_? 
   
   when you can have economy _and_ clarity at the same time, why not?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services