You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "abhishekrb19 (via GitHub)" <gi...@apache.org> on 2023/02/20 07:13:47 UTC
[GitHub] [druid] abhishekrb19 opened a new pull request, #13826: Add `ANSI_QUOTES` mode to DBI init in lookups.
abhishekrb19 opened a new pull request, #13826:
URL: https://github.com/apache/druid/pull/13826
### Description
Previous change https://github.com/apache/druid/pull/13632 added double quotes to quote identifiers in JDBC lookups per the SQL standard. However, that only works with databases like PostgresDB and Derby that use double quotes. On the other hand, MySQL and MariaDB use the backtick character to quote identifiers by default. This change-set enables the `ANSI_SQL` mode per JDBC connection/session so we can write SQL that works with most SQL-compliant databases. It has been tested manually on the different supported databases. UTs that use the Derby connector were already modified in the previous change test this functionality implicitly.
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition, design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design (or naming) decision point and compare the alternatives with the designs that you've implemented (or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere (e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list), link to that discussion from this PR description and explain what have changed in your final design compared to your original proposal or the consensus version in the end of the discussion. If something hasn't changed since the original discussion, you can omit a detailed discussion of those aspects of the design here, perhaps apart from brief mentioning for the sake of readability of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
<!-- Give your best effort to summarize your changes in a couple of sentences aimed toward Druid users.
If your change doesn't have end user impact, you can skip this section.
For tips about how to write a good release note, see [Release notes](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#release-notes).
-->
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [ X] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [X ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ X] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers merged pull request #13826: Add `ANSI_QUOTES` mode to DBI init in lookups.
Posted by "paul-rogers (via GitHub)" <gi...@apache.org>.
paul-rogers merged PR #13826:
URL: https://github.com/apache/druid/pull/13826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekrb19 commented on pull request #13826: Add `ANSI_QUOTES` mode to DBI init in lookups.
Posted by "abhishekrb19 (via GitHub)" <gi...@apache.org>.
abhishekrb19 commented on PR #13826:
URL: https://github.com/apache/druid/pull/13826#issuecomment-1437714556
Static checks - Intellij inspections is failing unrelated to this change (I see similar failures on other open PRs):
```
Error: processing/src/main/java/org/apache/druid/data/input/FirehoseFactory.java:90 -- Method is never used as a member of this interface, but only as a member of the implementation class(es). The project will stay compilable if the method is removed from the interface.
Error: processing/src/main/java/org/apache/druid/data/input/InputFormat.java:62 -- Method is never used.
Error: processing/src/main/java/org/apache/druid/data/input/FirehoseFactoryToInputSourceAdaptor.java:48 -- Method is never used.
Error: processing/src/main/java/org/apache/druid/java/util/http/client/HttpClientProxyConfig.java:43 -- Constructor is never used.
Error: processing/src/main/java/org/apache/druid/java/util/http/client/response/FullResponseHolder.java:52 -- Method is never used as a member of this abstract class, but only as a member of the implementation class(es). The project will stay compilable if the method is removed from the abstract class.
```
Also, the IT seems to be flaky - I will try to re-run this failed job to see if it succeeds:
```
Error: ITCombiningFirehoseFactoryIndexTest.testIndexData:98->AbstractIndexerTest.lambda$unloader$0:71->AbstractIndexerTest.unloadAndKillData:85 » ISE Error while making request to indexer [404 Not Found No task reports were found for this task. The task may not exist, or it may not have completed yet.]
Error: ITIndexerTest.testIndexData:134->AbstractIndexerTest.lambda$unloader$0:71->AbstractIndexerTest.unloadAndKillData:85 » ISE Error while making request to indexer [404 Not Found No task reports were found for this task. The task may not exist, or it may not have completed yet.]
Error: ITIndexerTest.testIndexDataAwaitSegmentAvailabilityFailsButTaskSucceeds:315->AbstractIndexerTest.lambda$unloader$0:71->AbstractIndexerTest.unloadAndKillData:85 » ISE Error while making request to indexer [404 Not Found No task reports were found for this task. The task may not exist, or it may not have completed yet.]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org