Re: [PR] Dynamic evaluation of GroupBy Initial Capacity [pinot]

["praveenc7 (via GitHub)" <gi...@apache.org>]

praveenc7 commented on PR #14001:
URL: https://github.com/apache/pinot/pull/14001#issuecomment-2401310382

   > @praveenc7 I see, thanks for checking! I think the only (small) gap here is that when we have
   > 
   > ```
   > select ... where A in (a1, a2, a3) group by A,B
   > ```
   > 
   > Do we currently handle this mixture of bounded + unbounded? ideally the effective card estimation could be calculated with cardinality_product/card(A) * filterlen(A)
   
   @jasperjiaguo  Agree this might create a more tighter bound, currently the cardinality is available for [DictionaryBasedGroupKey](https://github.com/apache/pinot/blob/8334add327fc497689d0cc2c9d4371ecef4c17e5/pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java#L161) so the unbounded case would be mostly applicable to this, might need some more change to support this. Was thinking of doing in a follow up PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org