You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by mi...@apache.org on 2023/06/30 11:18:53 UTC
[superset] branch master updated: fix: Metric is truncated in tooltip (#24555)
This is an automated email from the ASF dual-hosted git repository.
michaelsmolina pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 5bdb774504 fix: Metric is truncated in tooltip (#24555)
5bdb774504 is described below
commit 5bdb7745040e826dc36c6742f05952d69530ee0d
Author: Michael S. Molina <70...@users.noreply.github.com>
AuthorDate: Fri Jun 30 08:18:47 2023 -0300
fix: Metric is truncated in tooltip (#24555)
---
.../superset-ui-chart-controls/src/components/labelUtils.tsx | 7 +++++++
superset-frontend/src/components/Tooltip/index.tsx | 7 +++++++
.../src/explore/components/controls/MetricControl/AdhocMetric.js | 3 +--
3 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/superset-frontend/packages/superset-ui-chart-controls/src/components/labelUtils.tsx b/superset-frontend/packages/superset-ui-chart-controls/src/components/labelUtils.tsx
index accaaf9f49..1bd49c40e0 100644
--- a/superset-frontend/packages/superset-ui-chart-controls/src/components/labelUtils.tsx
+++ b/superset-frontend/packages/superset-ui-chart-controls/src/components/labelUtils.tsx
@@ -31,6 +31,13 @@ const TooltipSectionWrapper = styled.div`
&:not(:last-of-type) {
margin-bottom: ${theme.gridUnit * 2}px;
}
+ &:last-of-type {
+ display: -webkit-box;
+ -webkit-line-clamp: 40;
+ -webkit-box-orient: vertical;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ }
`}
`;
diff --git a/superset-frontend/src/components/Tooltip/index.tsx b/superset-frontend/src/components/Tooltip/index.tsx
index 06469abd13..64af6b06a0 100644
--- a/superset-frontend/src/components/Tooltip/index.tsx
+++ b/superset-frontend/src/components/Tooltip/index.tsx
@@ -45,6 +45,13 @@ export const Tooltip = (props: TooltipProps) => {
/>
<AntdTooltip
overlayStyle={{ fontSize: theme.typography.sizes.s, lineHeight: '1.6' }}
+ overlayInnerStyle={{
+ display: '-webkit-box',
+ overflow: 'hidden',
+ WebkitLineClamp: 40,
+ WebkitBoxOrient: 'vertical',
+ textOverflow: 'ellipsis',
+ }}
color={`${theme.colors.grayscale.dark2}e6`}
{...props}
/>
diff --git a/superset-frontend/src/explore/components/controls/MetricControl/AdhocMetric.js b/superset-frontend/src/explore/components/controls/MetricControl/AdhocMetric.js
index 752fc457b9..e866093ffc 100644
--- a/superset-frontend/src/explore/components/controls/MetricControl/AdhocMetric.js
+++ b/superset-frontend/src/explore/components/controls/MetricControl/AdhocMetric.js
@@ -89,8 +89,7 @@ export default class AdhocMetric {
}
getDefaultLabel() {
- const label = this.translateToSql({ useVerboseName: true });
- return label.length < 43 ? label : `${label.substring(0, 40)}...`;
+ return this.translateToSql({ useVerboseName: true });
}
translateToSql(