[GitHub] [iceberg] rdblue commented on a diff in pull request #6411: Core: Don't produce partition summaries on unpartitioned table

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #6411:
URL: https://github.com/apache/iceberg/pull/6411#discussion_r1046073562


##########
core/src/main/java/org/apache/iceberg/SnapshotSummary.java:
##########
@@ -148,7 +148,7 @@ public void set(String property, String value) {
     }
 
     private void updatePartitions(PartitionSpec spec, ContentFile<?> file, boolean isAddition) {
-      if (trustPartitionMetrics) {
+      if (spec.isPartitioned() && trustPartitionMetrics) {

Review Comment:
   How does this handle void partitions?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org