You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Mark Hindess (JIRA)" <ji...@apache.org> on 2006/04/15 22:23:00 UTC
[jira] Updated: (HARMONY-353) improvements to junit test method
usage
[ http://issues.apache.org/jira/browse/HARMONY-353?page=all ]
Mark Hindess updated HARMONY-353:
---------------------------------
Attachment: improved.assertequals.usage.diff
As well as fixing as many of the obviously incorrect assertEquals calls, I also changed a number of assertTrue(..., false) and assertFalse(..., true) calls to fail calls. And fixed a few assertEquals calls that were testing for null to assertNull.
> improvements to junit test method usage
> ---------------------------------------
>
> Key: HARMONY-353
> URL: http://issues.apache.org/jira/browse/HARMONY-353
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Mark Hindess
> Priority: Trivial
> Attachments: improved.assertequals.usage.diff
>
> While fixing the test in HARMONY-352, I found some confusing junit
> error messages. They were things like:
> error expected <actual> but got <expected>
> rather than:
> error expected <expected> but got <actual>
> Because the arguments to the assertEquals method were the wrong way
> around. The expected value should come first. Anyway, I fixed these
> for that one test. We should try to fix these when we find them and
> we should try to avoid adding any more.
> This JIRA is because I decided that it was reasonable to fix any method like:
> assertEquals(..., <constant>);
> since a constant couldn't very well be the value being tested.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira