[jira] [Work logged] (COLLECTIONS-768) Flat3MapTest.tesetEntrySet() is flaky

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/COLLECTIONS-768?focusedWorklogId=497490&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-497490 ]

ASF GitHub Bot logged work on COLLECTIONS-768:
----------------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Oct/20 18:19
            Start Date: 08/Oct/20 18:19
    Worklog Time Spent: 10m 
      Work Description: tongxin97 opened a new pull request #189:
URL: https://github.com/apache/commons-collections/pull/189


   This patch checks on the removed map entry's value in three assertions, and does not wrongly assume the removed entry is `C=three` like the current test does. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 497490)
    Remaining Estimate: 0h
            Time Spent: 10m

> Flat3MapTest.tesetEntrySet() is flaky
> -------------------------------------
>
>                 Key: COLLECTIONS-768
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-768
>             Project: Commons Collections
>          Issue Type: Bug
>          Components: Map
>    Affects Versions: 4.4
>            Reporter: XinT
>            Priority: Minor
>              Labels: easyfix, pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The testEntrySet() function (org.apache.commons.collections4.map.Flat3MapTest#testEntrySet) is flaky because it uses a flaky helper function putAndRemove(). The helper function wrongly assumes that map iterators execute in insertion order, while in fact it can be any order. 
> The current test asserts the last element iterated (and subsequently removed) is the last element inserted. Therefore, the test passes when it so happens that the last iterated element is the last inserted element, but fails otherwise. 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)