[GitHub] [solr] madrob commented on a change in pull request #196: SOLR-15385 RawTypes Part V

[GitBox <gi...@apache.org>]

madrob commented on a change in pull request #196:
URL: https://github.com/apache/solr/pull/196#discussion_r660134018



##########
File path: solr/core/src/test/org/apache/solr/util/SolrPluginUtilsTest.java
##########
@@ -248,7 +248,7 @@ public void testDisjunctionMaxQueryParser() throws Exception {
         
   }
 
-  private static int countItems(@SuppressWarnings({"rawtypes"})Iterator i) {
+  private static int countItems(Iterator<?> i) {

Review comment:
       I intentionally went with the more general approach here, because I wasn't sure if it would be useful in other place or not. While doing these massive refactorings, I have seen a lot of duplicate or near duplicate code so I'm starting to get a little more sensitive to it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org