[GitHub] [ozone] avijayanhwx commented on a change in pull request #2847: HDDS-5973. Changed sequence of steps during pipeline close.

[GitBox <gi...@apache.org>]

avijayanhwx commented on a change in pull request #2847:
URL: https://github.com/apache/ozone/pull/2847#discussion_r752614389



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineManagerImpl.java
##########
@@ -341,6 +341,9 @@ protected void closeContainersForPipeline(final PipelineID pipelineId)
   public void closePipeline(Pipeline pipeline, boolean onTimeout)
       throws IOException {
     PipelineID pipelineID = pipeline.getId();
+    // close containers.
+    closeContainersForPipeline(pipelineID);

Review comment:
       +1 to the above suggestion. We cannot rely on async handling of moving container from OPEN to CLOSING. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org