You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/03/07 16:39:03 UTC
[GitHub] [shardingsphere] grvmourya opened a new pull request #15863: fix : Space added between the following languages.
grvmourya opened a new pull request #15863:
URL: https://github.com/apache/shardingsphere/pull/15863
Fixes #ISSUSE_ID.
#15851
Changes proposed in this pull request:
-A space added between Chinese and English words so as to view the contents properly and more clearly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] grvmourya commented on pull request #15863: fix : Space added between the following languages.
Posted by GitBox <gi...@apache.org>.
grvmourya commented on pull request #15863:
URL: https://github.com/apache/shardingsphere/pull/15863#issuecomment-1061386669
Ya sure will do have a look at them👍🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Liangda-w commented on pull request #15863: fix : Space added between the following languages.
Posted by GitBox <gi...@apache.org>.
Liangda-w commented on pull request #15863:
URL: https://github.com/apache/shardingsphere/pull/15863#issuecomment-1061103660
Hi @grvmourya, thanks for your contribution! Looks really nice:) Could you pls also take care of the following cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb closed pull request #15863: fix : Space added between the following languages.
Posted by GitBox <gi...@apache.org>.
zjcnb closed pull request #15863:
URL: https://github.com/apache/shardingsphere/pull/15863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #15863: fix : Space added between the following languages.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #15863:
URL: https://github.com/apache/shardingsphere/pull/15863#issuecomment-1061248685
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/15863?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15863](https://codecov.io/gh/apache/shardingsphere/pull/15863?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d662d6) into [master](https://codecov.io/gh/apache/shardingsphere/commit/6235d96632b9f4ce6066499b11a74323b478cb22?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6235d96) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/15863?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15863 +/- ##
=========================================
Coverage 60.48% 60.49%
Complexity 2015 2015
=========================================
Files 3261 3261
Lines 49124 49124
Branches 8411 8411
=========================================
+ Hits 29715 29718 +3
+ Misses 16954 16951 -3
Partials 2455 2455
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/15863?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/text/distsql/ral/common/hint/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/15863/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L0hpbnRTb3VyY2VUeXBlLmphdmE=) | `42.85% <0.00%> (+42.85%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/15863?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/15863?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6235d96...6d662d6](https://codecov.io/gh/apache/shardingsphere/pull/15863?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss commented on pull request #15863: fix : Space added between the following languages.
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on pull request #15863:
URL: https://github.com/apache/shardingsphere/pull/15863#issuecomment-1061349951
> Hi @grvmourya, thanks for your contribution! Looks really nice:) Could you pls also take care of the following cases?
>
> 
>
> 
@Liangda-w nice to see you here again, @grvmourya could you have a look here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org