You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ni...@apache.org on 2024/03/01 12:06:26 UTC

(hbase) branch branch-2.6 updated: HBASE-28408 Rephrase confusing log message (#5718)

This is an automated email from the ASF dual-hosted git repository.

nihaljain pushed a commit to branch branch-2.6
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/branch-2.6 by this push:
     new 102c1b684a8 HBASE-28408 Rephrase confusing log message (#5718)
102c1b684a8 is described below

commit 102c1b684a893dd3475eb2c047414cbe395f9b8e
Author: DieterDP <90...@users.noreply.github.com>
AuthorDate: Fri Mar 1 13:06:19 2024 +0100

    HBASE-28408 Rephrase confusing log message (#5718)
    
    Assume a user has a series of backups: Full1, Inc2, Inc3, where a table has not changed between Full1 and Inc3, but has changed after Inc3. When restoring that table to Inc3, a log warning was outputted mentioning there was no need for a restore. This message in fact means there is no need for the incremental restore portion of the restore process.
    
    Signed-off-by: Nihal Jain <ni...@apache.org>
---
 .../java/org/apache/hadoop/hbase/backup/impl/RestoreTablesClient.java  | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/RestoreTablesClient.java b/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/RestoreTablesClient.java
index 05685c8e091..654fe343e27 100644
--- a/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/RestoreTablesClient.java
+++ b/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/RestoreTablesClient.java
@@ -173,7 +173,8 @@ public class RestoreTablesClient {
     }
 
     if (dirList.isEmpty()) {
-      LOG.warn("Nothing has changed, so there is no need to restore '" + sTable + "'");
+      LOG.info("No incremental changes since full backup for '" + sTable
+        + "', skipping incremental restore step.");
       return;
     }