You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/04/04 15:26:25 UTC

[GitHub] [nifi] mattyb149 commented on issue #3337: NIFI-6016 PutCassandraRecord batch size

mattyb149 commented on issue #3337: NIFI-6016 PutCassandraRecord batch size
URL: https://github.com/apache/nifi/pull/3337#issuecomment-479944722
 
 
   Looks like the PutCassandraRecordTest is a copy-paste for something like QueryCassandra, unfortunately it doesn't mock the methods that PutCassandraRecord calls (like `execute`). We should really refactor that unit test (specifically the mock), if we had we could've tested the number of statements in the batch and caught this error ahead of time.
   
   Having said that, I reviewed the code, +1 LGTM, we can do the test refactor in a separate Jira. Thanks for the fix! Merging to master

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services