You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/04 00:57:41 UTC
[GitHub] [incubator-superset] mistercrunch opened a new pull request #8747:
feat: emphasis on the database engine error message
mistercrunch opened a new pull request #8747: feat: emphasis on the database engine error message
URL: https://github.com/apache/incubator-superset/pull/8747
RFC
when bubbling up error messages surfaced by the datbase, we prefix with
"{engine} error:". In this PR we make the error message capitalized and
bold. To make it bold we introduce the ability to use markdown in error
messages. This also fixes issues where "<html><body>{error_msg}</body><html>"
shows up inside the error message. We've seen Presto and transport layer
generate 50* pages that have html. The react-markdown component here
removes all tags.
<img width="1088" alt="Screen Shot 2019-12-03 at 4 57 17 PM" src="https://user-images.githubusercontent.com/487433/70102772-02b46d00-15ee-11ea-8866-922bdc4c7a48.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org