You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "volosied (via GitHub)" <gi...@apache.org> on 2023/02/16 14:37:27 UTC
[GitHub] [myfaces] volosied opened a new pull request, #525: Update LOG_WEB_CONTEXT_PARAMS options
volosied opened a new pull request, #525:
URL: https://github.com/apache/myfaces/pull/525
https://github.com/apache/myfaces/pull/520#issuecomment-1432835186
Updating to "always, dev-only, never" so that they describe the functionality better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #525: Update LOG_WEB_CONTEXT_PARAMS options
Posted by "tandraschko (via GitHub)" <gi...@apache.org>.
tandraschko commented on PR #525:
URL: https://github.com/apache/myfaces/pull/525#issuecomment-1433708498
TBH it feels a bit overengineered now with to many options for such a small logging
But If its only logged in dev stage per default, im ok with it
Please dont forget the homepage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied commented on pull request #525: Update LOG_WEB_CONTEXT_PARAMS options
Posted by "volosied (via GitHub)" <gi...@apache.org>.
volosied commented on PR #525:
URL: https://github.com/apache/myfaces/pull/525#issuecomment-1433224992
Spotted a new errors -- they're fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied commented on a diff in pull request #525: Update LOG_WEB_CONTEXT_PARAMS options
Posted by "volosied (via GitHub)" <gi...@apache.org>.
volosied commented on code in PR #525:
URL: https://github.com/apache/myfaces/pull/525#discussion_r1108610702
##########
impl/src/main/java/org/apache/myfaces/config/webparameters/MyfacesConfig.java:
##########
@@ -714,14 +714,15 @@
/**
* Indicate if INFO logging of all the web config params should be done before initialize the webapp.
* <p>
- * If is set in "auto" mode, web config params are only logged in "Development" mode.
- * If is set to "true", web config params are only logged in "Production" and "Development" mode.
- * If is set in "false" mode, no info logging occurs in either mode.
+ * If set to "dev-only" mode, web config params are only logged in "Development" mode.
+ * If set to "true" or "always", web config params are only logged in "Production" and "Development" mode.
+ * If set to "false" or "never", no info logging occurs in either mode.
Review Comment:
Maybe?
```suggestion
* If set to "false" or "never", info logging does not occur in any mode.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied commented on a diff in pull request #525: Update LOG_WEB_CONTEXT_PARAMS options
Posted by "volosied (via GitHub)" <gi...@apache.org>.
volosied commented on code in PR #525:
URL: https://github.com/apache/myfaces/pull/525#discussion_r1108610702
##########
impl/src/main/java/org/apache/myfaces/config/webparameters/MyfacesConfig.java:
##########
@@ -714,14 +714,15 @@
/**
* Indicate if INFO logging of all the web config params should be done before initialize the webapp.
* <p>
- * If is set in "auto" mode, web config params are only logged in "Development" mode.
- * If is set to "true", web config params are only logged in "Production" and "Development" mode.
- * If is set in "false" mode, no info logging occurs in either mode.
+ * If set to "dev-only" mode, web config params are only logged in "Development" mode.
+ * If set to "true" or "always", web config params are only logged in "Production" and "Development" mode.
+ * If set to "false" or "never", no info logging occurs in either mode.
Review Comment:
Maybe?
```suggestion
* If set to "false" or "never", info logging does not occur in any mode.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied closed pull request #525: Update LOG_WEB_CONTEXT_PARAMS options
Posted by "volosied (via GitHub)" <gi...@apache.org>.
volosied closed pull request #525: Update LOG_WEB_CONTEXT_PARAMS options
URL: https://github.com/apache/myfaces/pull/525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] bohmber commented on pull request #525: Update LOG_WEB_CONTEXT_PARAMS options
Posted by "bohmber (via GitHub)" <gi...@apache.org>.
bohmber commented on PR #525:
URL: https://github.com/apache/myfaces/pull/525#issuecomment-1433191243
I prefer keep true, false as well for backwards compatiblity. That means always, dev-only, never, true, false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied commented on pull request #525: Update LOG_WEB_CONTEXT_PARAMS options
Posted by "volosied (via GitHub)" <gi...@apache.org>.
volosied commented on PR #525:
URL: https://github.com/apache/myfaces/pull/525#issuecomment-1433212858
@bohmber I've updated the code again. Let me know what you think.
The 5 options now are: always, true, dev-only, never, false, non-production
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] bohmber commented on pull request #525: Update LOG_WEB_CONTEXT_PARAMS options
Posted by "bohmber (via GitHub)" <gi...@apache.org>.
bohmber commented on PR #525:
URL: https://github.com/apache/myfaces/pull/525#issuecomment-1433196475
UnitTest, SystemTest good question. What about none-production or something similar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] bohmber commented on a diff in pull request #525: Update LOG_WEB_CONTEXT_PARAMS options
Posted by "bohmber (via GitHub)" <gi...@apache.org>.
bohmber commented on code in PR #525:
URL: https://github.com/apache/myfaces/pull/525#discussion_r1108618714
##########
impl/src/main/java/org/apache/myfaces/config/webparameters/MyfacesConfig.java:
##########
@@ -714,14 +714,15 @@
/**
* Indicate if INFO logging of all the web config params should be done before initialize the webapp.
* <p>
- * If is set in "auto" mode, web config params are only logged in "Development" mode.
- * If is set to "true", web config params are only logged in "Production" and "Development" mode.
- * If is set in "false" mode, no info logging occurs in either mode.
+ * If set to "dev-only" mode, web config params are only logged in "Development" mode.
+ * If set to "true" or "always", web config params are only logged in "Production" and "Development" mode.
+ * If set to "false" or "never", no info logging occurs in either mode.
Review Comment:
That is up to you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied commented on pull request #525: Update LOG_WEB_CONTEXT_PARAMS options
Posted by "volosied (via GitHub)" <gi...@apache.org>.
volosied commented on PR #525:
URL: https://github.com/apache/myfaces/pull/525#issuecomment-1433774879
I agree with Thomas. I've already changed auto to dev-only, so I'll just close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied commented on pull request #525: Update LOG_WEB_CONTEXT_PARAMS options
Posted by "volosied (via GitHub)" <gi...@apache.org>.
volosied commented on PR #525:
URL: https://github.com/apache/myfaces/pull/525#issuecomment-1433189041
We don't log anything for UnitTest and SystemTest. That should stay the same, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied commented on pull request #525: Update LOG_WEB_CONTEXT_PARAMS options
Posted by "volosied (via GitHub)" <gi...@apache.org>.
volosied commented on PR #525:
URL: https://github.com/apache/myfaces/pull/525#issuecomment-1433551593
No word from Thomas yet so I set it to dev-only here: https://github.com/apache/myfaces/commit/381f2714da9e32ea23a77df20db5983afcc7408d
Will start RC5 release now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org