You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "affo (via GitHub)" <gi...@apache.org> on 2024/02/27 15:54:36 UTC

[PR] [FLINK-34509] [docs] add missing "url" option for Debezium Avro [flink]

affo opened a new pull request, #24395:
URL: https://github.com/apache/flink/pull/24395

   ## What is the purpose of the change
   
   Add missing required option `'debezium-avro-confluent.url'` to Debezium AVRO documentation.
   
   
   ## Brief change log
   
   Updated the docs to include the above.  
   As I result, I splitted JSON and AVRO in 2 sub-sections.
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34509] [docs] add missing "url" option for Debezium Avro [flink]

Posted by "JingGe (via GitHub)" <gi...@apache.org>.
JingGe commented on code in PR #24395:
URL: https://github.com/apache/flink/pull/24395#discussion_r1505936236


##########
docs/content/docs/connectors/table/formats/debezium.md:
##########
@@ -44,7 +44,7 @@ However, currently Flink can't combine UPDATE_BEFORE and UPDATE_AFTER into a sin
 Dependencies
 ------------
 
-#### Debezium Avro
+#### Debezium Avro Confluent

Review Comment:
   should it be "Confluent Avro" instead of "Avro Confluent" for the consistency because of https://nightlies.apache.org/flink/flink-docs-release-1.18/docs/connectors/table/formats/avro-confluent/



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34509] [docs] add missing "url" option for Debezium Avro [flink]

Posted by "JingGe (via GitHub)" <gi...@apache.org>.
JingGe commented on code in PR #24395:
URL: https://github.com/apache/flink/pull/24395#discussion_r1505116020


##########
docs/content/docs/connectors/table/formats/debezium.md:
##########
@@ -133,7 +134,30 @@ In some cases, users may setup the Debezium Kafka Connect with the Kafka configu
 
 In order to interpret such messages, you need to add the option `'debezium-json.schema-include' = 'true'` into above DDL WITH clause (`false` by default). Usually, this is not recommended to include schema because this makes the messages very verbose and reduces parsing performance.
 
-After registering the topic as a Flink table, then you can consume the Debezium messages as a changelog source.
+#### Debezium Avro DDL

Review Comment:
   ```suggestion
   #### Debezium Confluent Avro DDL
   ```



##########
docs/content/docs/connectors/table/formats/debezium.md:
##########
@@ -85,7 +85,9 @@ Debezium provides a unified format for changelog, here is a simple example for a
 *Note: please refer to [Debezium documentation](https://debezium.io/documentation/reference/1.3/connectors/mysql.html#mysql-connector-events_debezium) about the meaning of each fields.*
 
 The MySQL `products` table has 4 columns (`id`, `name`, `description` and `weight`). The above JSON message is an update change event on the `products` table where the `weight` value of the row with `id = 111` is changed from `5.18` to `5.15`.
-Assuming this messages is synchronized to Kafka topic `products_binlog`, then we can use the following DDL to consume this topic and interpret the change events.
+Assuming this messages is synchronized to Kafka topic `products_binlog`, then we can use the following DDLs (for Debezium Json and Debezium Avro) to consume this topic and interpret the change events.

Review Comment:
   ```suggestion
   Assuming this messages is synchronized to Kafka topic `products_binlog`, then we can use the following DDLs (for Debezium Json and Debezium Confluent Avro) to consume this topic and interpret the change events.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34509] [docs] add missing "url" option for Debezium Avro [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24395:
URL: https://github.com/apache/flink/pull/24395#issuecomment-1966893627

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "de5d53b89a629db7c94e1d9bb4c482d617502838",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "de5d53b89a629db7c94e1d9bb4c482d617502838",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * de5d53b89a629db7c94e1d9bb4c482d617502838 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34509] [docs] add missing "url" option for Debezium Avro [flink]

Posted by "affo (via GitHub)" <gi...@apache.org>.
affo commented on PR #24395:
URL: https://github.com/apache/flink/pull/24395#issuecomment-1968635738

   > Thanks @affo for driving it! Just left some comments, PTAL.
   
   Thank you @JingGe for reviewing.
   
   I just added `Confluent` where needed, and also made the use of `JSON` instead of `Json` more consistent @morazow .
   
   Thank you for the reviews.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34509] [docs] add missing "url" option for Debezium Avro [flink]

Posted by "affo (via GitHub)" <gi...@apache.org>.
affo commented on code in PR #24395:
URL: https://github.com/apache/flink/pull/24395#discussion_r1506062195


##########
docs/content/docs/connectors/table/formats/debezium.md:
##########
@@ -44,7 +44,7 @@ However, currently Flink can't combine UPDATE_BEFORE and UPDATE_AFTER into a sin
 Dependencies
 ------------
 
-#### Debezium Avro
+#### Debezium Avro Confluent

Review Comment:
   Sure thing, absolutely correct



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34509] [docs] add missing "url" option for Debezium Avro [flink]

Posted by "JingGe (via GitHub)" <gi...@apache.org>.
JingGe merged PR #24395:
URL: https://github.com/apache/flink/pull/24395


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34509] [docs] add missing "url" option for Debezium Avro [flink]

Posted by "JingGe (via GitHub)" <gi...@apache.org>.
JingGe commented on code in PR #24395:
URL: https://github.com/apache/flink/pull/24395#discussion_r1505936236


##########
docs/content/docs/connectors/table/formats/debezium.md:
##########
@@ -44,7 +44,7 @@ However, currently Flink can't combine UPDATE_BEFORE and UPDATE_AFTER into a sin
 Dependencies
 ------------
 
-#### Debezium Avro
+#### Debezium Avro Confluent

Review Comment:
   should it be "Confluent Avro" instead of "Avro Confluent" for the consistency because of https://nightlies.apache.org/flink/flink-docs-release-1.14/docs/connectors/table/formats/avro-confluent/



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org