[GitHub] [ozone] sadanand48 commented on a diff in pull request #4308: HDDS-6176. Ozone service WebUI is not accessible with 404 error.

["sadanand48 (via GitHub)" <gi...@apache.org>]

sadanand48 commented on code in PR #4308:
URL: https://github.com/apache/ozone/pull/4308#discussion_r1116996230


##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/http/BaseHttpServer.java:
##########
@@ -178,11 +178,13 @@ public BaseHttpServer(MutableConfigurationSource conf, String name)
       }
 
       String baseDir = conf.get(OzoneConfigKeys.OZONE_HTTP_BASEDIR);
-      if (!StringUtils.isEmpty(baseDir)) {
-        createDir(baseDir);
-        httpServer.getWebAppContext().setAttribute(JETTY_BASETMPDIR, baseDir);
-        LOG.info("HTTP server of {} uses base directory {}", name, baseDir);
+
+      if (StringUtils.isEmpty(baseDir)) {
+        baseDir = conf.get(OzoneConfigKeys.OZONE_METADATA_DIRS) + "/webserver";

Review Comment:
   nit : use String literal for `webserver` folder?



##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -2935,7 +2935,7 @@
     <description>
       The base dir for HTTP Jetty server to extract contents. If this property
       is not configured, by default, Jetty will create a directory inside the
-      directory named by the java.io.tmpdir System property（/tmp by default）.
+      directory named by the ozone.metadata.dirs（/tmp/metadata)

Review Comment:
   can remove (/tmp/metadata) part as its not the default location.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org